Giter Site home page Giter Site logo

Comments (5)

yutannihilation avatar yutannihilation commented on June 12, 2024 1

"raw" is an implicit class. extendr's inherits() simply checks the class attribute, while R's inherits() considers implicit class. ?class says:

If the object does not have a class attribute, it has an implicit class, notably "matrix", "array", "function" or "numeric" or the result of typeof(x)

This is the C version of R's ihnerits(), but this isn't exposed as an API. So, there's no easy way to mimic the R's inherits().

https://github.com/wch/r-source/blob/ec91103ee93b1d4e9f46a37c2dece3761192d9aa/src/main/objects.c#L1013

If the behavior is confusing, extendr might be better to consider removing it. But, I guess what you really want is is_raw() in this case, isn't it?

from extendr.

JosiahParry avatar JosiahParry commented on June 12, 2024 1

Good to know! Thank you for sharing that. I suppose is_raw() is what I could be using here. I didn't know about it. In the use case I opted for Raw::try_from() and matched on the results which is sufficient.

I think the inherits() is still useful so I don't think removal should be necessary. I've made a PR #689 to clarify the behavior of inherits() in the docstring.

from extendr.

yutannihilation avatar yutannihilation commented on June 12, 2024

Can this be closed?

from extendr.

CGMossa avatar CGMossa commented on June 12, 2024

from extendr.

yutannihilation avatar yutannihilation commented on June 12, 2024

No problem (anyway I don't have permission to close, you know). I was just wondering if this was forgotten to be closed when #689 got merged.

from extendr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.