Comments (7)
Hi, I would love to help but I don't have much experience in Rust. Can I take this issue ?
from gitui.
Hy @MCord thanks for your interest in helping❤️! Absolutely you can grab this one - let me know when you need any input!
from gitui.
So here is my first question: do we want to define a custom error for asyncgit
lib or use the git2::Error
? in many cases the underlying error is git2::Error
but for example in hook::hooks_commit_msg()
it might be an std::io::Error
or if for whatever reason we can not get a temp file name we have to return some kind of error, which type would that be ?
from gitui.
Good question. I was expecting to have to come up with a lib specific Error using thiserror and wrapping git2::Error
,... in it to have the most flexibility. what do you think?
from gitui.
Ok, let's try that. I will send a PR so we can discuss the implementation.
from gitui.
Really cool! Thank you❤️!
from gitui.
I have created a pull request #58. I will continue when you give me some feedback.
from gitui.
Related Issues (20)
- Better conflicts flow
- Page Up/Down buttons are not scrolling in Status and Files tabs HOT 1
- View combined directory diff / multiple files
- How to focus panes rather than move into them? HOT 2
- File autofocus fails on embed folders HOT 2
- Unable to switch tab using number row HOT 3
- show newer commits if on detached head
- PATH not respected in hooks HOT 6
- Can't fetch/pull on WSL
- listen for SIGINT signal instead of exit key bind HOT 4
- Stashing.FilesToStash window disappears after History/Blame
- add export variable for themes to used HOT 2
- Using rustls instead of openssl? HOT 4
- Syntax highlighting: Typescript files not highlighted HOT 1
- Theme file not loading on macOS HOT 3
- Add syntax highlighting options for commit titles inside the log view
- it always return to 'Status [1]' tab after editing a file from 'Files [3]' tab. any way to change it? HOT 3
- Fail to execute gitui on mac. HOT 3
- Support `fixup` workflow HOT 3
- feature request for support branch.sort
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitui.