Giter Site home page Giter Site logo

more error handling about gitui HOT 7 CLOSED

extrawurst avatar extrawurst commented on May 1, 2024
more error handling

from gitui.

Comments (7)

MCord avatar MCord commented on May 1, 2024 1

Hi, I would love to help but I don't have much experience in Rust. Can I take this issue ?

from gitui.

extrawurst avatar extrawurst commented on May 1, 2024

Hy @MCord thanks for your interest in helping❤️! Absolutely you can grab this one - let me know when you need any input!

from gitui.

MCord avatar MCord commented on May 1, 2024

So here is my first question: do we want to define a custom error for asyncgit lib or use the git2::Error ? in many cases the underlying error is git2::Error but for example in hook::hooks_commit_msg() it might be an std::io::Error or if for whatever reason we can not get a temp file name we have to return some kind of error, which type would that be ?

from gitui.

extrawurst avatar extrawurst commented on May 1, 2024

Good question. I was expecting to have to come up with a lib specific Error using thiserror and wrapping git2::Error,... in it to have the most flexibility. what do you think?

from gitui.

MCord avatar MCord commented on May 1, 2024

Ok, let's try that. I will send a PR so we can discuss the implementation.

from gitui.

extrawurst avatar extrawurst commented on May 1, 2024

Really cool! Thank you❤️!

from gitui.

MCord avatar MCord commented on May 1, 2024

I have created a pull request #58. I will continue when you give me some feedback.

from gitui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.