Command Commit [enter] closes/crashes gitui-win

[extrawurst]

Command Commit [enter] closes/crashes gitui-win

[extrawurst]

so instead of panicking it should show an expressive error now:

will roll out in next release

[alistaircarscadden]

After some testing I discovered that the bug does not occur after I run git config user.name myname. So, without a username it crashes, and with a username it works just fine. With or without an email it works, as long as it has a name.

[extrawurst]

Good point! Currently it is expected to have the name set. Let me look into it

[extrawurst]

should be fixed in 0.3.0: https://github.com/extrawurst/gitui/releases/tag/v0.3.0

[alistaircarscadden]

I did a bit more looking around, and discovered I was wrong in my most recent comment. The git behaviour is it allows a commit to be made as long as at least a user.name or user.email is provided. The author shows up as unknown <[email protected]> if only an email is provided or name <> if only a name is provided.

When the condition is not met it shows the *** Please tell me who you are. message.

So, as it is right now gitui does not allow me to make a commit when git commit allows me to. Good work, by the way! :)

[extrawurst]

I am not sure I follow. Does the crash persist for you? Is there a different behavior that we need to look into?

[extrawurst]

@alistaircarscadden make sure to reopen the ticket if there is still the issue

[alistaircarscadden]

The crash is fixed, and I see the menu that you showed in your screenshot. I'm considering it may be a bug that gitui does not allow a commit in the same conditions git does allow one.

The conditions are when a user.email is present, and a user.name is not. git commit works, but committing with gitui does not.

e: but I am not familliar with the internals of your program, so to you this may be the correct behaviour. I would imagine it's needing a name for some reason, but if your program is just making a call to git commit, it should work.

[extrawurst]

@alistaircarscadden what error does it show when trying to commit in those conditions?

[extrawurst]

@alistaircarscadden gitui does not use the git cli and you are right, what works in regular git, should be possible in gitui. Please file a new ticket for this and please add the error message that gitui currently returns in that case.

[alistaircarscadden]

Ok! It's more complicated than I thought, I'll make an issue.