fabiang/assetic-module

Laminas, Zend Framework and Mezzio module for Assetic. Asset management system for your vendor folders.

assetic-module's Issues

Listener on dispatch instead of render

Hi,

I am implementing this library, but now I run into the fact that the listener listens on an dispatch event with quite high priority. What is the reason for this?
As you are triggering a function renderAssets this does not make sense. For instance if your controller forwards to another controller, you cannot use that information because that happens on a lower prio dispatch event.
Could it be changed to trigger on render?

See \Fabiang\AsseticBundle\Listener->attach

PHP8 Install, assetic/framework require directive is interfering

Hello Fabian!

I was hopeful to give your module a try, I saw your message in widmogrod/assetic, that you were working on PHP8 in here - and that's exactly what I need.

Issue I've run into is that this module requires assetic/framework ^2.0, however, that version does not support PHP8. It's necessary to move to dev branches of assetic/framework for now.

In other words, this doesn't work:

    "fabiang/assetic-module": "3.0.1",
    "assetic/framework": "dev-develop",

Would you be open to a simple PR that adjusts "assetic/framework" to a newer version?

Media selector support for stylesheet

Hi Fabian,

Great work on maintaining this module, however I'm missing a small feature.

When using the ViewHelperStrategy there is no option to specify the media selector, which causes it to be 'screen' this is an issue when trying to print the page.
In the View/Helper/Asset class there seems to be support for the media option.

Could you add it to the strategy?