fabric8-ui/fabric8-recommender

Analysis and recommendations for app dev

fabric8-recommender's Issues

Reset the modal values after it has been closed

Error thrown when the Stack Analysis API response has { "error": "Analysis for request ID 'e7815fca5e0946ab8701220fbda22e38' is in progress" }

This happens because when the API returns a valid response, the code assumes it is a proper and valid response and hence it fails for some checks.

Implement UX changes for the Dependency/Component feature

1. Basic setup
2. Creation of table with static data
3. Introduce Filters for handling dynamic filtering in the table
4. Make the UI in sync with UX design mockup

Convert to LESS and add Stylelint

Convert all .scss files to .less and add Stylelint to check code quality. File structure, configurations and rulesets will be updated to match fabric8-ui.

Stacks recommendation build # shows a hash

openshiftio/openshift.io#583

Bug: show the unknown license count for unique unknown licenses

Currently, we display just the count of total unknown licenses ignoring the fact that a license can be unknown for two components, but at stack level this has to be taken only once to show the count.

Implement Loader during the stack analysis API call

It sometime takes a while for the network to respond and it is always good to have a loader in such times.

Stack Report is incomplete for code metrics

From @christian-posta on June 21, 2017 15:33

See this image:

Copied from original issue: openshiftio/openshift.io#275

Call stack analysis service only after click of button

Please look into this

Stacks recommendation problems after a second run of the pipeline.

openshiftio/openshift.io#584

"BVT" against every PR should be enabled

"BVT" against every PR should be enabled

Presently , recommender doesn't have Build verification tests running against PR's.

• Unit tests
• smoke tests
  should be enabled before merging the code into the master !

Add realm provider in the codebase for the standalone to run

Usage outlier number and details mismatch

openshiftio/openshift.io#1959
Above issue is closed in openshift.io but it is valid in this recommender portal

Make the hardcoded stack-analysis api url to be dynamic

Text overflow in dependencies table

Implement recommender feature as per mock.

Change the current recommender feature's look to make it in sync with the mock.

1. Handle Actions for the recommendations - Done
2. Handle Single Work Item addition scenario - Done
3. Handle Multiple work item addition scenario - Done
4. Handle styling

Wrong number in analyzed_dependencies_count?

An example how the stack analyses v2 output look like - there's and array with one analyzed dependency, but the attribute analyzed_dependencies_count says it is zero:

                "analyzed_dependencies": [
                    {
                        "version": "6.7",
                        "package": "click"
                    }
                ],
                "analyzed_dependencies_count": 0,

Bayesian Stack Report: does not update during pipeline runs

From @burrsutter on June 7, 2017 17:22

https://screencast.com/t/gATQgadjjBV
shows 2 deps but there are 3, I added one, a bad one
https://github.com/burrsutter/vertxbasic23/blob/master/pom.xml#L44
and no recommendations are offered, even with the bad dep added to my pom.xml
Note: this dep is flagged in Che, just not during the pipeline run

Copied from original issue: openshiftio/openshift.io#207

Update Tests to Run on MacOS

Issue:
When trying to run npm run test on MacOS, they console hangs and never gets passed the 'Starting Webdriver and Selenium' step. In order to fix this, the user needs to manually change the run_functional_tests.sh file to use "nc" instead of "ncat".

Request:
Update run_functional_tests.sh to use "nc" rather than "ncat". This will allow the tests to run on both Linux and MacOS.

Add semantic-release

Once fabric8-recommender is running as module we need to port the semantic-release stuff over (see https://github.com/fabric8-ui/ngx-widgets#continuous-delivery--semantic-relases)

Unit tests fail

Currently the one of the unit test is failing

here is gist log link :https://gist.github.com/naina-verma/2e27afc7b6abfdc9b3243512fe15b36d

fabric8-stack-analysis-ui cannot locate c3

While converting fabric8-ui to use Less, @mindreeper2420 and I encountered a new issue with the webpack build. That is, the build fails to compile while complaining that fabric8-stack-analysis-ui cannot locate c3.

ERROR in ./~/fabric8-stack-analysis-ui/src/app/stack/overview/chart-component.js
Module not found: Error: Can't resolve 'c3' in '/Users/dlabrecq/Work/alm/repos/fabric8-ui/node_modules/fabric8-stack-analysis-ui/src/app/stack/overview'

I don't see c3 as a dependency in package.json, but chart-component.js appears to require it.

import * as c3 from 'c3'; <<< Line 7 of chart-component.js

That said, the work around is to modify webpack to use Patternfly's c3 dependency, like so. However, this is something we should resolve in the fabric8-stack-analysis-ui package instead.

resolve: {
...
      modules: [helpers.root('src'), helpers.root('node_modules'),

        // Todo: fabric8-stack-analysis-ui/src/app/stack/overview/chart-component.js cannot locate c3
        helpers.root("node_modules/patternfly/node_modules/c3"),
        helpers.root("node_modules/patternfly/node_modules/d3")
      ]

Note the error is reproducible with the Less conversion branch.

https://github.com/mindreeper2420/fabric8-ui/tree/less-conversion

In the dependency grid, lines of code should show as 'NA' if there is no lines of code for any dependency.

Remove js modal and reuse existing ng2-modal

Remove js modal and reuse existing ng2-modal from shared component

Recommendation list not fetching data from API

Recommendation list not fetching data from API

Move the stack components to a new component

1. Move stack components related code to a new component.

Reasons:

It takes up a lot of space in main module.
It makes things clearer and easier to find

@invincibleJai Could you move this? If not, I can take this up.

Stack view is breaking

Stack view is breaking Error (error_handler.js:50 ORIGINAL EXCEPTION: Cannot read property 'stargazers_count' of undefined) @arunkumars08

Semantic Release

Set up and configure Semantic Release so that each commit with the correct syntax releases a new version on npmjs.

Implement UX changes for recommender feature

1. Introduces the Restore Recommendation Item.

Stack overview: Overview cards should be responsive and text should not overflow

Stack Report Dropdown: Display only the meaningful portion of the manifest file path

In stack report, a dropdown has been introduced that enables users to change reports for different manifest files in a multi-module application. Currently, that dropdown displays the full build path of manifest files that includes unnecessary reference of a temporary build location.

See https://www.screencast.com/t/DTyNN6zia

Please display only the meaningful portion from the application's context in the dropdown. Also, please make sure that this change is verified by the UX team.

CC: @jyasveer

[Feature]Stack Analysis: Kronos recommendation UX and UI Changes

Hardcoded "stackurl", should pick environment variable

Hard coded "stackurl", should pick environment variable

app.component.ts should fetch environment variable , currently the value of stackUrl: string = is hardcoded

Unit Test Cases for various components

This issues tracks the implementation of unit test cases for all the components in the bayesian workflow.

Stack analyses v2 - userstack.dependencies array is empty

I'd say that the userstack.dependencies array would contain info taken from the original requirements.txt file.

Update the way the API URL is discovered

1. Add this file to fabric8-ui/fabric8-recommender https://github.com/fabric8io/fabric8-ui/blob/master/src/app/analyze/stack/recommender-api.ts and remove it from fabric8io/fabric8-ui
2. Use @Inject(RECOMMENDER_API_URL) apiUrl: string to inject the api url in to any component, and remove all code that refers to process.env

Bring in a provider to fetch a default token when running in standalone mode

Create constants file for moving Hardcoded strings to one place

This helps in easier change and access.

Bug: Build report doesn't show the declared licenses

From @luebken on June 7, 2017 14:5

In the stack report the dependencies should report the licenses declared by the project.

Associated test-cases:

• Test-1704E469-02

  • io.vertx/vertx-core/3.4.1 should report Apache 2.0, EPL 1.0

• Test-1704E469-03

  • io.vertx/vertx-web/3.4.1 should report Apache 2.0, EPL 1.0

• Test-1704E469-04

  • org.springframework/spring-core/4.3.3.RELEASE should report Apache 2.0

Associated experience:

• Experience 1704E469 [P0] – License information

Copied from original issue: openshiftio/openshift.io#205

Make the NPM package production ready

1. Include all the necessary version upgrades
2. Upgrade webpack.
3. Introduce Release cycles.

Implement the stack overview feature as per new mock

Stack Report Recommendations never populates

From @burrsutter on June 7, 2017 21:30

https://screencast.com/t/3vK0v13q6p

Copied from original issue: openshiftio/openshift.io#208

In Code Metrics section, lines of code, avg cyclomatic complexity, total files should show as 'NA' if there is no data/-ve values.

• In Code Metrics section, lines of code, avg cyclomatic complexity, total files should show as 'NA' if there is no data/-ve values.

Update Login

The login client needs to be configured to work when imported into fabric8-ui. Possibly in standalone mode too.

Dependency grid - Column titles are not properly aligned. All should be aligned vertically middle.

Typo in stack analysis v2 result JSON

outlier_prbability should be outlier_probability:

           "recommendations": {
                "companion": [],
                "usage_outliers": [
                    {
                        "package_name": "wheel",
                        "outlier_prbability": 0.71875
                    },
                    {
                        "package_name": "setuptools",
                        "outlier_prbability": 0.640625
                    }
                ],
                "alternate": []

Typo in work item screen after creating work items from recommender

Steps to reproduce:

1. Login to openshift
2. Create a new space
3. Use the starter application and create a starter project (say Vert.x basic)
4. Go to pipelines tab
5. Trigger a pipeline build for the one that you have created.
6. Stack analysis report link will show up (Else log an issue in this repo for the same)
7. Click on stack analysis link (A modal will show up)
8. Click on create work item if any
9. Go to the view work item link
10. Check the typo in the description (It has to be potential version upgrade instead of 'potentially')

Creating NPM module

create and modal and stack report content should be part of it

create and modal and stack report content should be part of it

Bug: No /stack-analysis results for known stack

From @luebken on June 29, 2017 11:33

I started a stack analysis for https://github.com/openshiftio-vertx-boosters/vertx-http-booster

The results seem broken:

curl -sH "Authorization: Bearer $OSIO_TOKEN" $API/stack-analyses/74703fe130004ce2aef674c4dd0dcb48
{
    "finished_at": "2017-06-29T10:59:10.516466",
    "recommendation": {
        "recommendations": {
            "component_level": null,
            "similar_stacks": []
        }
    },
    "request_id": "74703fe130004ce2aef674c4dd0dcb48",
    "result": [
        {
            "_audit": {
                "ended_at": "2017-06-29T10:59:10.516466",
                "started_at": "2017-06-29T10:59:10.494493",
                "version": "v1"
            },
            "_release": "None:None:None"
        }
    ],
    "schema": {
        "name": "stack_analyses",
        "url": "http://recommender.api.openshift.io/api/v1/schemas/api/stack_analyses/2-1-4/",
        "version": "2-1-4"
    },
    "started_at": "2017-06-29T10:59:10.494493"
}

Copied from original issue: openshiftio/openshift.io#302