fac-11 / rrmbe Goto Github PK
View Code? Open in Web Editor NEWHello Passwords Fraudsters!
Hello Passwords Fraudsters!
The DOM function rendering the response
How are search suggestions displayed?
Binary search, limit results to five
Makes the GET request from the user input.
Do this when we have an MVP.
Help is here: https://devcenter.heroku.com/articles/getting-started-with-nodejs#introduction
potentially, we could use styled <ul>
as an alternative: https://discuss.atom.io/t/what-alternative-is-there-for-a-searchable-dropdown-select-box/32812
(linked to #17 )
Just ran your site using the chromeVOX extension, everything is all good.
Is there a way for chromeVOX to voice back the options when you enter a password?
For e.g
I type in qwerty, and I get a list of results, is there a way for these results to be played back as I arrow down through the list?
I'm just thinking that it would be useful for people that are blind/visually impaired, to be informed about the results through audio.
-nice feature if this is intended behaviour (the two lists are spearated)
https://github.com/FAC-11/RRMBe/graphs/contributors
try to have an even amount of commits between the members of your team. Swapping pairs and swapping driver/navigator regularly between your pair are really useful, and helps to ensure everyone is across all of the code.
Add this well done message to the message <section>
in HTML.
Is the data ready?
How does it render on mobile? ๐ฑ
Use Accessibility extension and HTML outliner; create issues where needed.
Make it purty โจ
I think this may have been from some poor examples on my part from the code along (sorry!) but in your handleFile and handleOther functions you don't actually use the request
argument ever (you use the request in your router to get the url, and use that to get and pass in the fileName) so you could remove request
from those functions to make things a little clearer.
In your CSS you are styling on lots of straight element selectors (p
, article
etc). I know in the case of how small this app is it's not actually detrimental to be doing this, but I would strongly recommend enforcing good CSS practices on yourself by only using class selectors for styling.
check out https://cssguidelin.es/ for more info on good CSS practices.
password football
appearing 12 times.
When user shortens the string in the textbox, passwords appear in drop down that could have appeared earlier (but dropdown was empty)
In handleSearch you use a regex to replace the "/search/" from the url with nothing, why a regex assigned to a variable and not just a string of "/search/"
in the .replace
method?
(this issue isn't being raised because I think you're wrong I'm just interersted if there was a particular reason to do it in this way)
It might be nice to route based on a whitelist,
see this example.
Problem with just testing for existence of 'public' in string:
it's a little thing but having the images for your readme in your repo bloats it a bit, a good technique is to get github to host them for you by opening an issue, upload the image as a comment to that issue, then use the markdown github generates in your readme, then you have your own images in your readme without having them bloat up your repo :)
see: dwyl/learn-amazon-web-services#24 for more.
Since your getPasswords function in search.js just takes an input and then passes it directly on to passwordSearch and returns the result of passwordSearch, the extra function isn't actually doing anything apart from composing the function with the password array, which you could do when you call the function.
Identical key-value pairs should be able to be written in shorthand - specifically in the fileName object which resides in router.js`
In your instructions for running locally (which I'm super glad you've included for this ace site! ๐) you instruct the person trying to run it to run npm init
when I think you meant to put npm install
๐ at first when I was looking at it and I thought "huh, I womder why they're using a for loop
instead of an array method..? Then I see, you're using break
to make your code more performant. This is super cool and I'm really happy to be seeing these kinds of performance considerations in your code.
๐ โค๏ธ ๐ฅ
(feel free to close straight away, just wanted to say this on record)
focus on search function and requests
Will require #14.
At the moment, it's bringing back loads of search results, which slows down the user's browser
Work out the best tags for the user inputs.
Use decodeURIComponent(), probably in search.js
Not really an issue, but in handlers.js, you have a console.log on line 13.
Our search of the passwords is a naive array iteration, and as the list of passwords is 100k long this is slowing down the autocomplete.
Could we optimise the search module or data structure further?
Perhaps include user stories (or even a persona).
Add the array to our files.
Create the two event listeners (see code comments for hints!)
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.