fac-11/rrmbe

Hello Passwords Fraudsters!

rrmbe's Issues

Create index.js callback function

The DOM function rendering the response

Decide on UX

How are search suggestions displayed?

Create search.js

Binary search, limit results to five

Write request.js

Makes the GET request from the user input.

Set up heroku!

Do this when we have an MVP.

Help is here: https://devcenter.heroku.com/articles/getting-started-with-nodejs#introduction

Backwards compatibility

potentially, we could use styled <ul> as an alternative: https://discuss.atom.io/t/what-alternative-is-there-for-a-searchable-dropdown-select-box/32812

(linked to #17 )

Accessibility - Improvement suggestion?

Just ran your site using the chromeVOX extension, everything is all good.

Is there a way for chromeVOX to voice back the options when you enter a password?

For e.g

I type in qwerty, and I get a list of results, is there a way for these results to be played back as I arrow down through the list?

I'm just thinking that it would be useful for people that are blind/visually impaired, to be informed about the results through audio.

dropdown contains results both from suggestions and from browser's autocomplete

-nice feature if this is intended behaviour (the two lists are spearated)

Try to spread commits between team members

https://github.com/FAC-11/RRMBe/graphs/contributors

try to have an even amount of commits between the members of your team. Swapping pairs and swapping driver/navigator regularly between your pair are really useful, and helps to ensure everyone is across all of the code.

Message if search returns nothing

Add this well done message to the message <section> in HTML.

Adjust data to allow results sorted by popularity

Is the data ready?

try out on mobile

How does it render on mobile? 📱

Run accessibility audits

Use Accessibility extension and HTML outliner; create issues where needed.

Write style.css

Make it purty ✨

unused arguments in handlers

I think this may have been from some poor examples on my part from the code along (sorry!) but in your handleFile and handleOther functions you don't actually use the request argument ever (you use the request in your router to get the url, and use that to get and pass in the fileName) so you could remove request from those functions to make things a little clearer.

datalist as our input?

Styling on selectors other than class

In your CSS you are styling on lots of straight element selectors (p, article etc). I know in the case of how small this app is it's not actually detrimental to be doing this, but I would strongly recommend enforcing good CSS practices on yourself by only using class selectors for styling.

check out https://cssguidelin.es/ for more info on good CSS practices.

Clones appearing in our datalist

password football appearing 12 times.

autocomplete results are inconsistent

When user shortens the string in the textbox, passwords appear in drop down that could have appeared earlier (but dropdown was empty)

Write server.js

• Starts server
• Links to the router function

Why use regex in handleSearch?

In handleSearch you use a regex to replace the "/search/" from the url with nothing, why a regex assigned to a variable and not just a string of "/search/" in the .replace method?

(this issue isn't being raised because I think you're wrong I'm just interersted if there was a particular reason to do it in this way)

Make handle public a whitelist

It might be nice to route based on a whitelist,
see this example.
Problem with just testing for existence of 'public' in string:

1. a search term might include 'public', resulting in a search request being routed to handlePublic;
2. depending on how handlePublic is implemented, it might be possible to formulate a request using something like '/public/../' to access files in root. It would be nice to prevent this in router.

images for readme in repo

it's a little thing but having the images for your readme in your repo bloats it a bit, a good technique is to get github to host them for you by opening an issue, upload the image as a comment to that issue, then use the markdown github generates in your readme, then you have your own images in your readme without having them bloat up your repo :)

see: dwyl/learn-amazon-web-services#24 for more.

getPasswords is moot

Since your getPasswords function in search.js just takes an input and then passes it directly on to passwordSearch and returns the result of passwordSearch, the extra function isn't actually doing anything apart from composing the function with the password array, which you could do when you call the function.

Make ES6 objects less verbose

Identical key-value pairs should be able to be written in shorthand - specifically in the fileName object which resides in router.js`

Mistake in local running instructions

In your instructions for running locally (which I'm super glad you've included for this ace site! 🙏) you instruct the person trying to run it to run npm init when I think you meant to put npm install

Write router.js

Ace work on the passwordFilter function

👌 at first when I was looking at it and I thought "huh, I womder why they're using a for loop instead of an array method..? Then I see, you're using break to make your code more performant. This is super cool and I'm really happy to be seeing these kinds of performance considerations in your code.
🎉 ❤️ 🔥

(feel free to close straight away, just wanted to say this on record)

Create test.js

focus on search function and requests

create handlers.js

• at least 2 dealing with the request
• one with response.end to set headers

Display results by popularity

Will require #14.

limit the number of search returns

At the moment, it's bringing back loads of search results, which slows down the user's browser

Write index.html

Work out the best tags for the user inputs.

Decoding the now encoded search strings

Use decodeURIComponent(), probably in search.js

Remove unnecessary console.log in handlers.js

Not really an issue, but in handlers.js, you have a console.log on line 13.

Autcomplete is a little laggy

Our search of the passwords is a naive array iteration, and as the list of passwords is 100k long this is slowing down the autocomplete.
Could we optimise the search module or data structure further?

Write README

Perhaps include user stories (or even a persona).

Set up data file

Add the array to our files.

Write index.js event listeners

Create the two event listeners (see code comments for hints!)