fac-11/the-factory

Share your ideas and find devs in the FACtory

the FACtory 💡

Share your ideas and find devs in the FACtory

Why?

User Story

Abdullah is such a creative guy but sometimes his mind goes blank and he is stressing out because in 2 weeks from now we will all be pitching for ideas.

Bart, as a qualified programmer, is looking for some projects where he could implement his skills. And Constantina, a business woman is looking for developers and idea that will make her rich.

Let's join all of them! The FACtory is a platform that will help you get ideas for projects and connect you with developers to implement your super cool idea. After this, Abdullah, Bart and Constantina will be much happier.

As a user I can:

• Visit the website and see a landing page with two buttons (Have an idea and got skills)

• Click on "got an idea?" which will direct me to the submit idea page, where I can fill in a form to submit my idea.

  • Enter information into a simple form to explain the idea
  • Be able to comment on the idea

• Click on "got skills?" where I can see a list of submitted app ideas.

  • See a small amount of information about the ideas
  • See the most recently posted ideas at the top of the page
  • See more detail for the ideas when clicking

• Specify if interested in working on an idea through commenting

• Upvote an idea using lightbuld icon.

• Stretch: Filter ideas based on requirements (e.g Front-end, Back-end, UX, etc)

What

A platform that connects people who have app ideas with people with skills to build it.

Database Schema

Users

Column	Types	Modifiers
id	serial	PRIMARY KEY
name	VARCHAR(100)	NOT NULL
email	VARCHAR(100)	NOT NULL UNIQUE

Ideas

Column	Types	Modifiers
id	serial	PRIMARY KEY
userid	REFERENCES	users(id)
dateadded	TIMESTAMP	NOT NULL UNIQUE
ideatitle	VARCHAR(100)	NOT NULL
ideadesc	TEXT	NOT NULL

Learning outcomes

1. Parties on Thursdays are not a good idea

2. Rebeca will become a singer soon

3. Promises are cool!

the-factory's Issues

styling

console.log in helpers.js

Please delete https://github.com/FAC-11/the-FACtory/blob/master/src/controllers/helpers.js#L5

Get ideas page

-Set up a get ideas page -->

Person that has an idea go to the ideas main page, the input fields will be:

-Your name
-Your email
-Your idea
-Description
-Submit button

test database

create separate database

Handlebars

• Layouts
• Partials
• Body files

Helpers folder

Helpers, should usually go in their own folder within the views folder?

Views/helpers/capitalize.js ?

instructions for running locally

It might be helpful to have instructions on how to run your project locally - perhaps this would be a good use of a readme?

favicon is wrong

it loads a fish, not a lightbulb

Tests can't work on validator.js [resolved, just refactoring]

When I run the tests, the throw new error disrupts the tape tests.

Good news is that I have fixed this now so you can relax : )

Will be pushing up the branch soon, with PR which can hopefully be merged tomorrow so we can showcase the tests that we have done in our presentation.

Basically I refactored the validator tests so they take a callback which can handle the error, this made the tape tests work again, and just had to include an anonymous function in the validator test function invocations inside the promise, so catch can deal with it. Example shown below:

validator.checkIdeaTitle(data, (err, res) => {
if (err.message) throw new Error(err.message);
});

Note: This has not broken the promises and everything is working fine : )

File structure

1. Public:
   a) css
   b) public.js
   c) favicon
   d) assets

2.src
a) Model
a.1) Queries
a.1.1. Get data
a.1.2. Post data
a.1.3. Upvote data
a.2. Db_build_Sql
a.3. Db_build.js
a.4. Db_connection.js
b. Controllers
c. Layouts
d. Partials
e. Tests
F. GITIGNORE
g.config.env

Use supertest to test express routes

istanbul coverage - add validator test to test script

Got skills button on homepage points to the wrong place

should be pointing to /browse

Meaningful naming

https://github.com/FAC-11/the-FACtory/blob/master/src/controllers/browse.js#L20 it is unclear what is stuff.

same in here https://github.com/FAC-11/the-FACtory/blob/master/src/controllers/view-idea.js#L21

Stretch goal: be able to filter the ideas from your skills

the lightbulb is amaaazing :D

Post-idea Function

This will post the data into the database, using PSQL

Awesome idea guys!!!

💥

Validator.js - Add a Regex for title and description fields to allow full stops and commas

We need to add a regex that will allow full stops in the title and description fields.

Dependencies install

-Tap-spec
-Nodemon

• Istanbul
  -Eslint
  -express
  -body-parser
  -tap-diff
  -tape
• express-handlebars

Consider rendering form validation errors under form

At the moment we are taking users away from the form when they have missed an input etc. which could be annoying?

Lines longer than 80 characters

https://github.com/FAC-11/the-FACtory/blob/master/src/controllers/view-idea.js#L5 is not readable

SELECT users.firstname, ideas.dateadded, ideas.ideatitle, ideas.ideadesc FROM ideas INNER JOIN users ON users.id = ideas.userid WHERE users.id=${req.params.number}

can be divided into multiple lines:

SELECT users.firstname, ideas.dateadded, ideas.ideatitle, ideas.ideadesc 
FROM 
ideas INNER JOIN users 
ON users.id = ideas.userid 
WHERE users.id=${req.params.number}

A couple of files are empty

Example:

• the-FACtory/src/model/queries/getData.js

Two test folder

Get rid of empty test folder. Rest of the tests are looking good!

validate the form

BUild a database with PSQL to store and retrieve the data

The database will include:

Endpoint /browse

Lots of ideas that you can click and that will redirect you to the idea hbs -->/browse/:idea -->
and that idea page will have all the information (Description, comment....)

add vote rating

with a lightbulb that shines --> as per the rating

Database schema

User table:
- Id
- Name
- Surname
-Email
Ideas Table
- Id
- user id references to ....
- Idea title
-Idea description
- skills set
Comments table
-Id
- Comment
-Name optional

No start script in package.json

Pretty standard to have this script, is also what a lot of hosting environments use to build your project - I noticed the heroku link isn't working, this could be why.

relates #49

Consider adding more tests

Example:

• the-FACtory/src/controllers/promise.js

invalid charecters

when i typed a comma, or an explanation mark in the description it said that they were invalid comments .

Create database files

large number of branches

There's lots of commits, which is fantastic. Perhaps you could close the merged branches to make your codebase easier to navigate?

Add logout functionality

Currently can't logout

checking inputs?

👍
I like how new ideas get put up straight away and without bugs - however, I wonder if you need more in the way of input checking to guard against XSS injection attacks in your text entry boxes.

Server -side validator

1. SUbmit the idea
2. post the idea request
3. The idea goes to the body parser middleware
4. Creates a promise called validator
5. In the validator, the form-object will be validated to check all the fields are 'valid' or 'coherent'
6. If there is an error -> error page.
7. If valid, this will go to the database by a post idea function.

Modularise the validator functions

refactor by stripping out the validator functions and putting into a separate file

Set up express server, hbs, and routes

light bulb favicon

Add npm test script to run all the tests using tape

Once submitted the idea --> a congratulations page

Once the idea is submitted, you will be redirected to a 'congrats page' where there will be a congratulations message and a link to the home page.

landing page

create simple landing page with lightbulbs and buttons

server-side rendering to be displayed on the front-end

Using Hbs templates