The week4-3to5 from fac-11

Get images from API

Should be able to display images of the selected Pokemon from the API.

Fix regex

Regex is braking list items wrong. We need to break it down after every new line. It is skipping dashes and spaces in names. We also need to make sure numbers are included.

Regex for hyphenated or multi-word names

Could put new line at end of match? e.g \n$ ??

Write search function

To retrieve results from data / list of pokemon

Delete top lines in main.js

(function() { var results = ['pikachu', 'coffin', 'jigglypuff', 'squirtle', 'ekans']; })();

no longer needed

Autocomplete words

When typing into the input a list of complete, related words must be displayed

Regex doesnt work

in order to concatenate a variable with a regex pattern, must use double backslashes for escaping

https://stackoverflow.com/a/2712896

Readme checklists broken

Fix checklists in readme there should be a space between - and [ and ]
eg
https://github.com/FAC-11/week4-3to5/blob/master/README.md#how

Searching for mime gives an error

Returns a 404 error

Create CSS for background images

Make everything look pretty ✨

Complete handler.js

currently only skeleton code

index
query
assets

serve an html page with a search box

import a list of pokemon into data.js

Accessibility: flying bird gif should have a text alternative

One accessibility audit warning:

[Warning] Images should have a text alternative or presentational role (1)
See AX_TEXT_02 for more information.
<img class="ho-oh" src="http://pokestadium.com/sprites/xy/ho-oh.gif">

Mobile issues for iOS and safari

Data lists don't seem to be working on safari and iOS as it is not supported. This breaks main functionality. Worth finding some alternative as it is main task.

Removed es6 from front end

Remove all the es6 from the front end including all consts and any arrow functions

Create file structure for project

Please create file structure

Prepare the Backend Search Function

Prepare backend search function to link through to take int the XGR response and check through the data list. This might be using the new RegEx function built in.

Complete server.js

Currently commented - needs to have code added

Style with pokemon color scheme

[official color scheme here!] (http://www.schemecolor.com/pokemon-colors.php)

Ensure site is accessible for all

Alt text for images
Aria labels
Semantic HTML

testing native js methods instead of the code you've written yourself

Both of your tests in backend.js are essentially testing whether String.prototype.match works.

You want to focus tests on your own code, like the functions in []handler.js(https://github.com/FAC-11/week4-3to5/blob/master/src/handler.js) & search.js

Simplify callback and wrapper functions

Callback and wrapper functions can be simplified. (Wrappers help pass in arguments that's are the same along the callback)

unused css?

Not sure, but i couldnt see where .ashAndDex css is used? if its not used then you could remove it, let me know ! 💃

create envionment variables in server.js

Parse and stringify object

When receiving the XHR from the frond end the url object should be turned into a object by parse so we can use query methods on it.

we will need to require url from core node files
Then once an object can run the .query method

txt file it needs to compare against the string we get so needs to be turned to a string

We can use the toString() method
Then we can use match to compare the string.

Form action

Investigate why there is no form action on our HTML form

Pokemon theme

I believe our site could be immeasurably improved by the addition of the pokemon theme, on loop, whilst on our index.html.

We need to handle errors for the api somehow. So when we enter a. Alive that doesn't exist it can be ignored, no errors will be made and a call to the api/backend is prevented. This will help efficiency

Comments and console logs

Remove commented out sections of code and debugging console.logs from code

console.logs

just a minor thing really couple console.logs you could get rid of

front-end testing using tape

Improve efficiency

Stretch goal to improve efficiency

Create index.html page

The datalist tag is used to provide an "autocomplete" feature on elements. https://developer.mozilla.org/en/docs/Web/HTML/Element/datalist
relates #7

Error handling in router function

would be good practice if all if/else branches in that function fail, like a 404 for example.

Add a few pokemon sprites

Pokestadium.com/tools/sprites

Maybe a flying type that crosses the screen?
We should definitely have a magicarp flopping on the ground!
Pikachu being cute somewhere

RegExp('\b(' + string + ')\w+', 'gi');
This version i think works to find embedded strings according to stack overflow:
RegExp('\b.' + string + '.', 'gi');

Farfetch'd name needs to be changed

Change farfetchd name without the apotstrophe as it is not read that way in the api.

pokemon not in library could add an error for that?

Typing a name that doesn't exist not sure if an error could be added?

fac-11 / week4-3to5 Goto Github PK

week4-3to5's People

Contributors

Stargazers

Watchers

week4-3to5's Issues

Recommend Projects

Recommend Topics

Recommend Org