Comments (9)
Thanks for reporting, I see where the issue is coming from, we'll fix it 👍
In the meantime, you can use this on your navbar item: 'data-noBrokenLinkCheck': true,
from docusaurus.
Going to close this issue as part of #9788
@andrewgbell I'm not able to understand case 2 either, so if there is a problem I don't see, please open another issue with a repro.
from docusaurus.
The 2nd case (trailing slash url being reported) will probably be fixed in #9791
from docusaurus.
Just to add that now we're moving to 3.1 we've noticed a similar thing. We have three different docs sources in our site and linking from one to another throws the warnings (was fine in 3.0.1 and earlier).
from docusaurus.
@andrewgbell is your link having target: "_blank"
too?
Because it wasn't mentioned in the original issue, but it's what matters to me here.
If the link is always opened with such target, then we never navigate through a "soft/SPA navigation" and it's always a full page reload, so it doesn't make sense to check for broken links for such links with targets.
If your link does not have a target, please share another repro so that I understand the case better
from docusaurus.
@andrewgbell is your link having
target: "_blank"
too?Because it wasn't mentioned in the original issue, but it's what matters to me here.
If the link is always opened with such target, then we never navigate through a "soft/SPA navigation" and it's always a full page reload, so it doesn't make sense to check for broken links for such links with targets.
If your link does not have a target, please share another repro so that I understand the case better
No, we don't have that. The repo is private, however I can grant you access if that works for you?
from docusaurus.
@andrewgbell even if the repo is private, what prevents you from creating a smaller repro where I can clearly see which topology of link gets reported?
Giving me access to your repo is fine, but if I need to spend 2 hours figuring out a complex setup and identifying which link exactly we are talking about, I'm less likely to solve the problem.
I'll close this issue links with target are not checked by our broken link checker anymore. If you have another case, that's probably worth opening a different bug report with a repro so that we don't miss that case.
from docusaurus.
This seems to have been resolved now by two things. 1, running the latest canary, 2, then adding a trailing slash after support below in docusaurus.config.js from
to: "/support",
to
to: "/support/",
(it wasn't needed in earlier versions, but maybe we were just lucky):
` footer: {
style: "dark",
links: [
{
title: "Docs",
items: [
{
label: "label1",
to: "/label1/1/",
},
{
label: "label2",
to: "/label2/2/",
},
{
label: "Support",
to: "/support/",
},
],
}
,`
from docusaurus.
This seems to have been resolved now by two things.
Great, but unfortunately I don't even know what the issue is in the first place.
What problem has upgrading to canary resolved?
1, running the latest canary, 2, then adding a trailing slash after support below in docusaurus.config.js from
/support
to/support/
I see where this trailing slash problem might come from.
But that would help to have a runnable repro to be sure we are talking about the same thing. Not seeing things such as your trailingSlash config and md docs creates an ambiguity, and I won't be sure to solve exactly the problem you encounter.
So:
-
- I still don't know what the original issue is about
-
- It's possible that my perf optimizations introduced a regression
These are 2 separate issues that both need to be solved.
Can you please create a smaller repro detailing both?
(I have no idea for case 1, and only have a guess for case 2)
from docusaurus.
Related Issues (20)
- Blog authors pages HOT 5
- Add `showLastUpdateTime` and `showLastUpdateAuthor` to blogs HOT 1
- Add `sortSidebarByLastUpdate` to blogs to change the order in the sidebar HOT 8
- Add `pageBasePath` to blog plugin configuration HOT 3
- Add a trailing slash to feed URLs if `trailingSlash` is enabled HOT 1
- Hide redundant year in dates shown in the Archive page HOT 9
- Enhance support for posts related to events in the past HOT 8
- Error when importing Docusaurus Swizzle component into Netlify CMS HOT 1
- Change code highlight module to Shiki HOT 1
- MDX fails building website when using a <code> inside of a <TabItem> element HOT 3
- 'baseUrl' is ignored in Production routing HOT 5
- Error when importing Docusaurus Swizzle component into Netlify CMS HOT 1
- Allow `tags` in `generated-index` sidebar item HOT 4
- MDX v3.0.1 fails to import <details> HOT 7
- Tabs not working on Docusaurus Static build HOT 5
- Doesn't support protocol-relative URL's HOT 1
- Layout moves around when switching tabs (scroll position issue) HOT 2
- Scripts in head don't load from component on production HOT 2
- The htmlLang setting in the localeConfigs of i18n is invalid, and the source code remains as en HOT 5
- Pages do not support Markdown "file path" links HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docusaurus.