facn2/apolloxi

Search for anything you want in Wiki and Youtube

apolloxi's Issues

Youtube appendChild to replaceChild

Media queries

https://github.com/facn2/ApolloXI/blob/master/public/style.css#L44
Great job on using this 👍

accessibility issues

Below are some Accessibility issues after running chrome plugin to check:

[Severe] ARIA attributes which refer to other elements by ID should refer to elements which exist in the DOM (5)
[Severe] ARIA state and property values must be valid (5)
[Severe] Controls and media elements should have labels (10)
[Severe] Elements with ARIA roles must ensure required owned elements are present (5)
[Warning] Meaningful images should not be used in element backgrounds (15)
[Warning] Text elements should have a reasonable contrast ratio (1)
[Warning] The web page should have a title that describes topic or purpose (2)
[Warning] The web page should have the content's human language indicated in the markup (2)
[Warning] Video elements should use elements to provide captions (5)

no relevant tests

your test is not testing anything to do with your project...

Wikipedia function

Function for Wikipedia api.

Results for Wikipedia only

Youtube occasionally does not load up, regardless of how often I refresh the page

Repo description

there is none, there should be a summary of your project

abstract out the rendering of the wikipedia results

The following could be in a separate function, e.g. showWikiResults
https://github.com/facn2/ApolloXI/blob/master/public/script.js#L12-L20

As you have done with the ShowResponse function for the YT results.

merging pull requests without reviews from the whole group

Every pull request I looked at had not been reviewed by the whole group.
A lot were also merged by the creator without review.

This is not a good way to work

fixing web link in ReadMe

'page not available' message always comes up before load

When the request is loading, the error message appears. You could have a loading message instead?

https://github.com/facn2/ApolloXI/blob/master/public/script.js#L23

place holder for search box

placeholder text('search for someone') doesn't match with what the website is doing.

getElementById instead of query selector

any reason why the form is the only one thats being called using getElementById and not querySelector?
https://github.com/facn2/ApolloXI/blob/master/public/script.js#L3

no user stories

you should have defined some user stories before starting, they should be in your README.

keys.js is in your repo

I don't know if you changed your key, but this shouldn't be in the repo anyway.

README outdated?

To be up to date with new Movies around the world click here.

WHY!

Create a website to showcase the new movies around the world.

This doesn't seem to be what the site does.

package.json file dependencies

Need to create the dependencies in the file to run the tests

wikipedia error message displayed.

e.g. when I searched for 'barack obama'

the wikipedia info displayed was "From a miscapitalisation: This is a redirect from a miscapitalisation. The correct form is given by the target of the redirect..."

not responsive

on small screens the text takes up a lot of space and the videos don't fit on the page

Basic CSS design

Basic design for our application

Finish css and add image

image:
Favicon
logo
css:
add classes and style

create file

make files for html, js ,css ..

extra closing tag

there is an extra closing div tag in index.html

https://github.com/facn2/ApolloXI/blob/master/public/index.html#L39

Classes for CSS

Using classes for CSS instead of IDs is good practice as separates your JS and CSS.

Create file for Tokens

Crete separate file for tokens and add to .gitignore

display of search results for mobiles is aligned to the left

Initial README file

Initial README.md file with basic details about our project.

Repair some spelling mistakes in ReadMe

Repair some spelling mistake in line 11 and 19.

Html layout

Basic layout for our application.

not enough test

as @mattlub mentioned, test inside test.js is not testing any of functions. Also, I would suggest add more tests?

results from youtube only

If you search for something that is available on youtube but not on wikipedia it comes up with "I'm sorry, what you searched for is not available. Please try something else."

This is a bit weird because some results have appeared.

Youtube function

Function for Youtube api