facn2 / apolloxi Goto Github PK
View Code? Open in Web Editor NEWSearch for anything you want in Wiki and Youtube
Search for anything you want in Wiki and Youtube
https://github.com/facn2/ApolloXI/blob/master/public/style.css#L44
Great job on using this ๐
Below are some Accessibility issues after running chrome plugin to check:
[Severe] ARIA attributes which refer to other elements by ID should refer to elements which exist in the DOM (5)
[Severe] ARIA state and property values must be valid (5)
[Severe] Controls and media elements should have labels (10)
[Severe] Elements with ARIA roles must ensure required owned elements are present (5)
[Warning] Meaningful images should not be used in element backgrounds (15)
[Warning] Text elements should have a reasonable contrast ratio (1)
[Warning] The web page should have a title that describes topic or purpose (2)
[Warning] The web page should have the content's human language indicated in the markup (2)
[Warning] Video elements should use elements to provide captions (5)
your test is not testing anything to do with your project...
Function for Wikipedia api.
Youtube occasionally does not load up, regardless of how often I refresh the page
there is none, there should be a summary of your project
The following could be in a separate function, e.g. showWikiResults
https://github.com/facn2/ApolloXI/blob/master/public/script.js#L12-L20
As you have done with the ShowResponse function for the YT results.
Every pull request I looked at had not been reviewed by the whole group.
A lot were also merged by the creator without review.
This is not a good way to work
When the request is loading, the error message appears. You could have a loading message instead?
https://github.com/facn2/ApolloXI/blob/master/public/script.js#L23
placeholder text('search for someone') doesn't match with what the website is doing.
any reason why the form is the only one thats being called using getElementById and not querySelector?
https://github.com/facn2/ApolloXI/blob/master/public/script.js#L3
you should have defined some user stories before starting, they should be in your README.
I don't know if you changed your key, but this shouldn't be in the repo anyway.
To be up to date with new Movies around the world click here.
WHY!
Create a website to showcase the new movies around the world.
This doesn't seem to be what the site does.
Need to create the dependencies in the file to run the tests
e.g. when I searched for 'barack obama'
the wikipedia info displayed was "From a miscapitalisation: This is a redirect from a miscapitalisation. The correct form is given by the target of the redirect..."
on small screens the text takes up a lot of space and the videos don't fit on the page
Basic design for our application
image:
Favicon
logo
css:
add classes and style
make files for html, js ,css ..
there is an extra closing div tag in index.html
https://github.com/facn2/ApolloXI/blob/master/public/index.html#L39
Using classes for CSS instead of IDs is good practice as separates your JS and CSS.
Crete separate file for tokens and add to .gitignore
Initial README.md file with basic details about our project.
Repair some spelling mistake in line 11 and 19.
Basic layout for our application.
as @mattlub mentioned, test inside test.js is not testing any of functions. Also, I would suggest add more tests?
If you search for something that is available on youtube but not on wikipedia it comes up with "I'm sorry, what you searched for is not available. Please try something else."
This is a bit weird because some results have appeared.
Function for Youtube api
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.