[Question] Languages supported

[facundoolano]

[Question] Languages supported

[danieldram]

I'll help with this! I'll take a look at implementing over the weekend. Least I can do, this is a great package @facundoolano thank you for taking the time to produce it :)

[zapolnoch]

Unfortunately, I found that the scraper does not really support other languages when searching. For example:

store.search({
  term: 'привет'
}).then(res => {
  console.log(res.length) // return 0
})

But if we call encodeURIComponent:

store.search({
  term: encodeURIComponent('привет')
}).then(res => {
  console.log(res.length) // return 11
})

[zapolnoch]

I think that you should always use encodeURIComponent for strings that will be passed as part of the URI. This is necessary to encode the string as a valid URI component.
I did console.log(response.headers['x-apple-orig-url']) in this place and received the following results:

https://itunes.apple.com/search?media=software&entity=software&term=%D0%BF%D1%80%D0%B8%D0%B2%D0%B5%D1%82&limit=50&country=RU
this is the correct URL. If you do not use encodeURIComponent, you get such a bad result:
https://itunes.apple.com/search?media=software&entity=software&term=?@825B&limit=50&country=RU

[facundoolano]

All of underlying APIs support other languages, I just never got around adding the options to support them. I'll add it next time I sit down to update this library (PRs are welcome).

[facundoolano]

How does encodeURIComponent affect the search? Would it work to always encode the term?

[facundoolano]

This has been open for a while, and it's rather generic, so I'm closing it now. Feel free to reopen more specific issues (e.g. method X doesn't support other languages)