fako1024/numerics

Method / Tools for numerical methods / statistics

numerics's Issues

Tests fail on Darwin (Binomial() abort condition)

After implementing GitHub actions for Darwin + Windows tests consistently fail on Darwin:

=== RUN   TestBinomial
    numerics_test.go:177: Test driven call to Binomial failed (x=0.800, a=20.000, b=5.000), want 87960930.2220803052186965942, have 87960930.2220803201198577881

--> https://github.com/fako1024/numerics/actions/runs/4594398941

Most likely this is due to an architectural difference in floating point precision and a slightly inconsistent abort condition check in the function (which happens to work on Linux / Windows, but doesn't on Darwin):

// If sufficient precision is reached, return
if math.Abs(hfac-1) < betaEpsilon {
	return h
}

DoD

• Improve abort condition (actually test what's returned, not the value after applying two additional operations)