gwent-vanilla's People
Forkers
adelasoloriogwent-vanilla's Issues
Server Messenger receives null and crashes thread when game ends
In Messenger.kt
, the receive function receives null
and crashes the Clientandler
thread when game ends. This should be caught so the ClientHandler
can shut down gracefully. An exception is probably needed.
Game should auto-pass when a player has no card in hand
Even when a player has an empty hand, the game will still prompt the user for an action. This can be avoided if the game auto-passes for the player. When both player's have no cards in their hand, the game should also end.
Abstract communication with server in client
For the client to send a message to the server, we currently write
self.writer.writelines([msg_json, '\n'])
self.writer.flush()
This is ugly, and it is easy to forget the flush. Hence, this should be abstracted away, similarly to the server's Messenger class.
Power is not correctly reset between rounds
The PlayerBoard::currentPower
and Row::currentPower
is not correctly set to 0 when a round ends.
Make client check of game over and notify user
When a game completes, the client will still ask for the next move. Entering an action results in Invalid action: The game has ended.
. Instead, the client should read the game over flag in the game state and notify the user.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.