falnyr/aws-sam-deploy-action

Deploys AWS SAM templates using Github Actions

👋 Hello

aws-sam-deploy-action's Issues

Fails on Alpine latest

Hi,

With the latest version of Alpine (3.16) the action now fails. It does however run by setting the Alpine version 3.15.6.

ImportError: cannot import name 'docevents' from 'botocore.docs.bcdoc'

Hi,

Today I started getting this error on actions execution

Run falnyr/[email protected]
/usr/bin/docker run --name --label --workdir /github/workspace --rm -e TEMPLATE -e AWS_STACK_NAME -e AWS_REGION -e AWS_ACCESS_KEY_ID -e AWS_SECRET_ACCESS_KEY -e AWS_DEPLOY_BUCKET -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e GITHUB_PATH -e GITHUB_ENV -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/xxxx-xxx/xxxx-xxxx":"/github/workspace" 
Traceback (most recent call last):
  File "/usr/bin/aws", line 19, in <module>
    import awscli.clidriver
  File "/usr/lib/python3.8/site-packages/awscli/clidriver.py", line 36, in <module>
    from awscli.help import ProviderHelpCommand
  File "/usr/lib/python3.8/site-packages/awscli/help.py", line 23, in <module>
    from botocore.docs.bcdoc import docevents
ImportError: cannot import name 'docevents' from 'botocore.docs.bcdoc' (/usr/lib/python3.8/site-packages/botocore/docs/bcdoc/__init__.py)

Reading I found the solution is upgrading aws-cli

Upgrading awscli to >=1.18.140 should fix this: [aws/aws-cli#5538](https://github.com/aws/aws-cli/pull/5538)

In your Dockerfile when install aws-cli is a older version. I'm not sure how install the latest version of aws-cli on Alpine.

Thank you

Templates with a size greater than 51,200 bytes must be deployed via an S3 Bucket.

Hi Jan,

After made some additions to template.yml I got this message after try to deploy

Templates with a size greater than 51,200 bytes must be deployed via an S3 Bucket. Please add the --s3-bucket parameter to your command. The local template will be copied to that S3 bucket and then deployed.

My implementation

      - name: Deploy SAM template
        uses: falnyr/[email protected]
        env:
          TEMPLATE: 'template.yaml'
          PARAMETER_OVERRIDES: DbUri=${{ secrets.DEV_DB_URI }} 
          NO_FAIL_EMPTY_CHANGESET: true
          AWS_STACK_NAME: dev-callaction-core
          AWS_REGION: ${{ secrets.AWS_REGION }}
          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
          AWS_DEPLOY_BUCKET: MyS3Bucket

is already implemented AWS_DEPLOY_BUCKET: MyS3Bucket.

Reading SAM documentation I found the definition of the param --s3-bucket

https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-cli-command-reference-sam-deploy.html

--s3-bucket: The URI of the Amazon S3 bucket where this command uploads your AWS CloudFormation template. This is required to deploy templates that are larger than 51,200 bytes.

Maybe AWS_DEPLOY_BUCKET is not referencing the option --s3-bucket on SAM Deploy command?

Thank you in advance
Martin