famous/lesson-carousel-starter-kit

#THIS REPO IS DEPRECATED ##Mixed Mode can be found at https://github.com/famous/engine

If you are looking for the old website with the support material for this version of famous please visit http://deprecated.famous.org

This repo will be moved to a deprecated organization in the coming months.

If you have any questions or concerns pelase join us in the famous community slack

signup --> http://slack.famous.org/signup

lesson-carousel-starter-kit's Issues

Carousel Tutorial (Unexpected end of input / bundle.js error)

Hi,

I have forked the Carousel Tutorial following the steps from the website. Everything worked like a charm. But what I have realised is that sometimes when I start editing the files to understand how it works I get the following error in the console:

Uncaught SyntaxError: Unexpected end of input ----------------------- bundle.js:1

As soon as I refresh the browser everything starts working again. I do not get it all the time just randomly.
Any idea why this could happen?

Thanks!

change name of step2-AddingChildNotes to AddingChildNodes

data json is invalid

quotes need to be double

data.json is a bad name

the name for this json file should reflect the payload.

images is a pretty good one.

also require('./data/data'); looks super odd

Error in Example for Pager.js when adding animations

A call is made in Pager.js to

Famous.requestUpdateOnNextTick(this)

should be

FamousEngine.requestUpdateOnNextTick(this)

This error is fixed by the next step

Dots.js: onSizeChange returns single value, not array

all steps after 5 throw this error: Uncaught TypeError: Cannot read property '0' of undefined.

this is because the (Dots.js line 31) onSizeChange function's size argument has a single value (for the x axis) instead of an array. the size variable is then used as an array on line 46.

bug can be fixed by changing line 46 to use "this.size" instead of "this.size[0]"

No camera

Carousel should have a camera on the root node to give the swivel depth.

"Uncaught error" in Step 4 - node does not have access to a size component

I am unable to render the arrow components as written in Step 4 (I copied and pasted the code from the lesson exactly to make sure it wasn't a typing error on my part). Nothing renders in the browser, and the console shows the following error and stack trace:

Node.js:537 Uncaught Error: This node does not have access to a size component
getSizeMode @ Node.js:537
DOMElement @ DOMElement.js:79
Arrow @ Arrow.js:7
Carousel @ Carousel.js:16
56../carousel/Carousel @ index.js:10
s @ _prelude.js:1
e @ _prelude.js:1
(anonymous function) @ _prelude.js:1

I did move on to steps 5 and 6 and noticed that the Pager and Dots components will render, if I comment out all references to Arrows.

Being new to this community in general I apologize for not having any idea on how to resolve this, but please let me know if there's any other info I can provide to assist in troubleshooting etc. Any assistance in completing the Arrow phase of this tutorial would be very much welcomed and appreciated! :)