fantasycalendar/foundryvtt-itempiles

foundryvtt-itempiles's Issues

Module Fails to install from Manifest link

https://github.com/Haxxer/FoundryVTT-ItemPiles/blob/10207a7a9a226d17e265263e31f2904c2892e065/module.json#L41

It doesn't seem to have been auto-replaced :'(

addItems function has several errors, and API description of turnTokensIntoItemPiles not clear.

Instead of bothering you on Discord, posting my findings here in the correct channel/workflow ;)

1. I think some search & replace has gone awry in the addItems function:

static async addItems(target, items, { interactionId = false } = {}) {

        const hookResult = Hooks.call(HOOKS.ITEM.PRE_ADD, target, items, interactionId);
        if (hookResult === false) return;

        const targetUuid = lib.is_UUID(target) ? target : lib.getUuid(target);
        if (!targetUuid) throw lib.custom_error(`AddItems | Could not determine the UUID, please provide a valid target`, true)

        items = items.map(itemData => {
            let item;
            if(itemData.item instanceof Item){  //should be: itemData instanceof Item
                item = itemData.item.toObject(); // should be: itemData.toObject();
            }else{
                item = itemData.item;  //should be: itemData;
            }
            return {
                item: item,
                quantity: itemData?.quantity ?? getProperty(foundActorItem.data, API.ITEM_QUANTITY_ATTRIBUTE) //should be item.data
            }
        });

        if (interactionId && typeof interactionId !== "string") {
            throw lib.custom_error(`AddItems | interactionId must be of type string or false`);
        }

        return itemPileSocket.executeAsGM(SOCKET_HANDLERS.ADD_ITEMS, targetUuid, items, game.user.id, { interactionId });
    }

2. maybe it is me being stupid, but:
   the API says turnTokensIntoItemPiles(tokenDocument, pileSettings, tokenSettings) where pileSettings and tokenSettings are objects. However the function is: static async turnTokensIntoItemPiles(targets, { pileSettings = {}, tokenSettings = {} } = {}) which means that you have two params, not three, of which the second param is an object made of two objects, ie, pileSettings and tokenSettings. Does that make sense why it is confusing in the documentation?

[REQUEST] - Party storage enhancement

Is your feature request related to a problem? Please describe.
An unexpected benefit of Item Piles is that it could work really well as a Party Storage system. The current solution works pretty well, especially from a player perspective, but there are several things that could be done to improve it, should you want to.

Describe the solution you'd like
Improve the Item Piles storage on actors, especially handling larger inventories. One solution could be to add a third option to "Single Item" and "Container", let's call it "Storage".

All of these suggestions imply that it is a linked actor in the actor list. It works pretty well already, these are just potential improvements.

Here are some suggestions that could improve the experience:

• Ability to drag and drop items from one Item Pile to another
• Showing items in categories, also maybe a bit of a smaller interface
• Show it similar to how a "store" or "merchant" would work, but with the option to just "take" instead of buying. Maybe this could work well as a store too.

Nice to have:

• Ability to sort and or filter
• Easy way to trade from the party storage
• "Send to player" button for GM
• Showing an image/description of the storage, and the option to show or hide it.

Describe alternatives you've considered
There are other options, such as Party Storage module, and using regular actor sheets. None work super well.

Additional context
Small UI suggestion: make the box edit number of items smaller.

[REQUEST] - Use NPC sheet / compatibility with Loot Sheet NPC 5E

Is your feature request related to a problem? Please describe.
Item Piles is cool, but the interface is not optimized for its functionality. Loot Sheet NPC 5E has a cleaner interface for looting items. I tried deleting the Default Item Pile and manually creating one with an NPC sheet, but Item Piles just recreates a second Default when you do this

Describe the solution you'd like
I'd like to be able to configure Item Piles to use an NPC sheet. Specifically https://github.com/jopeek/fvtt-loot-sheet-npc-5e , though I imagine there's a way to make it work with whatever NPC sheet you have selected on the default item pile

Describe alternatives you've considered
I could create a "Item Pile" using a Loot Sheet Npc, but that's far less convenient than drag-and-drop

Additional context
Here's what the Loot Sheet looks like:

[REQUEST] - Assets Pack

There is a free chests pack. Would be cool have at list some set as defaut.

I already converted them to webp and reduced the size for foundry vtt use. But, this could make smaller.
out.zip

SOURCE AND LICENSE

https://foozlecc.itch.io/free-chest-and-key-pack

You are granted a non-exclusive perpetual license to:
1.1 Use any resources found in this download in any number of commercial or personal projects for yourself or clients perpetually except where forbidden as detailed below.
1.2 Create derivatives / modify any resources in this download and include them into your projects commercially or non-commercially such as games, websites, illustrations etc. except where forbidden as detailed below.
1.3 Sell and distribute games with these assets. No attribution or link back is required, however any reference will be highly appreciated.

FORBIDDEN

2.1 You can NOT resell the art source files (PNG, JPG, EPS, Adobe Illustrator, etc) or slightly modified versions of the art.
2.2 You can NOT use these assets or derivatives for Print On Demand / Merchandise (T-Shirts, Stickers, etc.).
You can not redistribute the art or modified version where it enables access to other end users.
Showing the art / asset in the game is acceptable, but an application which allows the end user to export or access the artwork is not acceptable.

Suggestion: Work with P4535992

It looks like you and @p4535992 are both working on the same thing here, perhaps a team up is in order?

https://github.com/p4535992/foundryvtt-item-placeable

[BUG] - Cannot open two Item Piles from actor list

Describe the bug
If you open an item pile from the actor list, then try to open another, the second one does not open. It throws an error in the console:

item-pile-inventory.js:60 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'uuid')
[Detected 1 package: item-piles]
    at item-pile-inventory.js:60:68
    at Array.filter (<anonymous>)
    at Function.getActiveAppFromPile (item-pile-inventory.js:58:52)
    at Function.show (item-pile-inventory.js:87:37)

I am not sure if this is intended or not. But it is throwing an error so I assume it's not intended. :)

To Reproduce
Steps to reproduce the behavior:

1. Click Item Pile in actor list
2. Click another Item Pile in actor list
3. (Second sheet does not show)
4. See error

Expected behavior
Two sheets should open, or no error should show. Having to sheet's is preferable, this way you can transfer items between piles. (party storage chests for example)

Setup:

• Foundry Version: 9.249
• Item Piles Version: 1.4.0
• OS: Windows 10
• Browser: Chrome

Active modules:

• Item Piles
• libwrapper
• socketlib

[REQUEST] - Splitting currencies and item quantities between players

This is very cool and dose some unique things. I like the implementation better then pick up sticks... love the easy ability to make a pile of alluring looking treasure and then have players interreact with it, right after they rushed into the trap of course.
There are some related modules that have some different/better function that it would be nice to see rolled together or compatible.
Loot sheet allows permissions for a master looter, so no loot goblins please, especially if you have younger players :p... It also seems to handily money more easily and allows for to be easily split between all players. Also works with freds pocket change to easily genreate some cash...
For 5E we are of course still missing any kind of real loot generator so we can easily populate a box or corps based on the CR random encounter rules and have a fairly frictionless experience.

[REQUEST] - allow players to swap between their owned tokens to interact with the pile

Is your feature request related to a problem? Please describe.
For my players, I created an extra actor named "group loot" that they all have access to. Any loot that isn't claimed by an individual player goes into the "group loot" actor. When they're done with their current escapades they sell it all off. The interface for Item Piles is awesome. It's a much better interface for looting than the default experience in PF1. But what's tedious would be to have to claim everything into the player inventory, then manually transfer that into a different inventory.

Describe the solution you'd like
Once I've interacted with an Item Pile, I'd like to be able to swap actors that I'm inspecting as. So if I'm a player that owns multiple tokens, after I've already opened the container, I'd like to be able to swap the actor I'm inspecting it with

(edited the html to show an example, probably should add a label to the select)
I know there's an interaction distance imposed on the loot--I propose that this dropdown bypass that. This could potentially allow the player to cheat if they have more than one real actor by letting them loot the pile with a different actor that's actively playing. My reasoning is that the player already moved a token over to the loot. At this point the player has access to it. If the player wanted to cheat, then they can simply transfer items after being looted into the first character (heck, the player could add whatever items they wanted to themselves without Item Pile if they wanted to cheat). So basically the player has already overcome "the obstacle" by getting to the Pile. At this point they should be able to put the loot wherever they want and not have to play "Inventory Management Simulator" by juggling loot between characters.

[REQUEST] - Drop currency into pile

Is your feature request related to a problem? Please describe.
We can drop items into a pile but not currency.

Describe the solution you'd like
Next to the "take" button we could have a "put" button that would open a window to put more currency into the pile.

Describe alternatives you've considered
Or when we drop an item named "Currency" it could ask the player how much currency they want to drop instead of actually transferring the currency item.

[SYSTEM] - Tormenta 20

[INSERT FOUNDRY PAGE LINK TO SYSTEM HERE]
https://gitlab.com/vizael/Tormenta20

Actor Class Type: "character"

Item Quantity Attribute: "data.qtd"

Item Type Attribute: "type"

Item Type Filters:

Dynamic Attributes:

• Name: Ouro
  • Path: data.dinheiro.to
  • Image: icons/commodities/currency/coin-embossed-insect-gold.webp
• Name: Prata
  • Path: data.dinheiro.tp
  • Image: icons/commodities/currency/coin-embossed-unicorn-silver.webp
• Name:Cobre
  • Path: data.dinheiro.tc
  • Image: icons/commodities/currency/coin-engraved-waves-copper.webp

[BUG] - Initial Item Pile permissions

Describe the bug
Items or item piles cannot be opened by players until the GM has "inspected" the pile first via CTRL+Double Click.

To Reproduce
Steps to reproduce the behavior:

1. GM or Player Client drops an item onto the canvas (from the sidebar or inventory)
   • Note: There appears to be some sort of history maintained, so be sure that this item is brand new and has not been dropped onto the canvas before.
2. Player Client - move next to item pile and double click. Nothing will happen.
3. GM Client - Double Click to open the item pile's actor sheet and close.
4. Player Client - repeat step 2, but now the item pile dialog will show and everything works as expected.

Expected behavior
Item Pile should be immediately openable by Players upon item drop.

Screenshots

itempile-permissions.mp4

Desktop (please complete the following information):

• OS: Windows 11
• Browser Edge
• Version 96.0.1054.62 (Official build) (64-bit)

Quantities not working?

Creating a new item pile with a random item (IE: 1 torch) and then trying to change the inventory quantity or drag a second torch onto the pile does not increase the quantity, it always remains at 1.

I confirmed this with all other modules de-activated, no errors in console.

[Request] Output to Chat

Is your feature request related to a problem? Please describe.
When many players are looting multiple chests, it is hard to keep track of what has and hasn't been picked up yet as a DM.

Describe the solution you'd like
Have a small chat message generated whenever a player loots something from an item pile.
Something like '[PC] has looked [item] from [itempile]'

Describe alternatives you've considered
Asking the players to declare on voice when they've looted an item from the pile.

[SYSTEM] - Pathfinder 2e

Pathfinder 2e

Actor Class Type: "loot"

Item Quantity Attribute: "data.quantity.value" (number)

Item Type Attribute: "type"

Item Type Filters: "action,spell,melee,lore,heritage,feat,effect,class,background,ancestry"

Dynamic Attributes: None, everything is a type of entry, like Currencies being items.

Temporary Item Attribute: "data.temporary.value" (boolean)

[BUG] - Can not set default item pile setting on DS4

When I try to change the Item Pile settings on the Default Item Pile Actor from which piles are duplicated as template you get a error in the javascript console and the pile settings are not updated. Since the pile seem to should be system agnostic I consider this as a bug. This happens in the DS4 / Dungeonslayers 4 system.

To Reproduce
Steps to reproduce the behavior:

1. Install Game system Dungeonslayers 4

2. Install Item Pile Module ;)

3. Start game world with DS4 system

4. Enable only Item Pile module on new world (and depended, for sure)

5. Create Actor

6. Drop Item from Compendium "Gegenstände (GRW)" to new actor

7. Drop Item from actor from page "Inventar" to the ground, create pile
   or

8. create Item

9. drop Item to ground, create pile, you get the default pile

10. try to change settings of default pile

11. when pushing update pile button values are not stored, error message on javascript console

Expected behavior
Settings of a pile should be change/updateble when module is system agnostic independent from game system

Javascript console error
lib.js:148
Uncaught (in promise) TypeError: Cannot read properties of null (reading 'update')
[Detected 1 package: item-piles]
at Module.updateItemPile (lib.js:148)
at Function._updateItemPile (api.js:1381)
updateItemPile @ lib.js:148
_updateItemPile @ api.js:1381
await in _updateItemPile (asynchron)
_updateObject @ itemPileConfig.js:149
_onSubmit @ foundry.js:3822

Desktop (please complete the following information):

• OS: Windows
• Browser Microsoft Edge
• Version current stable channel release

[BUG] - Saving settings for an item pile (icons for closed/open etc) doesn't transfer to a new pile?

Describe the bug
I have an item pile in the sidebar called "chest item", where I set the closed-item, open-item, empty-item etc images for it, with the intention that I could then drop that onto the map, and it would show as a chest, and I can then fill the chest with loot.

Except it doesn't seem to work like that. Even though the sidebar item has all the settings in place, when I drag it onto the map it turns into a totally default pile.

Is there no way to pre-set everything? Cos having to manually set up multiple images for each loot pile is a bit of a pain.

This feels like a bug, because I can set the settings in the sidebar, and normally these things will copy over to the actor you place on the map.

To Reproduce
Above

Expected behavior
Above

Setup:
Current versions of everything.

Active modules:

• Item Piles
• libwrapper
• socketlib
• +84 other ones

Set "Display Single Item Image" as true by default

I think this token setting should be true by default - if I drag a sword from my inventory into the ground, I expect to see a sword icon and not a blank item icon.

[SYSTEM] - Splittermond

Splittermond

Actor Class Type:

npc

Item Quantity Attribute:

data.quantity

Item Filters:

• type: spell, mastery, weakness, npcfeature, strength, species, culture, ancestry, education, resource, moonsign, language, culturelore, statuseffect, spelleffect
• name: Körper
• name: Waffenlos

Item Similarities:

• name
• type
• sufferedDamage
• quality

Currencies:

• Name: Solare
  • Path: data.currency.S
  • Image: icons/commodities/currency/coins-assorted-mix-copper.webp
• Name: Lunare
  • Path: data.currency.L
  • Image: icons/commodities/currency/coins-assorted-mix-silver.webp
• Name: Telare
  • Path: data.currency.T
  • Image: icons/commodities/currency/coins-assorted-mix-platinum.webp

[BUG] - [!! Midi-QOL Drag and Drop Targeting bug !!]

Describe the bug
When using Item Piles and Drag and Drop Targeting I get a request to make an item pile whenever I drag the attack onto the creature. It's not game breaking, but it is annoying to have to dismiss the pop up box every time.

To Reproduce
Steps to reproduce the behavior:

1. Enable Midi-QoL and the Drag and Drop Targeting option
2. Go to 'A sheet with a weapon'
3. Drag the weapon, or the weapon's attack action, and drop on another token
4. See the pop up to make an item pile

Expected behavior
No pop up to make an item pile from a sheet to a token

Screenshots
https://user-images.githubusercontent.com/72875320/148793382-62de3e48-883d-4ffe-bf04-e771b9e3af56.mp4

Setup:

• Foundry Version: 9.242
• Item Piles Version: 1.1.2
• OS: Windows 10
• Browser: Chrome
• Version: 96.0.4664.110

Active modules:

• Item Piles
• libwrapper
• socketlib
• Midi-QoL
• Module Sets - Dual Track GMing, baby

[REQUEST] - Hide Text from Item Pile icon

Is your feature request related to a problem? Please describe.
The top bar of actor sheets can get pretty cluttered with icons and text.

Describe the solution you'd like
An optional setting to hide the text from the top bar of actor sheets and instead adding a text on mouse over.

Describe alternatives you've considered
The only alternative I can think of would getting rid of the button completely and hiding the item pile options somewhere else, like the context menu when right clicking on an actor in the sidebar.

Additional context

This is Savage Worlds with only CUB, PopOut! and Item Piles adding buttons there and it's still covering the actors name due to core and system buttons.

Ability to split a portion of the currency with players.

Would love to be able to split a certain amount with actors. If there is 765 gp, maybe they each get 50 and the rest stays for the group resources later.
There is no way to only split a designated amount at this time. It's all or nothing.

An input interface would work. The ability to type in how much you want to split with the actors. Or all.

[Compatibility] Token Replacer and Item Piles don't work together

Hi. Great module!

Item Piles don't work with Token Replacer. They generate an error together.

I don't know which module should patch it. But, I'm reporting.

Thank you.
Screenshots

Setup:

• Foundry Version: 9.242
• Item Piles Version: 1.1.3
• OS: win10
• Browser chrome

Active modules:

• Item Piles
• libwrapper
• socketlib
  Token Replacer

issue on token replacer: vtt-lair/token-replacer#86

[REQUEST] - Item "name" filter

Is your feature request related to a problem? Please describe.
When looting monsters or animals, they often won't have weapons, but "claws", "bite" and other natural weapons.

Describe the solution you'd like
Have a filter similar to the item type, but for names, to prevent players from looting natural weapons.

Describe alternatives you've considered
Asking the system author to add a new type of item types. This seems a bit overkill and would be needed to done by every system out there. It's unlikely the maintainers want to add another item type just for this ItemPiles.

PF2e system incompatibility

With the Pathfinder 2e system, I'm seeing the following issues:

1. A created item pile throws an error when double-clicked instead of opening a sheet. The code fails with: TypeError: Cannot create property 'value' on string '0[object Object]'
2. The created actor for the token should be of type loot instead of character
3. Currency attribute - doesn't exist (coins are items on the sheet, of the same kinds as 5e minus electrum)
4. Item type filters - the dnd5e defaults are spell,feat,class but in pf2e you could set them as action,ancestry,background,class,condition,deity,effect,feat,lore,melee,spell,spellcastingEntry

[BUG] - Can't add currency as GM

Describe the bug
You can't add currency from the GM-window when trading with a player.

foundry.js:316 TypeError: currencies.filter is not a function
[Detected 1 package: item-piles]
    at Module.getActorCurrencies (modules/item-piles/scripts/lib/lib.js:377:10)
    at DropCurrencyDialog.getData (modules/item-piles/scripts/formapplications/drop-currency-dialog.js:64:31)
    at DropCurrencyDialog._render (foundry.js:3062:29)
    at DropCurrencyDialog._render (foundry.js:3764:17)
    at DropCurrencyDialog.render (foundry.js:3021:10)
    at modules/item-piles/scripts/formapplications/drop-currency-dialog.js:48:57
    at new Promise (<anonymous>)
    at Function.query (modules/item-piles/scripts/formapplications/drop-currency-dialog.js:47:16)
    at TradingApp.addCurrency (modules/item-piles/scripts/formapplications/trading-app.js:181:56)
    at HTMLAnchorElement.<anonymous> (modules/item-piles/scripts/formapplications/trading-app.js:363:18)
    at HTMLAnchorElement.dispatch (jquery.min.js:2:43064)
    at HTMLAnchorElement.v.handle (jquery.min.js:2:41048)

I am not sure if this is intended or not. But it is throwing an error so I assume it's not intended. :)

To Reproduce
Steps to reproduce the behavior:

1. As a GM, open trade with player, with a token as actor
2. Let player accept
3. Click "+Add Currency (GM Mode)"
4. See error

Expected behavior
You should be able to add currency in the trade.

Setup:

• Foundry Version: 9.249
• Item Piles Version: 1.4.0
• OS: Windows 10
• Browser: Chrome

Active modules:

• Item Piles
• libwrapper
• socketlib

[REQUEST] - Make splitting currencies optional by player choice

Is your feature request related to a problem? Please describe.
Sometimes my players don't want to share the money. But then they still can only take their own share or I have to disable the sharing feature altogether for the chest.

Describe the solution you'd like
When configuring a item pile have the options to "Enable Sharing of currencies" (old) and depending on it the two options "Force sharing" (new) and "Enable split with players button" (old). "Force sharing" would function as it is now with sharing enabled. You can only take your fair share. With "Force sharing" disabled, you'd have the option to take more, than your normal share were or even everything. With inactive "Force Sharing" it would not track the fair share und the button "split with players" would just share everything that is still inside the chest evenly. This way it was more of a quality of life feature, while still giving characters the possibilty to cheat each other.

Describe alternatives you've considered

• Not allowing my players to have their characters take more than they agreed to.
• Not sharing at all and have them calculate the money each time.
• Changing the settings each time someone want to take more than the others or even just edit the amounts by hand.

Additional context

• I think this might also help with: #49, but I didn't want to highjack that issue with my idea.

[REQUEST] - Image/Sound Default

Hi. Amazing job!

Can you add presets to chest image and sounds? So, you can just choose a preset defined in the module settings an apply it to the pile.

tks

[REQUEST] consider supporting the foundryvtt-world-currency-5e module

Is your feature request related to a problem? Please describe.
foundryvtt-world-currency-5e is used to change the currency name and trade values for the 5e system. Very useful when you don't play with the classic Forgotten Realms setting and money has different names in the setting you are playing with.

Describe the solution you'd like
Make this module compatible with foundryvtt-world-currency-5e. This module doesn't actually override the currency i18n keys but rather modify the CONFIG.DND5E.currencies object: https://github.com/cstby/foundryvtt-world-currency-5e/blob/master/scripts/world-currency-5e.js#L26

[REQUEST] Consider hiding the item piles button in the sheet header

Is your feature request related to a problem? Please describe.
The new sharing feature is very cool.
But that is the only feature I want to use, and my sheet headers are really bloated.

Describe the solution you'd like
Is it possible to deactivate completely the item piles feature and not have the button displayed in the sheet headers?

[SYSTEM] - SWADE

https://gitlab.com/peginc/swade

Actor Class Type: "character"

The actor class type is the type of actor that will be used for the default item pile actor that is created on first item drop.

Item Quantity Attribute: "data.quantity"

The item quantity attribute is the path to the attribute on items that denote how many of that item that exists.

Item Type Attribute: "type"

Item Type Filters: "edge,hindrance,skill,power,ability"

Item types and the filters actively remove items from the item pile inventory UI that users cannot loot, such as spells, feats, and classes.

Dynamic Attributes:

Dynamic attributes are things like currencies or transferable powers that exist as editable number fields on character sheets.

• Name: "Currency"
  • Path: "data.details.currency"
  • Image: "icons/svg/coins.svg"

[BUG] - openItemPileInventory does not work on actors with unlimited interaction range

Describe the bug
The ItemPiles.API.openItemPileInventory() does not work on actors the same way as clicking on them in the sidebar

To Reproduce
Steps to reproduce the behavior:

1. Run ItemPiles.API.openItemPileInventory() on an actor as a player that has limited permissions on the actor
2. Observe error

Expected behavior
If the user can open the item pile from the side bar, this function should work the same

[REQUEST] - Selectable Actor Type

I really like the idea behind the Item Pile module, but in the SWADE at least, it's quite cumbersome to use, as every item pile is a Player Character actor and uses the PC sheet. The items are then hidden behind the "Gear" tab and it's not really clear to players that they can drag the items out. If the actor type could be definable, I could select "NPC" and use a much more readable sheet (either the default NPC sheet of SWADE or the Merchant sheet from the module of the same name for example).

I haven't found another way to make an item pile use the NPC actor, unless I create the item pile as an actor to begin with. But then I lose the drag & drop functionality of the module, as it will always create the Default Item Pile player character actor and uses that one instead.

[SYSTEM] - DnD 3.5 SRD

https://foundryvtt.com/packages/D35E

Actor Class Type: "npc"

Item Quantity Attribute: "data.quantity"

Item Type Attribute: "type"

Item Type Filters: "spell,feat,class,race,attack,full-attack,buff,aura,alignment,enhancement,damage-type,material"

Dynamic Attributes:

• Name: "Platinum Coins",
  • Path: "data.currency.pp",
  • Image: "icons/commodities/currency/coin-inset-snail-silver.webp"
• Name: "Gold Coins",
  • Path: "data.currency.gp",
  • Image: "icons/commodities/currency/coin-embossed-crown-gold.webp"
• Name: "Silver Coins",
  • Path: "data.currency.sp",
  • Image: "icons/commodities/currency/coin-engraved-moon-silver.webp"
• Name: "Copper Coins",
  • Path: "data.currency.cp",
  • Image: "icons/commodities/currency/coin-engraved-waves-copper.webp"

[REQUEST] - Reset all currencies on new item piles

Is your feature request related to a problem? Please describe.
For the SWADE System: When NPCs are created, they have 500 currency, which can flood the players with lots of currency that isn't supposed to be there.

Describe the solution you'd like
Have an option for the GM to remove the game system currency from the piles without having to create an actor to do it. When NPCs are created, they have 500 currency, which can flood the players with lots of currency that isn't supposed to be there.

Describe alternatives you've considered
Allowing the GM to remove currency/items without using the character sheet. (Currency does not show up on SWADE NPC sheets).

Additional context
Add any other context or screenshots about the feature request here.

[SYSTEM] - Old-School Essentials

https://foundryvtt.com/packages/ose

Actor Class Type: "Character"

Item Quantity Attribute: "data.items.quantity"

Item Type Attribute: "data.items "

Item Type Filters: "ability, spell"

Dynamic Attributes: N/A

Miscellaneous Item (Such as gold)

  "type": "item",
  "img": "systems/ose/assets/default/item.png",

Container Item (Such as a backpack holding items)

  "type": "container",
  "img": "systems/ose/assets/default/bag.png",

Armor Item

  "type": "armor",
  "img": "systems/ose/assets/default/armor.png",

Weapon Item

  "type": "weapon",
  "img": "systems/ose/assets/default/weapon.png",

[SYSTEM] - PF1

PF1

Untested I just inspected an actor through the console to make sure and this should be everything you need.

export default {
  "ACTOR_CLASS_TYPE": "npc",
  "ITEM_QUANTITY_ATTRIBUTE": "data.quantity",
  "ITEM_TYPE_ATTRIBUTE": "type",
  "ITEM_TYPE_FILTERS": "attack,buff,class,feat,race,spell",
  "DYNAMIC_ATTRIBUTES": [
      {
          name: "Platinum Coins",
          path: "data.currency.pp",
          img: "systems/pf1/icons/items/inventory/coins-silver.jpg"
      },
      {
          name: "Gold Coins",
          path: "data.currency.gp",
          img: "systems/pf1/icons/items/inventory/coin-gold.jpg"
      },
      {
          name: "Silver Coins",
          path: "data.currency.sp",
          img: "systems/pf1/icons/items/inventory/coin-silver.jpg"
      },
      {
          name: "Copper Coins",
          path: "data.currency.cp",
          img: "systems/pf1/icons/items/inventory/coin-copper.jpg"
      }
  ]
}

[BUG] - Item Piles doesn't seem to work with DFreds Droppables

Describe the bug
ItemPiles doesn't seem to work with DFreds-Droppables

To Reproduce
Steps to reproduce the behavior:

1. Create a DnD5e world, and activate both Item Piles and DFreds Droppanles, Drefs will require libWrapper
2. Open the item compendium and drag an item to the canvas
3. Nothing will happend, a popup error will be shown
4. In console, you'll see an arror like this one

Expected behavior
No issues?

Screenshots
https://i.imgur.com/y834YE1.png

Desktop (please complete the following information):

• OS: Windows 10
• Browser: Edge (chromium)
• Version 96.0.1054.62 64 bits

[REQUEST] - Turn all selected tokens into item piles button

Is your feature request related to a problem? Please describe.
You have to select each actor separately to enable the Item Pile features.

Describe the solution you'd like
The option to enable Item Piles on all actors with one click. Note: Not to turn them into containers, just enable the pile feature.

Describe alternatives you've considered
Possibly be able to select multiple actors to enable it on.

Additional context
Add any other context or screenshots about the feature request here.

[BUG] - Item Pile Container Settings do not persist when dragging from actor list

Describe the bug
I get the actor image rather than the expected image of a closed chest

To Reproduce
Steps to reproduce the behavior:

1. Right click on the Default Item Pile and duplicate it
2. Customize the new Item Pile (disable "Display Single Image" and put images/sounds on the Container Settings tab and click update)
3. Drag the new type of Item Pile onto a scene
4. Result: I see the Item Pile's image, not the closed chest imag
5. If I open the Item Pile from the scene, go to Container Settings, and click Update, then it behaves as expected

Expected behavior
4 should not happen and 5 should be automatic

Setup:

• Foundry Version: 0.8.9
• Item Piles Version: 1.2.5
• OS: Windows
• Browser chrome
• Version [version of what?)

Active modules:

• Item Piles
  Active Modules:

---

About Time v1.0.6;
Ace library v1.3.0;
Active-Auras v0.3.08;
Active Token Effects v0.3.04;
Actor Attribute Lists v0.0.5;
Advanced Macros v1.12;
Adventure Log v0.2.3;
Adventure Music v1.1.0;
Autocomplete Whisper v0.3.4;
Automated Animations v1.2.6;
Award XP v1.3.2;
Break Time v1.0.11;
Chat Images v2.5.6;
Combat Carousel v0.2.3;
Combat Enhancements v1.0.2;
Compendium Folders v2.3.64;
Control concealer v1.2.0;
Cycle Token Stack v0.5.4;
D&D Beyond Importer v2.8.8;
DDB D&D 5E (Shared Compendiums) v1.0;
Deprecated Modules v1.1.6;
DF Architect v3.1.1;
DF Chat Enhancements v3.5.1;
DF Curvy Walls v3.2.4;
DF Flags Editor v1.1.2;
DF Quality of Life v1.6.1;
DFreds Convenient Effects v2.0.1;
DFreds Droppables v1.4.0;
DFreds Pocket Change v3.2.1;
DF Settings Clarity v3.2.1;
Dice So Nice! v4.3.1;
Dice Tray v1.4.1;
DnD5e Helpers v3.0.4;
Drag Ruler v1.9.1;
Dungeon Draw v0.19.1;
Dynamic Active Effects SRD v6.0.01;
Dynamic effects using Active Effects v0.8.79;
Find the culprit v1.4.0;
FVTT Encounter Stats v0.20.3;
FXMaster v2.2.2;
Health Estimate v2.6.13;
Hey, Wait! v0.6.3;
Initiative Double Click v1.2;
Item Macro v1.5.6;
Item Piles v1.2.5;
JB2A - Jules and Ben's Animated Assets - Free Content v0.3.4;
Keybind Lib v0.3.4;
Let's Trade 5e v0.3.0;
lib - Color Settings v2.8.2;
Library: Chat Commands v1.4.0;
Library: DF Hotkeys v2.3.5;
libWrapper v1.11.4.0;
Loot Sheet NPC 5e v3.4.1;
Midi QOL v0.8.103;
Midi SRD v0.1.03;
Milby's Maps Free v1.1.9;
Minimal UI v1.1.10;
MiWwewa's Free Maps Bundle v1.3.0;
Not Enough NPCs: A 5e NPC Generator v1.1.0;
Perfect Vision v2.10.8;
Permission Viewer v0.8.14;
Pings v1.2.12+0.8.6;
Polyglot v1.7.28;
PopOut! v2.4;
Popout Resizer v1.4.2;
Quick Insert - Search Widget v2.5.3;
Quick Module Enable v1.3.4;
Radugen (Random dungeon generator) v0.0.5;
Sequencer v2.0.7;
Settings Extender v1.2.0;
Simple Calendar vv1.3.75;
SmallTime v1.13.10;
Smart Target v0.6.7;
socketlib v1.0.10;
Spells, Items, and Features Toolkit v0.4.3;
Tabletop RPG Music v1.5.1;
Tidy5e Sheet v0.5.21;
Tidy UI - Game Settings v0.1.30;
Times Up v0.8.31;
Token Action HUD v1.3.29;
Token Magic FX v0.5.2.1;
Token Mold v2.14.0;
True RNG v1.0.6;
Warp Gate v1.11.2;
Window Controls v1.7.4;

[BUG] - You cannot drop items from the item bar unless you are a GM.

Describe the bug
When trying to drop items as a player or putting items in the trade dialog, it won't paste the item and just output "Item Piles | You cannot drop items from the item bar unless you are a GM."

To Reproduce
Steps to reproduce the behavior:

1. Initiate trade with player
2. Let player put an item in the trade window
3. See message

Expected behavior
I was under the impression non-GM should be able to drop items, too. Now with sharing it's obvious it's not working as intended.

Screenshots

Setup:

• Foundry Version: 9.249
• Item Piles Version: 1.4.0
• OS: Arch Linux
• Browser Firefox
• Version 97

Active modules:

Additional context
I am using Splittermond as a game system.

Filtered Item Types still show up

Describe the bug
The items filtered out by the "Item type filters" setting are still visible in the item pile. They can't be transferred though. So it seems tey are correctly identified by the filters but still shown. (This goes for both players and GM)

To Reproduce
Steps to reproduce the behavior:

1. Set up filters according to game system
2. Turn itemPile on for a npc
3. insepct the created itemPile

Expected behavior
I expect the filtered items not to show up when insepecting an item pile.

Setup:

• Foundry Version: 9.241
• Item Piles Version: 1.0.5
• OS: Windows 10 64bit
• Browser: FoundryVTT Application, Opera
• Version: 82.0.4227.43

Active modules:

• Item Piles
• libwrapper
• socketlib

Additional context
I tried it both in my DnD 3.5 World and in a freshly created 5e world which has no other modules than the required enabled,

[BUG] - Cannot drop items on existing pile without Midi QoL

Describe the bug
When attempting to drop an item on an existing pile token, nothing happens. There is an exception raised in the console, specifically: Error: This is not a registered game setting.

It is initiated on line 1992 of the api.js file. When a check is made to see if the DragDropTarget is enabled in midi-qol, that check fails with an exception if the midi-qol module is not installed.

To Reproduce
Steps to reproduce the behavior:

1. Configure a World without Midi QoL enabled
2. Create an item pile
3. Attempt to drag an item from the items sidebar onto the pile.
4. See the error in the console. Nothing happens. Item is not added to the pile.

Expected behavior
Would expect the item to be in the inventory of that pile after step 3.

Setup:

• Foundry Version: 9.245
• Item Piles Version: 1.3.0
• OS: macOS
• Browser: Chrome
• Version: 96

Active modules:

• Item Piles
• libwrapper
• socketlib
• Not midi-qol

[BUG] - [Conflict w/ Monk's Active Tile Triggers]

Describe the bug

In a new world with only Item Piles and Monk's Active Tile Triggers enabled, I drop a single item from the items sidebar onto the canvas. A tile is created using the item's icon, then I am given the option of creating a single-item "item pile". There is no console error or warning given.

With Monk's disabled, the above workflow creates a single-item item pile using the expected art asset (with no extra tile remaining).

Expected behavior

When the Monk's mod is on, I expect a single-item item pile to be created when dragging a single item onto the canvas.

Actual behavior

I get a single-item item pile, and a tile using the item's icon.

Setup:

• Foundry Version: [.9241]
• Item Piles Version: [e.g. 1.0.5]
• OS: [iOS]
• Browser [chrome]
• Version [e.g. 96]

Active modules:

• Item Piles
• Monk's Active Tile Triggers
• Dependencies listed on activation

[BUG] - createItemPile creates an item pile in the DM's scene instead of the macro executor's

Describe the bug
When using the ItemPiles.API.createItemPile as a player (and not the DM account)

To Reproduce
Steps to reproduce the behavior:

1. Have two accounts logged in: one of which is the DM account
2. Have the DM and non-DM accounts be on separate scenes
3. As the non-DM account, create a macro, setting the type to "script"
4. Paste the following code - ItemPiles.API.createItemPile({ x: 0, y: 0 });
5. As the non-DM account, execute the script
6. Item pile will be on the DM's scene and not the player's scene who ran the script

Expected behavior
An item pile to be created on the player's scene

Setup:

• Foundry Version: [version 9, Build 242]
• Item Piles Version: [1.1.2]
• OS: [Windows 10]
• Browser [Firefox, 96]

Active modules:

• Item Piles
• libwrapper
• socketlib

[REQUEST] - Retain token names when turning tokens into piles.

Hiya, a ton of thanks for the fantastic mod!
I wonder if it would be a hassle to have the module retain the names of tokens turned into piles? I have a lot of named enemies in my game and it's kinda boring that they revert to the original character name "Orc" instead of "Angry Orc" or even "Bargh the Red."
Thanks again
/Ravenknight

[REQUEST] - Ability to split partial amounts of currency

Is your feature request related to a problem? Please describe.
There is no way to only split a designated amount at this time. It's all or nothing.

Describe the solution you'd like
An input interface would work. The ability to type in how much you want to split with the actors. Or all.
If there is 765 gp, maybe they each get 50 and the rest stays for the group resources later.

Describe alternatives you've considered
Considered not splitting the money.
Considered using a different module for a party bank.

Additional context
None

[BUG] - [LootPile Empty State Doesn't Happen After "Take All" Event, Doesn't Auto-Delete]

Describe the bug

When I "take all" loot out of a LootPile, the Pile remains in the "Open" state and never changes to the "Empty" state. It never auto-deletes.

To Reproduce
Steps to reproduce the behavior:

1. I add a single item to my LootPile on the canvas.
2. As a player, I click on the LootPile. The chest moves from the closed to the open state. I select Take All to remove the book.
3. The chest remains in the open state, never the empty state. It never auto-deletes.
4. I see no console errors.

This is in a world with only LootPiles module active.

Expected behavior

When I take all loot out of an open chest, I expect the chest to either be in the empty state or be auto-deleted.

Screenshots

Setup:

• Foundry Version: [e.g. .9241]
• Item Piles Version: [e.g. 1.0.5]
• OS: [iOS]
• Browser [e.g. chrome]
• Version [Version 96.0.4664.110]

Active modules:

• Item Piles
• libwrapper
• socketlib

Additional context
Add any other context about the problem here.

[REQUEST] - LootSheetNPC5e compatibility

Is your feature request related to a problem? Please describe.
I am frustrated at not being able to change the actor type from a character to an NPC, even when setting the actor type to "npc" instead of "character" in the settings.

Describe the solution you'd like
Ideally I would like to be able to set the module up so that by default it drops an item as a loot sheet.

Describe alternatives you've considered
Setting the actor type to NPC and then converting to loot sheet. This does not currently work as I cannot change the actor type.

[BUG] - Tokens with deleted actors throws errors

Describe the bug
A console error while waiting for the canvas to load.

To Reproduce
Steps to reproduce the behavior:
When running this module I get the following error twice while waiting for the canvas to load.

Expected behavior
No error

Error

Uncaught (in promise) TypeError: Cannot read properties of null (reading 'getFlag')
[Detected 1 package: item-piles]
    at Module.getItemPileData (lib.js:113)
    at Function.isValidItemPile (api.js:1503)
    at Function._initializeItemPile (api.js:1606)
    at _canvasReady (module.js:94)
getItemPileData	@	lib.js:113
isValidItemPile	@	api.js:1503
_initializeItemPile	@	api.js:1606
_canvasReady	@	module.js:94
await in _canvasReady (async)		
_call	@	foundry.js:294
call	@	foundry.js:279
draw	@	foundry.js:19879

Desktop (please complete the following information):

• OS: Windows 10
• Browser Chrome
• Version 1.0.4