fanuelsen/ansible

ansible's Issues

[Wait for update to finish.] 'dict object' has no attribute 'json'

Hi,
thanks for sharing your TrueNAS Update play. I gave it a try and its doing the update from 22.12.0 to 22.12.1 and the reboot.
But when waiting for the reboot, there comes an error up:

TASK [Checks if there is an update available from update server.] ***************************************************************************************************************
ok: [localhost]

TASK [Downloads (if not already in cache) and apply an update.] *****************************************************************************************************************
ok: [localhost]

TASK [Wait for update to finish.] ***********************************************************************************************************************************************
FAILED - RETRYING: Wait for update to finish. (20 retries left).
FAILED - RETRYING: Wait for update to finish. (19 retries left).
FAILED - RETRYING: Wait for update to finish. (18 retries left).
FAILED - RETRYING: Wait for update to finish. (17 retries left).
**fatal: [localhost]: FAILED! => {"msg": "The conditional check 'truenas_reboot_required.json.status == 'REBOOT_REQUIRED'' failed. The error was: error while evaluating conditional (truenas_reboot_required.json.status == 'REBOOT_REQUIRED'): 'dict object' has no attribute 'json'"}**

PLAY RECAP **********************************************************************************************************************************************************************
localhost                  : ok=3    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0  

My assumption would be: its rebooting automatically an then there is no json result anymore, which thows an error at the check

I checked out this and found a hint to solve this there: ansible/ansible#54561 (comment)

Its bringing in a default value, when to original isnt available, so because of this, at "Wait for update to finish."

- until: "truenas_reboot_required.json.status == 'REBOOT_REQUIRED'"
+  until: (truenas_reboot_required.json|default(dict(status=WAITING))).status == 'REBOOT_REQUIRED'

Because my update was done already, could you validate my suggest at your environment?