Giter Site home page Giter Site logo

Comments (10)

KrauseFx avatar KrauseFx commented on May 6, 2024

Ugh, sorry to hear that, does it work fine for 0.9.0 and 0.8.0? Could you check that for me please?
Thanks :)

from fastlane-plugin-appicon.

pschneider avatar pschneider commented on May 6, 2024

Hi Felix,

It seems that every version above 0.6 does not work. I edited the Pluginfile for each version like so:

gem 'fastlane-plugin-appicon', '0.7.0'

once with 0.7.0, 0.8.0 and 0.9.0

then I ran bundle install which shows that the plugin changes the version correctly. Like:

Using fastlane-plugin-appicon 0.9.0 (was 0.6.0)

other gems are not changed, only the plugin.

After running our lane bundle exec fastlane build_icon I checked the Assets in Xcode which updates accordingly and shows the blurry icons.

Example Screenshot for the iPhone Notification iOS 7-11 20pt preview in the assets catalog:

0.6

appicon_v_060

0.7 - 0.10

appicon_v070

I hope you can see the difference here in this small image :)

from fastlane-plugin-appicon.

felipeplets avatar felipeplets commented on May 6, 2024

@pschneider I've done a big improvement on the way images are generated on 0.7 that may have affected the quality. In our tests at Menvia we could not see any difference but I can use your own icon and example to test it. Can you share the source icon with me?

from fastlane-plugin-appicon.

pschneider avatar pschneider commented on May 6, 2024

@felipeplets Sorry for the late reply, some things came up on the weekend.

Unfortunately I can't give you the original icon but it is reproducible with just the tyre. See my attachment. I get the same effect when comparing 0.6 vs >=0.7

icon

from fastlane-plugin-appicon.

KrauseFx avatar KrauseFx commented on May 6, 2024

Hey @pschneider, thanks for this, could you try completely uninstall and re-installing imagmagick? Also, it might be worth trying a different Mac to see if it has anything to do with the environment

from fastlane-plugin-appicon.

PatrickNLT avatar PatrickNLT commented on May 6, 2024

Getting the same issue here. Commenting out image.define("png:exclude-chunks=date,time") in appicon_action.rb fixes it. 🤔

from fastlane-plugin-appicon.

saruye avatar saruye commented on May 6, 2024

Hi,
we are experiencing the same issue with the latest version (0.13.). Is there an easy workaround? Will this be addressed at some point?

from fastlane-plugin-appicon.

Gertjancom avatar Gertjancom commented on May 6, 2024

I also noticed this.

Update 1: I've found that when using a .jpg instead of a .png as source image, the icon is perfectly fine.
Update 2: First update got me thinking about the alpha setting, passing remove_alpha: true also fixes it for me! - even with the .png.

from fastlane-plugin-appicon.

AdamGerthel avatar AdamGerthel commented on May 6, 2024

Same problem here, very big difference when compared to xcode's own handling:

Screenshot 2020-02-24 at 23 39 35

I've worked a lot with image processing in CMS's and I've never heard of graphicsmagick before, but I've had very good experience with imagemagick (which, btw, is used by badge as well. Could that be something to consider?

from fastlane-plugin-appicon.

orkenstein avatar orkenstein commented on May 6, 2024

I also noticed this.

Update 1: I've found that when using a .jpg instead of a .png as source image, the icon is perfectly fine.
Update 2: First update got me thinking about the alpha setting, passing remove_alpha: true also fixes it for me! - even with the .png.

Experiencing the same, but this doesn't help.

from fastlane-plugin-appicon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.