fastlane-community/fastlane-plugin-applivery

fastlane plugin to upload IPA or APK to Applivery.com

fastlane-plugin-applivery's Issues

[Fastlane plugin] Action does not fail if curl command fails

The way the plugin is currently implemented, the action will not fail if the curl upload command fails. For example, if the build path is invalid and there is no file to upload, the upload API returns a failure code but the action silently ignores it and the lane succeeds. This is not helpful when using the action in CI/CD as it gives a false sense of success; the failure can only be detected by looking into the logs.

Upload fails if the git message has quotes "

CI URL & Build URL

It's required to have a new input field that allows to provide the CI and BUILD URL's so that they can be displayed in Applivery Dashboard. As described in the Upload API docs, There are two variables available for that purpose:

• CI URL: deployer.info.ciUrl
• Build URL: deployer.info.buildUrl

Error in build when the commit message starts with "@"

/var/lib/gems/2.3.0/gems/fastlane-2.56.0/fastlane_core/lib/fastlane_core/ui/interface.rb:143:in `shell_error!': [!] Exit status of command 'curl "https://dashboard.applivery.com/api/builds" -H "Authorization: xxxxxx" -F app="xxxxxx" -F versionName="xxxxx" -F notes="Uploaded automatically with fastlane plugin" -F notify=true -F autoremove=true -F os=android -F tags="" -F deployer=fastlane -F package=@"/myApp/app/build/outputs/apk/app.apk" -F gitBranch="develop" -F gitCommit="xxxxx (FastlaneCore::Interface::FastlaneShellError)
" -F gitMessage="@ie fastlane Staging" -F gitRepositoryURL="xxxx
"' was 26 instead of 0.
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (26) couldn't open file "ie fastlane Staging"

Branch name and CI URL not passing correctly

Hi. During testing of the Fastlane plugin, we have noticed 2 issues:

1. Branch name comes through as 'HEAD' rather than the proper branch name. This doesn't appear to be defined properly in the code. It doesn't look like we can override this in the request.
2. There doesn't appear to be a key to pass the CI URL when uploading a build, but this is exposed in the portal as a field.

Thanks.

Bad request

When the plugin tries to upload the .ipa to Applivery shows this error:

[17:25:56]: ▸ {"status":false,"error":{"code":400,"msg":"Bad request","field":"slug"}}

The "field" parameter on error sometimes change. In this case is "slug".