fatihacet/cointop

CoinTop: Realtime crypto portfolio app for desktop

cointop's Issues

Errors on yarn install

I would like to try cointop on my mac, highsierra, but when I run yarn install I get these errors

Node: v10.4.1 (brew install node)
Yarn 1.7.0

yarn install v1.7.0
[1/4] 🔍  Resolving packages...
success Already up-to-date.
$ npm run lint:fix && electron-builder install-app-deps

> [email protected] lint:fix /Users/paul/workspace/javascript/CoinTop
> eslint --ext .js,.vue -f ./node_modules/eslint-friendly-formatter --fix src test


  ✘  https://google.com/#q=import%2Fno-extraneous-dependencies  'electron' should be listed in the project's dependencies, not devDependencies  
  src/main/index.js:1:1
  import { app, BrowserWindow, ipcMain, Menu } from 'electron'; // eslint-disable-line`
   ^

  ✘  https://google.com/#q=import%2Fno-extraneous-dependencies  'electron' should be listed in the project's dependencies, not devDependencies  
  src/renderer/App.vue:6:25
  const { ipcRenderer } = require('electron');
                           ^

  ✘  http://eslint.org/docs/rules/no-unused-vars                'clearInterval' is defined but never used                                       
  src/renderer/components/AppHeader.vue:3:23
  import { setInterval, clearInterval } from 'timers';
                         ^

  ✘  https://google.com/#q=import%2Fno-extraneous-dependencies  'electron' should be listed in the project's dependencies, not devDependencies  
  src/renderer/components/Dashboard.vue:3:18
  const electron = require('electron');
                    ^


✘ 4 problems (4 errors, 0 warnings)


Errors:
  3  https://google.com/#q=import%2Fno-extraneous-dependencies
  1  http://eslint.org/docs/rules/no-unused-vars
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] lint:fix: `eslint --ext .js,.vue -f ./node_modules/eslint-friendly-formatter --fix src test`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] lint:fix script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/firepol/.npm/_logs/2018-06-17T12_31_15_921Z-debug.log
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

2018-06-17T12_31_15_921Z-debug.log:

10 silly lifecycle [email protected]~lint:fix: Args: [ '-c',
10 silly lifecycle   'eslint --ext .js,.vue -f ./node_modules/eslint-friendly-formatter --fix src test' ]
11 silly lifecycle [email protected]~lint:fix: Returned: code: 1  signal: null
12 info lifecycle [email protected]~lint:fix: Failed to exec lint:fix script
13 verbose stack Error: [email protected] lint:fix: `eslint --ext .js,.vue -f ./node_modules/eslint-friendly-formatter --fix src test`
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:304:16)
13 verbose stack     at EventEmitter.emit (events.js:182:13)
13 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack     at ChildProcess.emit (events.js:182:13)
13 verbose stack     at maybeClose (internal/child_process.js:961:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:248:5)
14 verbose pkgid [email protected]
15 verbose cwd /Users/paul/workspace/javascript/CoinTop
16 verbose Darwin 17.6.0
17 verbose argv "/usr/local/Cellar/node/10.4.1/bin/node" "/usr/local/bin/npm" "run" "lint:fix"
18 verbose node v10.4.1
19 verbose npm  v6.1.0
20 error code ELIFECYCLE
21 error errno 1
22 error [email protected] lint:fix: `eslint --ext .js,.vue -f ./node_modules/eslint-friendly-formatter --fix src test`
22 error Exit status 1
23 error Failed at the [email protected] lint:fix script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]

I tried also npm install and in the debug log I get:

2049 warn optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
2050 warn optional SKIPPING OPTIONAL DEPENDENCY: [email protected] install: `node install`
2050 warn optional SKIPPING OPTIONAL DEPENDENCY: Exit status 1
2051 verbose optional SKIPPING OPTIONAL DEPENDENCY:
2051 verbose optional Failed at the [email protected] install script.
2051 verbose optional SKIPPING OPTIONAL DEPENDENCY: This is probably not a problem with npm. There is likely additional logging output above.
2052 verbose stack Error: [email protected] install: `node-gyp rebuild`
2052 verbose stack Exit status 1
2052 verbose stack     at EventEmitter.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:304:16)
2052 verbose stack     at EventEmitter.emit (events.js:182:13)
2052 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
2052 verbose stack     at ChildProcess.emit (events.js:182:13)
2052 verbose stack     at maybeClose (internal/child_process.js:961:16)
2052 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:248:5)
2053 verbose pkgid [email protected]
2054 verbose cwd /Users/paul/workspace/javascript/CoinTop
2055 verbose Darwin 17.6.0
2056 verbose argv "/usr/local/Cellar/node/10.4.1/bin/node" "/usr/local/bin/npm" "install"
2057 verbose node v10.4.1
2058 verbose npm  v6.1.0
2059 error code ELIFECYCLE
2060 error errno 1
2061 error [email protected] install: `node-gyp rebuild`
2061 error Exit status 1
2062 error Failed at the [email protected] install script.
2062 error This is probably not a problem with npm. There is likely additional logging output above.
2063 verbose exit [ 1, true ]

It would be nice if you can help to get this up and running, I'd like also to learn to make a basic electron app related to crypto and I am very interested to secure it in a similar way (keychain).

Thanks for your help

Wrong price calculator for coins (airdrops) without market

I own 5 EOS on binance, and a few days ago I've read that binance distributed 1 EON for each owned EOS. Thus I got 5 EON. However, the price calculator shows the wrong price. 1 EON = 5 BTC is wrong. See screenshot.

I think the error is in exchange.js, in the calculatePrice function, but I have no time to investigate further...

For such cases I'd expect that the price is 0. Thus 5 EON = 0. As soon as they are listed in the exchange and they have a bid/ask value, then it can be used.