fbacker/docker-opensubtitles

docker-opensubtitles's Issues

Broke After upgrade?

I am getting this error now:

opensubtitles    | WARNING: NODE_ENV value of 'production' did not match any deployment config file names.
opensubtitles    | WARNING: See https://github.com/lorenwest/node-config/wiki/Strict-Mode
opensubtitles    | (node:1) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'log' of null
opensubtitles    |     at file:///app/index.js:99:19
opensubtitles    | (Use `node --trace-warnings ...` to show where the warning was created)
opensubtitles    | (node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
opensubtitles    | (node:1) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Error after several successful attempts: "An error occurred while downloading or writing English subtitles for ..."

I am using your script with a bash shell script. I was able to download around 150 subtitles then each subsequent attempt I got the error:

"An error occurred while downloading or writing English subtitles for ..."

There is no more information given. Is it possible to run the script in a more verbose -vv or -vvv mode to see what this error actually is?

Could it be the daily limit of subtitles my account is allowed to download? Is it possible the script ran to fast and I was rate limited in some way?

If so do you get anything more descriptive back from the API what you can pass along to the user. This message does not leave me with much to work with.

What about this error?

2021-08-24 17:48:40	stdout	}
2021-08-24 17:48:40	stdout	"stack": "Error: Search API Failed Error: read ECONNRESET\n    at file:///app/src/opensubtitle/search.js:66:14\n    at processTicksAndRejections (internal/process/task_queues.js:93:5)"
2021-08-24 17:48:40	stdout	"message": "Search API Failed Error: read ECONNRESET",
2021-08-24 17:48:40	stdout	{
2021-08-24 17:48:40	stdout	2021-08-24T17:48:40.608Z [QueParse] error: Failed to handle item
2021-08-24 17:48:40	stdout	}
2021-08-24 17:48:40	stdout	}
2021-08-24 17:48:40	stdout	"syscall": "read"
2021-08-24 17:48:40	stdout	"code": "ECONNRESET",
2021-08-24 17:48:40	stdout	"errno": -104,
2021-08-24 17:48:40	stdout	"err": {
2021-08-24 17:48:40	stdout	{
2021-08-24 17:48:40	stdout	2021-08-24T17:48:40.607Z [ApiLookupMovies] error: API Failed
2021-08-24 17:48:32	stdout	}
2021-08-24 17:48:32	stdout	"fps": "23.976023976023978"
2021-08-24 17:48:32	stdout	"gzip": false,
2021-08-24 17:48:32	stdout	"limit": "all",
2021-08-24 17:48:32	stdout	],
2021-08-24 17:48:32	stdout	"srt"
2021-08-24 17:48:32	stdout	"extensions": [
2021-08-24 17:48:32	stdout	"filename": "The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO.avi",
2021-08-24 17:48:32	stdout	"path": "/movies/The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO[TGx]/The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO.avi",
2021-08-24 17:48:32	stdout	"sublanguageid": "eng,chs",
2021-08-24 17:48:32	stdout	{
2021-08-24 17:48:32	stdout	2021-08-24T17:48:32.941Z [ApiLookupMovies] debug: Search Object
2021-08-24 17:48:32	stdout	2021-08-24T17:48:32.940Z [ApiLookupMovies] info: Search API for a match
2021-08-24 17:48:32	stdout	2021-08-24T17:48:32.931Z [ReadIMDB] info: Look for IMDB id in files
2021-08-24 17:48:32	stdout	}
2021-08-24 17:48:32	stdout	"fps": 23.976023976023978
2021-08-24 17:48:32	stdout	"height": 300,
2021-08-24 17:48:32	stdout	"width": 720,
2021-08-24 17:48:32	stdout	"command": "ffprobe -v 0 -of csv=p=0 -select_streams 0 -show_entries stream=width,height,r_frame_rate "/movies/The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO[TGx]/The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO.avi"",
2021-08-24 17:48:32	stdout	{
2021-08-24 17:48:32	stdout	2021-08-24T17:48:32.930Z [ReadMetadata] debug: Grab media metadata
2021-08-24 17:48:32	stdout	2021-08-24T17:48:32.283Z [ReadMetadata] info: Path /movies/The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO[TGx]
2021-08-24 17:48:32	stdout	}
2021-08-24 17:48:32	stdout	"media": "/movies/The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO[TGx]/The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO.avi"
2021-08-24 17:48:32	stdout	],
2021-08-24 17:48:32	stdout	"/movies/The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO[TGx]/[TGx]Downloaded from torrentgalaxy.to .txt"
2021-08-24 17:48:32	stdout	"/movies/The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO[TGx]/The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO.NFO",
2021-08-24 17:48:32	stdout	"infos": [
2021-08-24 17:48:32	stdout	"subtitles": [],
2021-08-24 17:48:32	stdout	],
2021-08-24 17:48:32	stdout	"/movies/The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO[TGx]/[TGx]Downloaded from torrentgalaxy.to .txt"
2021-08-24 17:48:32	stdout	"/movies/The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO[TGx]/The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO.avi",
2021-08-24 17:48:32	stdout	"/movies/The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO[TGx]/The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO.NFO",
2021-08-24 17:48:32	stdout	"files": [
2021-08-24 17:48:32	stdout	"id": "0b995c4c6e7f5b56deedc929409bfa03",
2021-08-24 17:48:32	stdout	"type": "movies",
2021-08-24 17:48:32	stdout	"fullPath": "/movies/The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO[TGx]",
2021-08-24 17:48:32	stdout	"folderName": "The.War.of.the.Worlds.2021.BRRip.XviD.AC3-EVO[TGx]",
2021-08-24 17:48:32	stdout	{

UTF encoding not working

Hi!

I deployed this using a standard configuration, the only different thing is the languages property in the json file
"languages": ["spa", "eng"]

The thing is that when trying to download the subs in spanish it has issues with the encoding

Looking in the logs I found that it downloads using the URL property.

The one example I have is this one.
Sample name:
Insidious.Chapter.2.2013.1080p.BluRay.x264.YIFY.mp4

checking the logs I found the url is downloading:

{
    "url": "https://dl.opensubtitles.org/en/download/src-api/vrf-19a10c51/sid-5yIJr1cutAyrMQAb057iIM8vTd8/filead/1954341409",
    "langcode": "es",
    "downloads": 14372,
    "lang": "Spanish",
    "encoding": "CP1252",
    "id": "1954341409",
    "filename": "Insidious.Chapter.2.2013.BluRay.720p.DTS.x264-CHD.es.srt",
    "date": "2014-07-23 02:00:32",
    "score": 9.5,
    "fps": 23.976,
    "format": "srt",
    "utf8": "https://dl.opensubtitles.org/en/download/subencoding-utf8/src-api/vrf-19a10c51/sid-5yIJr1cutAyrMQAb057iIM8vTd8/filead/1954341409",
    "vtt": "https://dl.opensubtitles.org/en/download/subformat-vtt/src-api/vrf-19a10c51/sid-5yIJr1cutAyrMQAb057iIM8vTd8/filead/1954341409",
    "calculate": {
        "fps": 4.999976023976021,
        "imdb": 9.5,
        "resolution": 7.279999999999999,
        "resolutions": [
            1920,
undefined 
        ],
        "keys": 2.5,
        "score": 24.27997602397602
    }
}

This is what I see if I download using the url property (this is OK)

But This is what the application is downloading

And this is what happens when the player takes the sub

I'm guessing it has something to do with the encoding. Maybe downloading the UTF8 link when available will fix the issue. I'm guessing this issue can be replicated in other languages with other puntuation symbols

[OpenSubtitle] error: failed to parse TypeError: Cannot read property 'UserPreferedLanguages' of undefined

Hi. Not sure if this project is dead or not...But I have not been able to change which languages this container search for.

I see you write that language selection is made from Opensubtitles userprofile. But even though I have English and Swedish selected, I get "Cannot read property 'UserPreferedLanguages' of undefined" in the login-phase and just English is set as language.

I did some experimenting, I edited src/opensubtitle/login.js inside the container, which seems to intentionally ignore langugages set in config?
I changed:
let { languages } = config.opensubtitles;
into:
let { languages } = config.opensubtitles.languages;
re-starting the container my log showed multiple reconnections and receiving the same opensubtitle token over and over. So basically my experimenting failed. Even with just 'languages:"eng"'

Any ideas of what I'm doing wrong?

opensubtitles.org or .com?

It is unclear what service this container uses.
the documentation could make this clear.