fd/go-nat

NAT port mapping library for Go

go-nat

go-nat's Issues

Don't limit operation to RFC1918 ranges

Currently, the code only runs NAT-PMP on local addresses in the ranges 10.0.0.0/8, 172.16.0.0/12 and 192.168.0.0/16.

However, NAT-PMP/PCP can also be used for simple control of a stateful firewall, even when using public IPv4 or IPv6. See https://tools.ietf.org/html/rfc6887

Additionally, some people are beginning to use other ranges as "private" ranges: either unallocated network ranges (which is a very bad idea, but some people still do that), or the 100.64.0.0/10 range allocated to CG-NAT by https://tools.ietf.org/html/rfc6598

Support for PCP?

Does this lib support Port Control Protocol? I feel like you may have commented on an issue in go-ipfs saying that it did (or someone else did) but i can't see in the code where/how that happens.

Support multiple local addresses on the same NAT

While not critical, it would be nice if this library supported multiple interfaces/addresses on the same NAT. This would mean:

1. Passing a local address (and using it as the source address) when establishing a mapping.
2. Changing GetInternalAddress() to GetInternalAddresses() (or adding a new function) that exposes all internal addresses on the NAT.

Use-cases:

• Multiple "virtual" interfaces (e.g., for containers/VMs).
• Multiple NICs on the same LAN.

I understand you probably don't have time to work on this, I just figured I'd leave this here in case anyone comes along and does.

Don't hardcode the gateway address as the first IP of the network range

Currently, the code takes the assumption that the gateway is always the first IP address of the network range: https://github.com/fd/go-nat/blob/master/natpmp.go#L37

But this is not always the case, see ipfs/kubo#1090

Note that it would be better if the underlying lib found that itself: jackpal/go-nat-pmp#1