fedcomp/any_sms

Simple and flexible solution to send sms in ruby, supporting variety of sms services.

any_sms's Issues

Exception workflow

Gem should handle exceptions from backends and treat them in some way. Probably exceptions should silently make request fail, and if needed - exception object and stacktrace should be available from response object.

Ensure incoming phone number is always in E.164

ActiveSMS should test incoming number for sending SMS, and if it does not follow standard it should throw an ActiveSms::PhoneFormatError exception. However, invalid phone numbers should be all caught by developer during development and not in production.

allow backends to pass metadata in response object

backends should be allowed to put additional meta information in response (remaining funds after api query?)

Additinaly, base backend respond_with_status method should support :meta key.
So you can call it like the following:

respond_with_status :success, meta: { remaining_funds: 63.4 }

Phone number converter

Allow passing custom proc to convert phone numbers on the fly. It would help using already existent database and just converting phone number on the fly.

Test against multiple versions of ruby including dev

Gem should be tested against all currently supported versions of ruby and dev version.

Rspec test helper to ensure sms message sent

ActiveSMS should have sms sent matcher.
Functionality:

• Check if block has sent any sms
• Check phone number and text been used
• Should allow mocking response object with custom status/meta data.
• Check what custom backend: used for delivery.