fedeorlandau/jodit-react-ts

React wrapper for Jodit fully written in Typescript.

jodit-react-ts's Issues

Property 'getSelection' does not exist on type 'ShadowRoot'. TS2339

I'm getting this kind of error.

/Volumes/Projects/Projects/yourpass/jodit/node_modules/jodit/src/core/selection/select.ts
TypeScript error in /Volumes/Projects/Projects/yourpass/jodit/node_modules/jodit/src/core/selection/select.ts(91,31):
Property 'getSelection' does not exist on type 'ShadowRoot'.  TS2339

    89 | 	get sel(): WindowSelection {
    90 | 		if (this.j.o.shadowRoot) {
  > 91 | 			return this.j.o.shadowRoot.getSelection();
       | 			                           ^
    92 | 		}
    93 | 
    94 | 		return this.win.getSelection();

Jodit type errors when running project with this package

Hey there! I found your project through an issue on jodit-react, but I'm running into a lot of TS errors when starting up my project with it. It doesn't happen using jodit-react, but after installing this one I'm getting TS errors inside of the jodit node_module file. Things like:

ERROR in /Users/scottmalmberg/Dev/jodit-react-ts/node_modules/jodit/src/modules/table.ts
741:31-36
[tsl] ERROR in /Users/scottmalmberg/Dev/jodit-react-ts/node_modules/jodit/src/modules/table.ts(741,32)
      TS6133: 'index' is declared but its value is never read.

ERROR in /Users/scottmalmberg/Dev/jodit-react-ts/node_modules/jodit/src/jodit.ts
684:39-43
[tsl] ERROR in /Users/scottmalmberg/Dev/jodit-react-ts/node_modules/jodit/src/jodit.ts(684,40)
      TS6133: 'type' is declared but its value is never read.

I've tried removing my yarn.lock file and updating my TypeScript (v4.2.2) and ts-loader (v8.0.14) versions to match Jodit's, but haven't had luck. Initially the install seemed successful when I installed while my webpack-dev-server (v3.11.2) was running, but the errors popped up after I restarted it.

Any idea what could be wrong? Thanks!

Error on publish Uncaught TypeError: Cannot set property Promise of #<Window>

I'm building a Power Component Framework (PCF) for Canvas Power Apps using the Jodit Rich Text Editor, and jodit-react-ts.

When I run tests, it works fine, as shown in the image below.

I execute the 'msbuild' command and export it to the environment, and there are no errors. However, when I try to use it within the application, it throws the following error:

Uncaught TypeError: Cannot set property Promise of #<Window> which has only a getter at L.polyfill (jodit.min.js:1:156302) at Object._ (jodit.min.js:1:150259) at n (jodit.min.js:1:721786) at Object._ (jodit.min.js:1:715095) at n (jodit.min.js:1:721786) at eval (jodit.min.js:1:723193) at eval (jodit.min.js:1:723889) at eval (jodit.min.js:1:723900) at eval (jodit.min.js:1:39) at eval (jodit.min.js:1:62) L.polyfill @ jodit.min.js:1 _ @ jodit.min.js:1 n @ jodit.min.js:1 _ @ jodit.min.js:1 n @ jodit.min.js:1 eval @ jodit.min.js:1 eval @ jodit.min.js:1 eval @ jodit.min.js:1 eval @ jodit.min.js:1 eval @ jodit.min.js:1 ./node_modules/jodit-react-ts/node_modules/jodit/build/jodit.min.js @ D%253a0SvcFab0_App0PowerApps.WebAuthoringType_App660work0wymbjdrh.x3d020S0Resources0Controls0PowerHelp.JoditRichText.bundle.js?skoid=58690ece-ec83-4ce2-9ce8-883d4d6a54ee&sktid=975f013f-7f24-47e8-a7d3-abc4752bf346&skt=2023-11-14T14%3A24%3A24Z&ske=2023-11-15T14%3A39%3A24Z&sks=b&skv=2021-12-02&sv=2021-12-02&spr=https&se=2023-11-15T14%3A39%3A24Z&sr=b&sp=r&sig=L0KXqGFOBMu9IbkVVc%2BU6ZC%2F7XxMJil6V8KHD66z1%2Fk%3D:85 __webpack_require__ @ D%253a0SvcFab0_App0PowerApps.WebAuthoringType_App660work0wymbjdrh.x3d020S0Resources0Controls0PowerHelp.JoditRichText.bundle.js?skoid=58690ece-ec83-4ce2-9ce8-883d4d6a54ee&sktid=975f013f-7f24-47e8-a7d3-abc4752bf346&skt=2023-11-14T14%3A24%3A24Z&ske=2023-11-15T14%3A39%3A24Z&sks=b&skv=2021-12-02&sv=2021-12-02&spr=https&se=2023-11-15T14%3A39%3A24Z&sr=b&sp=r&sig=L0KXqGFOBMu9IbkVVc%2BU6ZC%2F7XxMJil6V8KHD66z1%2Fk%3D:263 eval @ jodit-react-ts.esm.js:7 ./node_modules/jodit-react-ts/dist/jodit-react-ts.esm.js @ D%253a0SvcFab0_App0PowerApps.WebAuthoringType_App660work0wymbjdrh.x3d020S0Resources0Controls0PowerHelp.JoditRichText.bundle.js?skoid=58690ece-ec83-4ce2-9ce8-883d4d6a54ee&sktid=975f013f-7f24-47e8-a7d3-abc4752bf346&skt=2023-11-14T14%3A24%3A24Z&ske=2023-11-15T14%3A39%3A24Z&sks=b&skv=2021-12-02&sv=2021-12-02&spr=https&se=2023-11-15T14%3A39%3A24Z&sr=b&sp=r&sig=L0KXqGFOBMu9IbkVVc%2BU6ZC%2F7XxMJil6V8KHD66z1%2Fk%3D:75 __webpack_require__ @ D%253a0SvcFab0_App0PowerApps.WebAuthoringType_App660work0wymbjdrh.x3d020S0Resources0Controls0PowerHelp.JoditRichText.bundle.js?skoid=58690ece-ec83-4ce2-9ce8-883d4d6a54ee&sktid=975f013f-7f24-47e8-a7d3-abc4752bf346&skt=2023-11-14T14%3A24%3A24Z&ske=2023-11-15T14%3A39%3A24Z&sks=b&skv=2021-12-02&sv=2021-12-02&spr=https&se=2023-11-15T14%3A39%3A24Z&sr=b&sp=r&sig=L0KXqGFOBMu9IbkVVc%2BU6ZC%2F7XxMJil6V8KHD66z1%2Fk%3D:263 eval @ JoditReactTs.tsx:64 ./JoditRichText/components/JoditReactTs.tsx @ D%253a0SvcFab0_App0PowerApps.WebAuthoringType_App660work0wymbjdrh.x3d020S0Resources0Controls0PowerHelp.JoditRichText.bundle.js?skoid=58690ece-ec83-4ce2-9ce8-883d4d6a54ee&sktid=975f013f-7f24-47e8-a7d3-abc4752bf346&skt=2023-11-14T14%3A24%3A24Z&ske=2023-11-15T14%3A39%3A24Z&sks=b&skv=2021-12-02&sv=2021-12-02&spr=https&se=2023-11-15T14%3A39%3A24Z&sr=b&sp=r&sig=L0KXqGFOBMu9IbkVVc%2BU6ZC%2F7XxMJil6V8KHD66z1%2Fk%3D:20 __webpack_require__ @ D%253a0SvcFab0_App0PowerApps.WebAuthoringType_App660work0wymbjdrh.x3d020S0Resources0Controls0PowerHelp.JoditRichText.bundle.js?skoid=58690ece-ec83-4ce2-9ce8-883d4d6a54ee&sktid=975f013f-7f24-47e8-a7d3-abc4752bf346&skt=2023-11-14T14%3A24%3A24Z&ske=2023-11-15T14%3A39%3A24Z&sks=b&skv=2021-12-02&sv=2021-12-02&spr=https&se=2023-11-15T14%3A39%3A24Z&sr=b&sp=r&sig=L0KXqGFOBMu9IbkVVc%2BU6ZC%2F7XxMJil6V8KHD66z1%2Fk%3D:263 eval @ index.ts:39 ./JoditRichText/index.ts @ D%253a0SvcFab0_App0PowerApps.WebAuthoringType_App660work0wymbjdrh.x3d020S0Resources0Controls0PowerHelp.JoditRichText.bundle.js?skoid=58690ece-ec83-4ce2-9ce8-883d4d6a54ee&sktid=975f013f-7f24-47e8-a7d3-abc4752bf346&skt=2023-11-14T14%3A24%3A24Z&ske=2023-11-15T14%3A39%3A24Z&sks=b&skv=2021-12-02&sv=2021-12-02&spr=https&se=2023-11-15T14%3A39%3A24Z&sr=b&sp=r&sig=L0KXqGFOBMu9IbkVVc%2BU6ZC%2F7XxMJil6V8KHD66z1%2Fk%3D:31 __webpack_require__ @ D%253a0SvcFab0_App0PowerApps.WebAuthoringType_App660work0wymbjdrh.x3d020S0Resources0Controls0PowerHelp.JoditRichText.bundle.js?skoid=58690ece-ec83-4ce2-9ce8-883d4d6a54ee&sktid=975f013f-7f24-47e8-a7d3-abc4752bf346&skt=2023-11-14T14%3A24%3A24Z&ske=2023-11-15T14%3A39%3A24Z&sks=b&skv=2021-12-02&sv=2021-12-02&spr=https&se=2023-11-15T14%3A39%3A24Z&sr=b&sp=r&sig=L0KXqGFOBMu9IbkVVc%2BU6ZC%2F7XxMJil6V8KHD66z1%2Fk%3D:263 (anonymous) @ D%253a0SvcFab0_App0PowerApps.WebAuthoringType_App660work0wymbjdrh.x3d020S0Resources0Controls0PowerHelp.JoditRichText.bundle.js?skoid=58690ece-ec83-4ce2-9ce8-883d4d6a54ee&sktid=975f013f-7f24-47e8-a7d3-abc4752bf346&skt=2023-11-14T14%3A24%3A24Z&ske=2023-11-15T14%3A39%3A24Z&sks=b&skv=2021-12-02&sv=2021-12-02&spr=https&se=2023-11-15T14%3A39%3A24Z&sr=b&sp=r&sig=L0KXqGFOBMu9IbkVVc%2BU6ZC%2F7XxMJil6V8KHD66z1%2Fk%3D:349 (anonymous) @ D%253a0SvcFab0_App0PowerApps.WebAuthoringType_App660work0wymbjdrh.x3d020S0Resources0Controls0PowerHelp.JoditRichText.bundle.js?skoid=58690ece-ec83-4ce2-9ce8-883d4d6a54ee&sktid=975f013f-7f24-47e8-a7d3-abc4752bf346&skt=2023-11-14T14%3A24%3A24Z&ske=2023-11-15T14%3A39%3A24Z&sks=b&skv=2021-12-02&sv=2021-12-02&spr=https&se=2023-11-15T14%3A39%3A24Z&sr=b&sp=r&sig=L0KXqGFOBMu9IbkVVc%2BU6ZC%2F7XxMJil6V8KHD66z1%2Fk%3D:352

Could you please help me if I'm doing something wrong?
If you need any more information, I'm available.
Thank you!

Text jumps to lower line on input

Hi there, first of all thanks for the working jodit wrapper - I had a nightmare with jodit-react itself!

I've noticed that when starting to type, the text moves to a lower line (see your sandbox example). Is there something I can do to prevent this from happening?