fedora-iot/dbus-parsec

DBus PARSEC interface

dbus-parsec's Issues

Choose license and add appropriate license file

We need an appropriate license and to include the license file

Migrate from ring to openssl

Migrate from ring to openssl or another more standard crypto library/crate.

dbus-parsec.service fails to start on fedora-iot 36

The dbus-parsec service fails to start.

Aug 30 17:41:59 systemd[1]: Failed to start dbus-parsec.service - PARSEC-encrypted DBus secrets daemon.
Aug 30 17:42:09 systemd[1]: dbus-parsec.service: Scheduled restart job, restart counter is at 433.
Aug 30 17:42:09 systemd[1]: Stopped dbus-parsec.service - PARSEC-encrypted DBus secrets daemon.
Aug 30 17:42:09 systemd[1]: Starting dbus-parsec.service - PARSEC-encrypted DBus secrets daemon...
Aug 30 17:42:09 dbus-parsec[3928]: Error: ParsecClient(Client(Interface(OpcodeDoesNotExist)))
Aug 30 17:42:09 systemd[1]: dbus-parsec.service: Main process exited, code=exited, status=1/FAILURE
Aug 30 17:42:09 systemd[1]: dbus-parsec.service: Failed with result 'exit-code'.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1964991

cc @nullr0ute @puiterwijk @decathorpe

Auto-select first provider

Instead of just hardcoding the TPM provider, we want to select the first provider listed in list_providers.

parsec.service fails to start on Fedora IoT 37/38

On both of my Fedora 38 IoT systems (x86_64 and aarch64) parsec.service fails to start. This issue was present in Fedora 37 as well.

May 26 10:36:03 hostname.example.com systemd[1]: parsec.service: Scheduled restart job, restart counter is at 4.
May 26 10:36:03 hostname.example.com systemd[1]: Stopped parsec.service - Parsec Service.
May 26 10:36:03 hostname.example.com systemd[1]: Starting parsec.service - Parsec Service...
May 26 10:36:03 hostname.example.com parsec[1268]: Error: Permission denied (os error 13)
May 26 10:36:03 hostname.example.com systemd[1]: parsec.service: Main process exited, code=exited, status=1/FAILURE
May 26 10:36:03 hostname.example.com systemd[1]: parsec.service: Failed with result 'exit-code'.
May 26 10:36:03 hostname.example.com systemd[1]: Failed to start parsec.service - Parsec Service.

Default state of /var/lib/parsec :

[root@example parsec]# ls -al
total 0
drwxr-xr-x. 1 parsec  parsec          16 May  2 21:06 .
drwxr-xr-x. 1 root    root           836 May  8 15:21 ..
drwxr-xr-x. 1 dnsmasq parsec-clients   0 May  2 21:06 mappings

chown -R parsec:parsec /var/lib/parsec allows parsec.service to start

Build failure with dbus crate

I'm seeing the following error when trying to build this on Fedora 37

   Compiling parsec-client v0.14.0
warning: unused import: `dbus::arg`
 --> /builddir/build/BUILD/dbus-parsec-0.3.1/target/release/build/dbus-parsec-361de4b5cf7b1530/out/dbus_parsec_control_client.rs:3:5
  |
3 | use dbus::arg;
  |     ^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
warning: unused import: `parsec_client::core::secrecy::Secret`
  --> src/daemon.rs:23:5
   |
23 | use parsec_client::core::secrecy::Secret;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default
warning: unused import: `dbus::arg`
 --> /builddir/build/BUILD/dbus-parsec-0.3.1/target/release/build/dbus-parsec-361de4b5cf7b1530/out/dbus_parsec_control_server.rs:3:5
  |
3 | use dbus::arg;
  |     ^^^^^^^^^
warning: unused import: `dbus::arg`
 --> /builddir/build/BUILD/dbus-parsec-0.3.1/target/release/build/dbus-parsec-361de4b5cf7b1530/out/dbus_parsec_control_client.rs:3:5
  |
3 | use dbus::arg;
  |     ^^^^^^^^^
error[E0308]: mismatched types
  --> src/agent/control.rs:38:56
   |
38 |         match self.parsec_client.psa_export_public_key(key_name.clone()) {
   |                                                        ^^^^^^^^^^^^^^^^
   |                                                        |
   |                                                        expected `&str`, found struct `std::string::String`
   |                                                        help: consider borrowing here: `&key_name`
error[E0308]: mismatched types
  --> src/agent/control.rs:48:48
   |
48 |                         .psa_export_public_key(key_name.clone())
   |                                                ^^^^^^^^^^^^^^^^
   |                                                |
   |                                                expected `&str`, found struct `std::string::String`
   |                                                help: consider borrowing here: `&key_name`
error[E0308]: mismatched types
   --> src/agent/mod.rs:162:31
    |
162 |             .psa_generate_key(key_name.to_string(), key_attrs)?;
    |                               ^^^^^^^^^^^^^^^^^^^^
    |                               |
    |                               expected `&str`, found struct `std::string::String`
    |                               help: consider borrowing here: `&key_name.to_string()`
error[E0308]: mismatched types
   --> src/agent/mod.rs:211:41
    |
211 |                 .psa_asymmetric_decrypt(key_name, asym_enc_algo, wrapkey, None)
    |                                         ^^^^^^^^
    |                                         |
    |                                         expected `&str`, found struct `std::string::String`
    |                                         help: consider borrowing here: `&key_name`
For more information about this error, try `rustc --explain E0308`.
warning: `dbus-parsec` (bin "dbus-parsec") generated 3 warnings
error: could not compile `dbus-parsec` due to 4 previous errors; 3 warnings emitted
warning: build failed, waiting for other jobs to finish...
warning: `dbus-parsec` (bin "dbus-parsec-control") generated 1 warning
error: build failed