fenhl/magic-set-generator

Generate Magic Set Editor files from lists of card names

magic-set-generator's Issues

Get art from Scryfall

The Scryfall API provides a JSON object for each card which includes an URL of the cropped card art. It doesn't provide full art, but it's better than nothing.

When using this API, the artist credit should also be set accordingly.

Open question: Which printing to prefer? Just the newest one? Allow specifying an order of preference, or even a per-card preferred printing? This would also be useful for things like flavor text.

Wooded Foothills is rendered with a white frame

This seems to be caused by MSE misinterpreting the W in the card title, but I'm not sure how to fix it. Probably best to manually set frame colors for every land card.

Artifact lands

Artifact lands are rendered with the artifact frame, when they should have the land frame.

Rules text that looks like an ability word is italicized

The word Grandeur in the rules text of Illusions of Grandeur is italicized, since it's also an ability word. A potential fix for this would be to use MSE's CARDNAME feature wherever a card's own name appears in its rules text. Whether this covers all occurences of this bug is to be determined.

Investigate switching to M15 Extra template

The template has an option to turn off the holofoil stamp for rares and mythics, which is a good idea as an additional step in marking cards as proxies. If other required features (notably border color) are supported as well, it should be used instead of the M15 template.

Dominaria update

Currently waiting for a new version of the template pack to release, this project will require the following changes made with Dominaria:

• Support for Saga cards
• New frame feature for legendary cards, including:
  • legendary Vehicles
  • legendary full-art colorless cards
  • legendary double-faced cards
  • legendary ixalands (?)
  • legendary flip cards
  • legendary multitype enchantments
  • legendary tokens when support for tokens is added
• addition of the flavor line when support for flavor text is added
• the order of mana symbols in oracle text should now match the normalization done by cost_to_mse. Remove the --new-wedge-order option and only use normalization to warn if in --verbose mode and the normalization does not match the original order.

Provide precompiled CLI for Windows

This would make using the features that aren't in the GUI right now a bit easier, especially since installing Rust on Windows is a bit annoying.

MTG JSON 4 support

The script currently fails because of the breaking changes in MTG JSON version 4. I see two feasible ways of fixing this:

1. Update the mtgjson dependency with mbr/pymtgjson#7 or replace it.
2. Rewrite the script in Rust, which is planned anyway for integration with the Lore Seeker desktop app.

I'm probably going to go ahead with option 2, but a pull request with option 1 would be welcome. Update: work on option 2 is in progress on the riir branch.

Rage Extractor mana symbol

The rules text of Rage Extractor contains the Phyrexian symbol {P}, which is not supposed to have any background. Since MSE does not appear to have this symbol, it's currently approximated with a similar symbol that has a gray circular background similar to generic mana symbols. Once the correct symbol is added to MSE, json-to-mse should be fixed to use it.

EXE Program Issue

The win64 and win32 EXE programs won't launch. Hopefully, the issue can be fixed soon

Some ability words are not italicized

Noticed with delirium, but there are probably others.

Land types

Basic land types are not considered for the land's frame color.

Consecutive non-loyalty abilities

Will Kenrith and Rowan Kenrith are the first two planeswalkers with 5 abilities, the 4th and 5th being non-loyalty abilities. Need to make sure these are handled correctly, i.e. put into the same text box. While switching to Mainframe Walkers is probably a good opportunity to implement this.

MSE to JSON

A feature suggestion: would it be possible to do the reverse encoding, taking an MSE file and turning into MTGJSON format? That could be useful for things like RNN training!

Last card in planes set has no text

When using the --planes-output option, the last card in the set file for planes and phenomena has no rules text.

No idea why this happens.

border -> borderColor

https://github.com/fenhl/json-to-mse/blob/9a5bd564f5102014f0c5bfec5e004768f0df3012/json-to-mse.py#L1170
mtgjson v4 uses borderColor instead. (this is using your updated version of pyMTGJSon).
card_info.set.border doesn't seem to exist at all.

Read artist credit from EXIF tags

Read the Exif.Image.Artist (315) tag of each image file used for a card and use it to populate that card's artist credit field.

Check for updates

After debugging an issue that was caused by the user not being on the latest version of json-to-mse, it seems that a check for whether the repo head matches github master would be useful, at least in --verbose mode.

Remove find_cards dependency

Instead of requiring find_cards for mtg.wtf queries, the script could request a list of cards from Lore Seeker. The find_cards script could still be used to enable running offline (as soon as MTG JSON caching is enabled) if the --find-cards option is used.

Global copyright line

Recent updates to MSE have added the ability to specify the copyright message on a per-set basis instead of a per-card basis. The --copyright=<message> option should switch to this new feature and make sure it's enabled.

Meld cards

Implement meld cards using the EDM Meld template for the front face with the meld ability and the combined back face, and using the DFC exporter template for the front face with the reminder text.

Waiting for the DFC exporter template to be added to the template pack.

Checkerboard pattern on Scryfall images

Images downloaded from Scryfall often display a checkerboard pattern. Applying a median filter might fix this.

Scheme cards

Implement scheme cards. Unsure whether to use the ARC frame or the E01 frame. E01 is from the m15 era while ARC is from the modern era, but E01 is specifically tied to the character of Nicol Bolas.

Like planes/phenomena and vanguards, we also want an option to render schemes as regular-size cards.

Incorrect handling of accented letters with mtg.wtf syntax

Running json-to-mse '=b:isd,soi' fails with card not found: Seance. This is because magic-search-engine's find_cards outputs the card as Seance, but it's listed as Séance in MTG JSON.

Feature parity with version 1

The Rust rewrite (#21) is on the main branch, but there are still some missing features compared to the old Python version:

• !tappedout
• directory with images as --input
• --allow-uncards
• --find-cards
• --plane-templates
• remaining card parts and variants (which?)