ffalt/hookay

listen to webhooks, pull git, call jekyll or hugo (and a little web app to view the state)

hookay's Issues

BodyParser can't handle large webhook payloads

Hey @ffalt !

I'm having issues with Hookay when GitHub sends webhook payloads that are very large.
Searching the interwebs, the issue seems to be with bodyParser. A solution is setting this option in bodyParser.urlencoded to false
bodyParser.urlencoded({extended: false}).

See the funny doc here https://github.com/expressjs/body-parser#bodyparserurlencodedoptions

Defaults to true, but using the default has been deprecated.

The corresponding line in Hookay is here

hookay/backend/src/lib/server.ts

Line 25 in 28306f2

this.app.use(bodyParser.urlencoded({extended: true, verify: this.verify.bind(this)}));

Could you (or I?) make the change an a release?

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Add support for Hugo

Hey @ffalt!
I'd like to add build support for Hugo to hookay.

The webhook flow would be the same as for Jekyll, except that it would run $ hugo and then move the generated public/ directory to the specified dest_path.

I would check in a Hugo binary that does all the building, there are no further dependencies needed.

What do you think? Do you think it's feasible? I guess lib/executor.js would be a good start point but creating a different Task for Hugo?

Apply env `JEKYLL_ENV=production`

hookay should call jekyll with the env variable JEKYLL_ENV=production set.
GitHub Pages is using that when building sites: jekyll/jekyll#1219

We're using it for enabling/disabling piwik: https://github.com/okfde/offenerhaushalt.de/blob/0c3adc02bd3d94680a6b958966a51a17b2a39df0/_includes/tracking.html#L1