Some effects broken (Compare with N64 console)

[fgsfdsfgs]

Some effects broken (Compare with N64 console)

[fgsfdsfgs]

Should be fixed now.

[fgsfdsfgs]

What do you mean by "Light"?
Currently any framebuffer effects like blur, menu backgrounds, cloaking and light halos don't work.

Light could mean either the lighting lens flares not working, or models being full bright.

[jonaeru]

What do you mean by "Light"?

It mean light halos.

Currently any framebuffer effects like blur, menu backgrounds, cloaking and light halos don't work.

I understood. Thank you.

[jonaeru]

I have checked that some of the graphics have been fixed. Thank you.
I tested this build. https://github.com/fgsfdsfgs/perfect_dark/actions/runs/5987730156
Video: https://youtu.be/-6w_LLtTLf0

OK:

• Night Vision
• Menu Background
• Light Halo
• Highlight (Pickups, Players, Teams)
• Mauler (charge-up shot)

Not OK:

• CamSpy (The screen is fine, but not enough distortion)
• IR Scanner
• Horizon Scanner
• Infiltration Intro cutscene
• Blur
• Slayer (fly-by-wire rocket)

[jonaeru]

I have checked that some of the graphics have been fixed. Thank you.
I made a comparison with the N64 console.
Build: https://github.com/fgsfdsfgs/perfect_dark/actions/runs/6216037392 (31bb7c6)
Video: https://youtu.be/lB6ayFnRnVA

List

OK:

• Menu Background
• Light Halo
• Rain
• Snow
• Infiltration intro
• Gas
• Cloaking
• Highlight (Pickups, Players, Teams)
• Night Vision
• X-Ray Scanner
• IR Scanner
• Mauler (charge-up shot)
• FarSight XR-20
• Slayer (fly-by-wire rocket)
• Screen Shake

Mostly OK (some problems):

• Sky (Sunlight penetrating)
• Slow Motion (Lots of footsteps are heard in Defense) https://youtu.be/lB6ayFnRnVA?t=1188
• CamSpy (The screen is fine, but not enough distortion)

Not OK:

• Blur
• Horizon Scanner
• Attack Ship Barrier
• Skedar Ruins Bridge
• Autogun (Investigation, Crash Site)

Sky

Sunlight penetrating

PC Port

N64 Console

CamSpy

The screen is fine, but not enough distortion

PC Port

N64 Console

Attack Ship Barrier

PC Port

N64 Console

Skedar Ruins Bridge

PC Port

N64 Console

Autogun (Investigation, Crash Site)

PC Port

N64 Console

The bridge isn't red anymore and turret colors are fixed. Though the textures are still kind of messed up, I wonder how the n64 handles texture mirroring. Maybe it's some kind of minor difference with fast3d vs whatever perfect dark is using

[fgsfdsfgs]

Mirroring is handled correctly for at least some textures. I am not sure why it isn't handled correctly in some cases.

Would something like gl_mirrored_repeat fix it or am I completely wrong? I think this is the crossbow texture

But yeah that still wouldn't explain why it happens either

[fgsfdsfgs]

No, what I mean is it is supposed to set GL_MIRRORED_REPEAT or GL_MIRROR_CLAMP_TO_EDGE there, but it doesn't for some reason.

[fgsfdsfgs]

Motion blur, combat boost blur and fisheye effect on the eyespy should now be in. Some of the textures above were also fixed in a recent PR.

[jonaeru]

Thank you. I made a comparison with the N64 console.
Build: https://github.com/fgsfdsfgs/perfect_dark/actions/runs/6539395852 (1eb1e96)
Video: https://youtu.be/81JJ8mkjtjo

List

OK:

• Menu Background
• Light Halo
• Rain
• Snow
• Infiltration intro
• Gas
• Motion Blur
• Cloaking
• Highlight (Pickups, Players, Teams)
• Night Vision
• X-Ray Scanner
• IR Scanner
• Mauler (charge-up shot)
• FarSight XR-20
• Slayer (fly-by-wire rocket)
• Screen Shake
• Autogun (Investigation, Crash Site)

Mostly OK (some problems):

• Sky (Sunlight penetrating)
• Slow Motion (Lots of footsteps are heard in Defense) https://youtu.be/81JJ8mkjtjo?t=1053s (17:33)
  Similar to this? #53
• CamSpy (Ceiling disappears in Investigation) https://youtu.be/81JJ8mkjtjo?t=1608s (26:48)
• Skedar Ruins Bridge (Graphics are not correct)
  Similar to this? #25

Not OK:

• Horizon Scanner
• Attack Ship Barrier

[fgsfdsfgs]

Thank you for the detailed report.
The bridge issue looks to be the result of a wrong alpha blending mode + some transparent surface sorting issues. Perhaps it's actually supposed to have depth buffering enabled but it doesn't, or something similar to that.
I have no clue why the ceiling disappears though. Maybe the camspy almost clips through it when you go all the way up, but due to floating point error it appears to the clipping code as if it is through it, so the ceiling stops rendering.

UPD: Horizon scanner effect is now implemented. Also fixed a bug that made you autoturn when you had it out.

[jonaeru]

Thank you. Horizon scanner effect seems fine.

[pHANTOMpHREAK9P]

Certain textures (and some planes that are not visible textures in the vent corners) will appear as a blue texture during the CamSpy tutorial section in the Carrington Institute. This problem did not exist before the proper fish eye lens effect that was recently applied.

[fgsfdsfgs]

Upon looking into this some more, the bullet hole thing isn't mirroring related. The full bullet hole texture actually has both halves in it:

This is in fact an issue with the renderer not handling texture LODs correctly.

[jonaeru]

Build: https://github.com/fgsfdsfgs/perfect_dark/actions/runs/7117212181 (aeb6851)

Mostly OK (some problems):

• Sky (Sunlight penetrating)

Not fixed

• Slow Motion (Lots of footsteps are heard in Defense) https://youtu.be/81JJ8mkjtjo?t=1053s (17:33)
  Similar to this? Fix spamming footsteps for slow mode #53

Not fixed

• CamSpy (Ceiling disappears in Investigation) https://youtu.be/81JJ8mkjtjo?t=1608s (26:48)

Probably OK

• Skedar Ruins Bridge (Graphics are not correct)
  Similar to this? Datadyne: Defection Carpet Texture Broken #25

OK

Not OK:

• Horizon Scanner

OK

• Attack Ship Barrier

OK

[fgsfdsfgs]

The light glares have been improved somewhat in 15c0327. They're still not 100% accurate to N64.