fgsfdsfgs/perfect_dark

work in progress port of n64decomp/perfect_dark to modern platforms

perfect_dark's Issues

RC-P120 Silver challenge impossible to complete

In the recently fixed gun range, the RC-P120 Silver challenge is impossible to complete as the targets won't react to the player turning invisible. They're meant to slowly turn around when using the alt fire option to cloak, but they won't do it.

rcp120.bug.mp4

Will update with other challenges that aren't possible to complete, if any.

Models "squish" on some spots

Specially noticeable with mines, but also just had a guard do it in real time. Not sure what triggers it, seems to be dependant on the map geometry.

squished.model.mp4

broken sky on villa (and possibly other maps)

the sky on villa renders pitch black (this probably effects other maps too but I haven't tested yet)

Incorrect Co-op spawns on DataDyne Defection

When playing dD-Defection in co-operative mode, the Player 2 character spawns in the wrong location, appearing in front of Joanna and becoming stuck inside her. While I haven't compared the other levels' spawn locations with the original game, the rest of Mission 1's levels
can at least be played without teamkilling
https://github.com/fgsfdsfgs/perfect_dark/assets/42668580/678441e4-d5f2-46d4-bae9-fef596c90f9d

Texture transparency blending is broken on some effects

Effects such as blood spurts, sparks from bullets hitting walls, tracer fire, etc seem to have incorrect alpha blending.

Some characters get stuck in place

Some characters can get stuck in place, repeating an animation loop. This can result in a failed mission if the character is necessary to the objective.

Frame buffer effects run at the wrong aspect ratio

Compare me pausing to the actual game footage, the crates and mission time at the left get offset and stretched.

frame.buffer.mp4

Mouse wheel not working

The mouse wheel doesnt work, it doesn't change weapons. I think it's still in development.

Small gaps impassable at high framerates.

2023-08-20.18-06-06.webm

See video. Unsure what the "intended" behavior should be considered here, it's likely the devs just didn't realize that gap was impassable without the regular lag the n64 version experienced.

Environment mapped surfaces look incorrect

It looks like the texture coordinates generation (G_TEXTURE_GEN) has an issue, or the normals are being read incorrectly... The opening logos demonstrate it pretty well.

Emulation	Current

Some effects broken (Compare with N64 console)

Sorry if this is known, but the following graphics were incomplete.
I tested this build. https://github.com/fgsfdsfgs/perfect_dark/actions/runs/5879598251
Video: https://youtu.be/qtzlnEuvBY8

• CamSpy (Not enough distortion)
• Night Vision
• IR Scanner
• Menu Background
• Light
• Horizon Scanner
• Infiltration Intro cutscene
• Blur
• Highlight (Pickups, Players, Teams)
• Mauler (charge-up shot)
• Slayer (fly-by-wire rocket)

radial menu should be on Q instead of G

Scroll Wheel bindings don't work

VK_MOUSE_WHEEL_UP and VK_MOUSE_WHEEL_DN don't appear to work inside the kbbinds. Looking it up it seems like they'd need to be handled inside the SDL_PollEvent as a SDL_MOUSEWHEEL event and grab the event.wheel.y value? My experience with regular C projects is a little lacking and I'm struggling to figure out how to link the values properly back to the input file, and if there's a proper way to access the values.

Combat Simulator splitscreen flash

Playing splitscreen through combat simulator creates this flashy show. Similar to some video plugins on emulators, I believe it's related to the frame buffer. Does not happen through Co-Op.

SEIZURE WARNING:
https://github.com/fgsfdsfgs/perfect_dark/assets/34986384/150a61f7-7575-4956-ae11-addfcf5764d3

dedicated crouch buttons

• toggle half-crouch (1964 behavior) - implemented by #184
• toggle full-crouch (1964 behavior) - implemented by #184
• cycle crouch (xbla L3 behavior) - implemented by #184
• implement hold / toggle flag per/player for 1964-style bindings

CTD loading Crash Site

Unsure when this first began appearing, as video shows, some game sessions Crash Site will be working and can be loaded perfectly fine, either from abort reload or from institute. Other game sessions it will crash any time it's loaded.
2023-08-20 15-00-52.webm
Attached video is;
-Abort reload
-Abort reload
-Carrington load
-Reboot game
-Carrington crash
-Reboot game
-Carrington crash

Happens across multiple savefiles, but haven't seen it occur with any other level.

Text in multiplayer flickers before it appears

Text will appear as either fully green, or red squares for a brief moment before it correctly fades in.

Text.flicker.mp4

EDIT: I have not seen this happen to me in singleplayer yet, so I have edited the issue to specify.

Multiplayer limits cannot be changed

The sliders to adjust and change time, score, and team score won't respond to any inputs other than A and B.

Some mirrored textures do not mirror.

This is easily noticeable with decals like metal impact holes.

Portal issue in Carrington Institute

At a certain angle as shown in the image it's possible to load the room below us, which clips in geometry with the current one.

GoldenEye-styled turret models have blue muzzle flashes

The muzzle flashes on the turrets in Area 51 render correctly however.

Broken depth on view models

Villa, Air Base and Crash Site have broken depth with the viewmodels, making them clip through the wall if you move up close.

Cleaning Bot in Investigation does not rotate.

issue2.mp4

It moves correctly, but it does not face where it's moving towards.

Unknown OpCode when entering third room in Sector 2 in Datadyne: Investigation

I'm getting an unknown op code when attempting to enter the third door in Sector 2 in Dayadyne: Investigation. Seems related to #30.

Here is my ini file:
pd.ini.txt

Datadyne: Defection Carpet Texture Broken

Probably known, but there's no issue open, so I'm opening one for it. The carpet texture in Datadyne: Defection seems to be corrupted in some way, looks like when you decode a texture the wrong way in the GoldenEye Setup Editor. There could be more things affected in this way, I just haven't found them.

How it looks in the port:

How it looks normally, in 1964 GEPD Edition:

Three-point filtering shouldn't be applied to some textures

When using TextureFilter=1, some objects like the distant buildings here still use nearest neighbour filtering.

This matches up with the original game running in an emulator, so that's not a problem. (Simple64/Parallel)

However, when using TextureFilter=2, those objects have three-point filtering applied, as well as the UI.

Scrolling through heads disrupts textures

Not a major one, but funny enough to point out. Scrolling through heads in the Character menu causes some of the UV maps to mess up. Only applies in the head menu, even tabbing down to bodies immediately corrects the issue in the preview window

[Feature request] Setting for antialiasing

Hi! Would it be possible to add options for hardware antialiasing? (i.e. multisampling AA and FSAA)

It's technically possible to force it from the GPU driver, but doing that breaks framebuffer effects.

No AA	MSAA	FSAA

Controller Sensitivity

I know it's early days but the controller especially looking with the right stick seems very sensitive. Is there any setting i can change? or just wait for things to mature, thanks.

Models are not affected by room darkness.

To reproduce, use the light switch in the first room on Defection, or load the start of Extraction.

Mouselook senstivity affected by zoom and crouch.

To reproduce: Use any item that grants the player zoom, or crouch. When they try looking around their sensitivity will be lowered, and when using 30x zoom, you can barely use the mouse (Easily done on Villa on Agent/Special Agent).

Multiplayer intro swirl camera sometimes jitters.

How to reproduce: Start a multiplayer match, and sometimes the camera swirl animation will jitter.

camera.jitter.mp4

Crash in Air Force One

How to reproduce: Play through Air Force One until you reach the cutscene, the game will then crash

Any specific reason why gcc -m32 isn't used for Linux?

In order to get it to build on my system I had to change the CFLAGS/CXXFLAGS/LDFLAGS to have -m32 in the string and deleted $(TOOLCHAIN) from CC and CXX, leaving them as gcc -std=c11 and g++ -std=c++20.

On Debian(and Ubuntu, I'm guessing), using gcc multilib, you can compile the 32-bit binary by using 64-bit gcc by simply adding -m32.

Is there some reason why the toolchain setup is complex? It results in a CC variable that is something like 'i686-linux-gnu-gcc' which is only available if you install a the 'i686-linux-gnu-gcc' package which breaks gcc-multilib.

Dedicated switch-back button

Tranquilizer weapon causing crash

In missions where there is an enemy that uses a tranquilizer or there is a psychosis gun in the world(Maian SOS) the game can crash. This may be two separate bugs but they both share a weapon model in common. In a recent livestream, Graslu00 implements a workaround by walking backwards into the psychosis gun to prevent it from appearing on screen, preventing the crash.

[Feature Request] Fix geomtery seams around portals.

There is noticeable seams around portals that will shift and create holes in the geometry depending on your view. This happens occasionally in GoldenEye when there's mismatches between room and portal geometry, but in Perfect Dark these seams are nearly everywhere.

I'm assuming this is caused by some sort of rounding/precision error with portal coords under https://github.com/fgsfdsfgs/perfect_dark/blob/8c9c0abee637fd0bb18dfec91fc6a007b3903a88/src/game/portalconv_c.c

Portal issue in Attack Ship

Just before you enter the bridge, the lift portal seems to break. It works when you enter the lift, but exiting makes the player fall into the void into the hangar below.

Video:
https://youtu.be/FFKq9rrbYps

Slow Audio Both SFX and Music

This one is probably known but didn't see an open issue for it so I am just dropping this here
All Music and SFX are crackly and appear to be running slow.

Crash after opening sequence

Getting a crash after loading into the Institute menu that I've narrowed down to having something to do with the radial menu section bondmove.c Line 1417 g_Vars.currentplayer->amdowntime = 0; in the radial menu in commit ffae454. Haven't been able to figure out how to actually debug the project so I'm not sure why this causes a crash, but when I comment it out, it stops crashing for me. Does anyone else get this crash?

Link to line
https://github.com/fgsfdsfgs/perfect_dark/blob/8c6d6df5fc396bef8ca393397296a9562b70683e/src/game/bondmove.c#L1417C45-L1417C45

Slider settings change too fast

Assuming this is related to switching to 60fps, slider settings(for example, the sliders in the Limits menu in combat simulator) move way too fast to reliably choose a desired setting.

I'm guessing if/when a mouse cursor is added this won't be too much of an issue, though.

Multiple issues with the CamSpy.

1. Portal rendering does not work correctly with the CamSpy, as they will be ignored if too close to the sides of the screen.

2. The CamSpy's rotation in the inventory is bugged, it will jitter and shake. In testing I saw this not happen with any other item but it may be a global issue.

CamSpyRot.mp4

3. Mouse look does not work with the CamSpy, you are stuck using the arrow keys to look left/right, hover up/down, and WASD to move it.

Stairs on Villa are broken

Some of the stairs on Villa do not allow the player to descend or ascend, notably the interior stairs. Exterior stairs seem to work fine in my testing.

Datadyne Extraction: Guard in the dark infinite shooting

Yes, this can happen. It does not happen every time, however. I recorded a clip of it happening here:

https://www.youtube.com/watch?v=2M2Aldp25Yk

Sorry for no sound but it should be very obvious.

The guard should shoot a bit in the dark but not indefinitely. He'll stop when you shoot him.

EDIT: Got it to happen somewhere else. I think it's triggered when the guards try to shoot you pre-emptively.

Crash looking down Defection elevator shaft

Got an unknown GBI opcode on the elevator after it started moving down towards the lobby. I was fooling around with some cheats at the same time, and have reliably replicated and narrowed it to looking down the shaft while holding the Phoenix. I wish I could provide more information of what command value it was trying to process but I'm unsure of how to read the stderr buffer or how to run this through a debugger.

How do I check for SDL2, libGL and ZLib on my system?

Title

Mouse and Keyboard controls not working when an XInput controller is connected before launch

If you have an Xinput controller connected to the computer before launching pd.exe, keyboard and mouse controls fail to work. Disconnecting the controller and restarting pd.exe fixes the issue. Not exactly an urgent issue but I should mention it in case someone else runs into the problem of their controls suddenly not working.

Some muzzle flashes are bugged

issue.mp4

This affects the Cycle, AR34, K7 Avenger, and AR54

Slow Motion/Combat Boost does not work.

To reproduce: Start a multiplayer match with the Slow Motion option enabled, or use the Combat Boost in Carrington Institute Defense. The game will run the same speed than slow down as intended.

[Feature Request] Possibility of switching to per-pixel dynamic lighting?

Currently, the game engine uses a rather weird room-based dynamic lighting system where the entire room lights up when firing weapons. Perhaps it would be better to just use OpenGL lights, ideally per-pixel for a better effect.

I don't know if graphics enhancements are being considered for this project but I have always thought that the dynamic lighting in PD(and GE) was held back because of the hardware constraints.

For clarification, I ONLY mean the lighting associated with gunfire or anything else that causes the room the light up such as explosions. The base game's map lighting is just fine the way it is. I just felt that the original dynamic lighting system was lacking.