Giter Site home page Giter Site logo

Comments (8)

fgsfdsfgs avatar fgsfdsfgs commented on September 16, 2024 1

It does actually support tri-point, though it incorrectly turns it on for all textures. You need to set TextureFilter=2 in the config. But I suspect the difference in filtering might explain some of the differences in envmap rendering.

from perfect_dark.

 avatar commented on September 16, 2024
envmap error

It looks like texture scale isn't being taken into consideration by the environment map effect. It's very noticeable on windows, and the desk at the start of Mr. Blonde's Revenge.

from perfect_dark.

Graslu avatar Graslu commented on September 16, 2024

Doors in Carrington Institute, Air Force One, all glass textures, Falcon 2... This applies to all models using the effect.

from perfect_dark.

fgsfdsfgs avatar fgsfdsfgs commented on September 16, 2024

This should now be at least partially fixed. Was due to a dumb copypaste mistake in the renderer.

from perfect_dark.

 avatar commented on September 16, 2024

The env map effect looks to be closer to emulation now. Can't tell if it's a match since of small differences in angles between the screenshots.
envmaps

from perfect_dark.

s-ilent avatar s-ilent commented on September 16, 2024

Yep, the brokenness is definitely fixed! And reflections seem to match up pretty closely now.

Emulation Port
pd_2023_08_22_12_25_29_583 simple64-gui_2023_08_22_12_25_29_594
pd_2023_08_22_12_38_04_513 simple64-gui_2023_08_22_12_38_04_507

The difference in the opening logos appearance is pretty strange, I wonder if it has anything to do with the altered FOV calculation? In fact, this comparison is a bit misleading because the emulation screenshots have a black border around them. However, in testing, the difference in the shading is visible regardless of whether the port is in widescreen or not.

Emulation Port
simple64-gui_2023_08_20_02_44_22_791 pd_2023_08_22_12_07_13_448
simple64-gui_2023_08_20_02_44_18_604 pd_2023_08_22_12_05_57_930
simple64-gui_2023_08_20_02_44_33_035 pd_2023_08_22_12_06_12_097

Maybe there's a bug to fix there, but the main problem is solved so feel free to close the issue.

from perfect_dark.

fgsfdsfgs avatar fgsfdsfgs commented on September 16, 2024

I guess I'll close this for now, it looks close enough at least.

from perfect_dark.

Calinou avatar Calinou commented on September 16, 2024

@s-ilent It appears you have your top screenshots mixed up, as the "emulation" ones use bilinear texture filtering while the "port" ones use tri-point filtering. However, this port only supports bilinear filtering right now.

(The emulated screenshots also have that slight letterboxing from the NTSC resolution.)

from perfect_dark.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.