fi-muni/pa165

PA165 repository

pa165's Issues

We shouldn't sometimes use TestExecutionListener

This annotation shouldn't be used in some tests @TestExecutionListeners(TransactionalTestExecutionListener.class)

Becuase if some tests do not commit transactions its hard to test manyToMany find.

For example tests such as Task03 test DAO without using this listener. But our other tests always use the listener.

Move first 3 seminars to Java 11

Implement REST API

If possible, shortly describe REST API architecture here https://docs.google.com/document/d/14PboCcH8nltP8KBVJaXrFcugHF3D80o-d4bQQwtN85M/edit

Chat about REST API here https://pa165.hipchat.com/chat/room/1740885

Do not use new Date()

Our services/daos should use our TimeService to get current date.

FacadeUtils should be Spring bean and should be injected as such

We shouldn't use 'new' for Dozer

Consider authentication via Google or FB, not by direct username/passwd form login

Just consider it, if it is too complicated or doesn't serve any purpose please communicate it back.

Sequence should be used and Tested instead of Identity

DAO tests can be used to test that resulting code works.

CurrencyRateUtils should be Spring bean

use logback instead if log4j

Service tests should not start Persistence Context

mainly because service tests only mock the dependencies!

use Joda Money

Code conventions

We have many places in code withe extremelly weird formatting. E.g. CategoryServiceImpl

    @Override public List<Category> findAll()
    {
        return categoryDao.findAll();
    }

Can you configure checkstyle maven plugin to catch these things?

UI wireframes

Should we prepare wireframes? E.g. using http://www.layoutit.com/build? If you think its a good idea I will be happy to brainstorm about them.

Enable exception translation

ChangeImage DTO should have imageMimeType

Consider JPAModel gen when using JPQL

Test Service Layer without mock objects

Just create a simple temporary TestNG test and try a few Facade methods.

Service Layer Security

We should use standard Java EE Security anotations. This task is not just implementation. You need to think about at least 2 roles in e-shop and come up with reasonable methods for each role.

Implement UI

If possible, comment briefly into https://docs.google.com/document/d/14PboCcH8nltP8KBVJaXrFcugHF3D80o-d4bQQwtN85M/edit with the Architecture

Finish Service Layer Methods

There are some TODO items in service layer that require new method implementations.

Disable hibernate logging in tests

Return Null on facade when entity is not available