fidmor89/slab_appinsights

Main-development-repository-for-Application-Insights-integration-with-Semantic-logging

slab_appinsights's Issues

Continuous integration and Unit Test should be implemented

The project is having some contributions, we need to implement robust unit tests to ensure the quality and a continuous integration for automating the nuget packaging.

License information not matching

Hi,

• top right it states MIT (the github setting) ?
• Readme states GPL
• License states MIT

Please unify :)

Do not call telemetryClient.Flush(); from the sink

Do not call telemetryClient.Flush(); from the sink Let channel manage buffering - it will do it more efficient if it will not need to initiate sending after every trace statement. If you need to call Flush - call it from the test application itself or implement destructor for the sink.

NullRef when one of the payload value is null

NullRef when one of the payload value is null

Do not modify TelemetryConfiguraiton.Active in sink constructor

Do not set TC.Active.InstrumentaitonKey from the Sink constructor. There may be many data collection modules configured for performance counters, dependencies, etc. Every telemetry module should use whatever default instrumentation key customer has set. Typically setting of default configuration will be made in platform-specific manner - reading from environment variable for Azure WebSite, from cscfg for Cloud Service, from ApplicationInsights.config or web.config for on-premesis web application, from app.config for windows form, etc. Data collection modules should respect the default instrumentation key and allow customer to change it in runtime.

Try to avoid using Context Initializers

The drawback of using context initializers is that they may not be properly initialized for all data colleciton NuGets. Use telemetry initializers instead. See this blog post for details.

Styling comments

1. Do not duplicate .gitignore in every folder - one on root level is enough
2. Do not push packages to repo. They will be restored anyway during compilation. Furthermore you have packages ignored in .gitignore
3. One root-level solution file with all projects will be handy
4. There are some code duplication between the main project and Test solution - context initializers and extensions are duplicated