fiestah/angular-money-directive

AngularJS directive to validate monetary inputs

angular-money-directive's Issues

input type=number suppresses angular form validation for min/max ranges

I understand in the README it says not to use type=number for the input, but why is this?

Directive does not support localization

When using different number formats (i.e. currency symbol) defined by angular locale the directive needs to reflect that visually and also allow those characters to be entered in the money field. Currently the directive is en-US and $ only (or other locales that overlap).

Allow all negative numbers

Is there a way to allow any and all negative numbers? I could set min="-9999999" but I'd rather be able to not set a minimum at all...

Update to Angular 1.3.x

Hi and thank you.

Can you please update the code to the design of Angular 1.3.x?

Use $validators for validation for instance.

Thank you.

Bug(?) when entering invalid char into a field with invalid value

• Enter some number which will is invalid. For example when min="2", max="10":

  123

• Press any invalid char, a letter for example l. The field gets cleared.

I would expect the invalid value 123 will not change.

Bug(?) when entering invalid char into a field with rounded value

• Enter some number which will be rounded:

  12.3456

• Press tab or click outside to leave the field. The value will be rounded:

  12.35

• Focus on the field and press any invalid char, a letter for example l. The previous, not rounded value is shown:

  12.3456.

I would expect the value 12.35 will not change.

Can you append how to use your directive in one example ?

Can you append how to use your directive in one example ?

<input type="money" ng-model="price" />

with this previous declaration :

var MainApp = angular.module('MainApp', ['fiestah.money']);

Best regards,
Stephane

onBlur has no impact on the entered string

[ x ] prevents alphanumeric characters
[ x ] prevents negatives when min=>1
[ ] autoformats string to ##.## onBlur

I am probably missing something obvious, but maybe this is a 'doc bug'.
Anything I can check before reading the code?

Always dirty

Thank you for your solution!

There is very big issue I think. If I put your directive to my input, angular form become dirty from the start.
Are you plan to fix this in nearest time, because I want to use your directive in my project?

Thank you.

Adding to bower

Do you have plans to add it to bower ? The name angular-money-directive is free there.

Model Update in Background to 0 causes input field to display a blank string

If the model is updated in the background (i.e. not by typing in the input field) to be zero (0), the input field then displays a blank string, instead of a properly formatted numeric number 0 (when 0 is supposed to be a valid value). If I type in a zero (0), then the input field displays the correctly formatted string.

Options are not dynamic

Hi and thank you.

I have a situation where I need to dynamically set min, max and precision, but right now the directive preserves the initial values it finds.

Thank you.

Precision is not optional

If precision is not set explicitly I always get NaN because of the round function

Comma separating number above thousand

when i enter number above thousand (100000.00) it is not adding the comma (,) to separate the numbers. i would like to have 100,000.00 rather than 100000.00

Minified version + sourcemap

Hello.

It would be great if the repo contained also minified version + source map.

Thank you.

Does not work with AngularJS 1.3.7

Directive does not seem to work with 1.3.7, but does work with 1.2.25

[email protected] on npm not found

Formatting issue on initial rendering

I have this:

<input type='text' precision='2' max='99999999999.99' min='0.01' ng-model='salary' />

The value in the model is 0.01. It is being displayed as 0 until you visit the field and tab out. This is due to ngModelCtrl.$render() not being called in the precision observe callback,

Input type="number"

Hi I am using your directive and i love it.

Is there any way to make it work with input type="number"?

It is particularly for mobile so that when the input field is in focus, it brings up the number key pad rather than text keyboard.

Optional RadixPoint

Input field blank unless i press '0' and i keep getting NaN on the model

Hi,

The demo looks great, however the directive does not work and I have 0 errors. If I type any number, the input field stays blank and if i type 0 it actually populates it. Typing 0 doesn't actually update it on the model or scope however typing anything else returns NaN. Im on angular 1.2.*(latest)

Any ideas?

Cheers

Non-numerics are still valid.

Love the directive, works great except whenever I press a non-numeric character twice in the field it is inputted into the field. Just a little bug, the ng-model is still the correct format however.

当输入框为空时，光标离开会出现null

改进：将三个return null; 改为 return ;

Strict DI Error

Directive definitions do not follow the minification guildelines:

.directive('money', function($parse) { ... })

Should be

.directive('money', ['$parse', function($parse) { ... }])

Can you please fix?

Directive only works when not minified

The directive's module can no longer be loaded after code is minified. I did not see an $inject array with string parameters for your injection.

See here: https://docs.angularjs.org/tutorial/step_05#a-note-on-minification

Money directive is break with angularjs 1.2.18

working on it.

How to disallow plus sign within the text box ?

Hi,
I'm able enter + sign within the text box, How can i avoid this ?
Example : +444.22

First i will enter a number like 444.22 and then i can add + symbol at the beginning of the text box.