figo-connect/ios-sdk

iOS SDK

ios-sdk's Issues

Swift 4.2 Compatibility

As the title suggests, I am using the latest Swift version in a project I started today and I'm looking into using this iOS SDK. Sadly the current version is Swift 3, so I updated it to Swift 4.2 and opened a new PR: #14

Error on retrieveTransactions from Demo Account

Hi, I am getting this error when retrieving the transactions from the demo account.
The method used is :

func retrieveTransactions(_ parameters: RetrieveTransactionsParameters = RetrieveTransactionsParameters(), _ completionHandler: @escaping (FigoResult<TransactionListEnvelope>) -> Void)

[UnboxError] An error occured while unboxing path "value_date": Invalid value () for key "value_date".

Broken SDK, Issue when getting supportedBanks

Hey guys, thanks for the amazing SDK.
Unfortunately I found a bug :(

Currently I am calling the retrieveSupportedBanks and as a response I am getting a failure back.
It says:
[Unbox error] Invalid value < the entire json output. A lot of banks here> for key banks

Can you please check into this?

Thanks,
Perjan

Cannot Login with Demo Account

I am trying to login with the demo account, but it can't.
Two weeks ago it was fine. I didn't change anything from my side...

It is throwing an error which says "Abgebrochen".

[Question] swift3 support

Hi, we are thinking about using this SDK in our application. Is this project still alive? Will it be ready for swift3 when it comes out of beta in the fall?

Problems when retrieving transactions

Hi, I had the following issue:

When I tried to retrieve transactions using the figo-swift-sdk I got an unboxing error.

figo.retrieveTransactionsForAccount(account.accountId!, parameters: parameters) { result in switch result { case .Success(let envelope): print("Retrieved \(envelope.transactions.count) transactions") break case .Failure(let error): print(error) break } } }

I found a workaround by making the changes show in the attached screenshot.

The API seems to send PaymentTypes, which are not defined in the Enum PaymentType

`
public enum PaymentType: String, UnboxableEnum {
case Unknown
case Transfer
case DirectDebit = "Direct debit"
case SEPATransfer = "SEPA transfer"
case SEPADirectDebit = "SEPA direct debit"
case Interest = "interest"
case Charges
case ATM
case GeldKarte
case Rent = "rent"
case StandingOrder = "Standing order"
case ElectronicCash = "Electronic cash"
case SEPAStandingOrder = "SEPA standing order"
case ModifySEPAStandingOrder = "Modify SEPA standing order"

static func unboxFallbackValue() -> PaymentType {
    return .Unknown
}   

}`

The function unboxFallbackValue() didn't work for me.

Error when retrieving transactions

Hello,

I've two problems when retrieving the transactions from an account.

First Problem: I want to set the parameters, but Xcode gives the following error when creating the parameters like this:var params = RetrieveTransactionsParameters()
Warning: RetrieveTransactionsParameters cannot be constructed because it has no accessible initializers

Second Problem:
If load the transactions with the default parameters it is not successful, I get the following result:
FAILURE: [Unbox error] Invalid value (( { "account_id" = "XXX"; "account_number" = XXX; amount = "-XXX"; "bank_code" = XXX; "bank_name" = "XXX"; booked = XXX; "booking_date" = "XXX"; "booking_text" = "XXX"; "creation_timestamp" = "XXX"; currency = EUR; "modification_timestamp" = "XXX"; name = "XXX"; purpose = "XXX"; "transaction_code" = 5; "transaction_id" = "XXX"; type = "XXX"; "value_date" = "XXX"; visited = 0; }, { ... }, { ... } )) for key (transactions)

I hope somebody can help with this problems.

Crash trying to force unwrap refresh token

When I login using the method

figo.loginWithUsername("username", password: "password", clientID: "clientId", clientSecret: "clientSecret"

the app crashes at AuthorizationEndpoints.swift line:37 trying to force unwrap the refreshToken, which is nil. I've edited the code to return the access token instead

//...
completionHandler(Result.Success(authorization.accessToken))
//...

and all seems to work fine.

Please let me know if you will be actively developing the sdk in the future and fixing these issues. We are currently in prototyping stage, so we are ok with integrating the figo ios sdk sourcecode directly and fixing some issues. However, we need to see some promise in figo before using it for a production app. Even the basic example let figo = FigoClient() from your readme doesnt compile, which makes this whole sdk look questionable.

submitPayment returns error "Invalid scope"

Hello guys,
I am having an issue submitting a payment. I am trying to submit a demo payment with the demo account provided by you.

Steps:

1. I call createPayment(_ parameters: CreatePaymentParameters, _ completionHandler: @escaping (FigoResult<Payment>) -> Void)
2. I get a Payment object back
3. I pass that object and the tanSchemeID = "111111" to submitPayment(_ payment: Payment, tanSchemeID: String, pinHandler: @escaping PinResponder, challengeHandler: @escaping ChallengeResponder, _ completionHandler: @escaping VoidCompletionHandler)

After that I get the error "Invalid scope" with the code "90000"

What am I doing wrong?
Maybe the tanSchemeID is wrong?

Thanks in advance.