Giter Site home page Giter Site logo

filejet-bundle's Issues

bug: invalid asset url when mutation is empty and auto mode is on

https://github.com/filejet/filejet-bundle/blob/master/src/Twig/FileJetExtension.php#L40

public function getAsset(string $path, string $mutation = null): string
    {
        $mutation = empty($mutation) ? '' : "/${mutation}";
        $mutation .= $this->config->isAutoMode() ? ',auto' : '';
        $originPath = urlencode("{$this->config->getBaseUrl()}{$path}");

        return "{$this->config->getPublicUrl()}/ext{$mutation}?src={$originPath}";
    }

should looks like e.g

public function getAsset(string $path, string $mutation = null): string
    {
        $parts = [];

        if($mutation) {
            $parts[] = $mutation;
        }

        if($this->config->isAutoMode()) {
            $parts[] = 'auto';
        }

        $finalMutation = !empty($parts) ? "/" . implode(',', $parts) : '';
        $originPath = urlencode("{$this->config->getBaseUrl()}{$path}");

        return "{$this->config->getPublicUrl()}/ext{$finalMutation}?src={$originPath}";
    }

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.