filipenos/gaesdk

Google App Engine SDK Manager

gaesdk's Issues

Lazy load version detection as it issues HTTP request

Instead of loading a remote URL at init(), this should be done after parsing the arguments, as the default version is overwrittern by user using the --version flag.

Also, there can be some problems in doing HTTP requests at init(), as it should in theory, be as low as possible work on that function.

The extraction process is verbose by default

The output shows up all unpacking activity. This is nice locally, but if you are doing it from the Cloud Shell or any other remote SSH connection, this can be a problem. It would be nice to be able to make it quiet, either by default (my recommendation) and enable a --verbose|-v flag, or implement the --quiet|-q flag, so minimal output is displayed.

Thanks!

Use ioutil.Tempfile() or similar to perform the temporary download

Not only the current implementation poses a small risk to overwrite a user file, it has a temporary directory hardcoded, so that may not be desirable if the user has made a change.

See here: https://golang.org/pkg/io/ioutil/#TempFile

Allow an specific SDK runtime to be specified when downloading

This is a nice handy little tool! It would be nice to be able to also update/install the other runtimes, i.e., a flag like --runtime java|php|python|go would be very cool to have.

BUG: the extracted SDK may not work at all

The problem with the current aproach is that it is not deterministic in terms of file extraction ordering, and the extracted SDK file attributes (such as modification time) are not kept. Either you should keep them, or you should make sure that the extracted goroot folder has the higher mtimes. Otherwise, when running programs such as goapp will throw some build failures due to missing sources.

My suggestion, attempt to keep the mtime attribute, or follow the file ordering from the zip structure. Using the filepath.walk does not guarantee any ordering as it does the process concurrently, and ordering in this particular case is important.