fill1890/fabsit

Fabric sit mod for Minecraft

fabsit's Issues

no check for repeated /sit, /lay, /spin

Repeated usage of /sit, /lay, /spin will clip the player underneath the block they're standing on.

suggestion -- There should be an error message telling the player that they're already sitting/laying down etc. so they can't execute the commands again.

[Bug] Cannot hear users in voice chat when spinning/laying

Not sure if this goes to you or the Simple Voice Chat creator, but I think it might be for you.

Minecraft version:
Minecraft 1.19

Mod Version:
fabric-api-0.56.0+1.19.jar
fabsit-1.4.1+1.19.jar
voicechat-fabric-1.19-2.2.52.jar

Description of the issue:
When a player is laying or spinning, other players are unable to hear them through Simple Voice Chat. Sitting works perfectly fine but spinning and laying does not.

[BUG] Invisible armorstand or duplicate player model

an invisible armor stand or a player model stays in place when a player disconnects while sitting or laying

.

Перевод

Здравствуйте, я бы хотел поменять язык. Как - мне это сделать?

Update to 1.20.1?

Backporting

1.18.2

others

fabsit crash on 1.19.2

https://mclo.gs/M3dLtxo

1.19.4

Please add support for version 1.19.4

Sit on players

1.19.3 not supported

server crashes on load if server is on 1.19.3

Block centering and stair clicking

• Right-click a slab or stair to sit on it
• Centre on a block when posing

More poses

• crawl
• flare

/lay and /spin command error in 1.19.2. Sit works.

https://mclo.gs/7eAlvcS

1.19.3?

Client extensions

• Custom keybinds
• Hide horse hearts

/lay head yaw incorrect

Angle is sometimes wrong

Might just need to perform a 256/360 division

Changes player size during emote for origins.

As an inchling from the origins mod the spin and lay emotes cause the player to become normal sized, and also remain normal size for other players until relog.

player invis not working

for /lay and /spin, the original player's model does not turn invisible like it should.
this is on the latest 1.19 version for fabric

1.19.3 beta bug

When install on both client and server the mod will sit you down the block below the block you are standing on

Its like you sit twice

Failure to pose at the same XYZ position multiple times

Description

Attempting to sit in the same block multiple times- as in sitting, shifting to leave, then sitting again -will lead to the incorrect error of "Someone is already sitting here!" when nobody is sitting there. Presumably, this is caused by the Shift event not actually removing the player from that pose in memory.

Solution

The simplest solution to fixing the bug is removing the player's pose on that XYZ block from how you store it in memory. Though, what I believe to be the correct solution to this issue is to have a dictionary/hashmap of the player's GUID and the XYZ position they're in. This way, the player can only be in one pose at a time preventing "ghost poses" of what we're experiencing now.

Notes

Possibly caused by #8? Depending on the complexity of your mod, I might submit an untested PR.

/sit, /lay or /spin not working under certain conditions

Hey there! Been using this mod for a few months on an SMP, but I've encountered an issue with it:
doing any of the commands doesn't work in certain cases - e.g. when under a stair roof. Atleast that's the only common factor I've been able to find..
There's no console error, no config options affect it (tried most of those). Any ideas?
Using Fabric 1.19.2 with latest FabricAPI and FabSit