Giter Site home page Giter Site logo

filoghost / holographicdisplays Goto Github PK

View Code? Open in Web Editor NEW
366.0 19.0 201.0 3.85 MB

Create modern looking holograms in Minecraft.

Home Page: https://dev.bukkit.org/projects/holographic-displays

License: GNU General Public License v3.0

Java 100.00%
java minecraft bukkit spigot bukkit-plugin spigot-plugin

holographicdisplays's Issues

BungeeCord - Chest Commands

Hello,
I would've if you could add to chestcommands for bungeeCord MOTD, and how many players are on a particular server.

I thank you in advance for your answer

Variables

Hey, I saw on one server they displayed user's balance and the baltop from Essentials economy. I can't seem to replicate this, is it in Essentials/Holographic Displays or is it a third party addon?

Not work on 1.7.10

Hi,

The plugin not work on 1.7.10/1.8.
None error in console and when try to add a holographic texte doesn't work.

Issue with BungeeCord variables

  • '&f&l&oHC Factions: {status: factions}'
  • '&a{online: factions}/300'

I use those two lines for displays and the config is setup properly.

When i start my server, while the server is loading plugins, the display goes from Offline to Online, however, once its done loading the plugins and the server can be logged into, it goes back to Offline even though the server is now online.

Im running the latest version of spigot 1.8.8

[API] Add some hide/show methods.

Hey,

I did not found a way to "hide" holograms and "show" them at a later state. I would like to see a methode like hologram.hide() and hologram.show() to hide & show holograms. Like, make them invisible/remove them.

Currently I'm deleting the hologram, creating it at a later state. But its just not a good way to re-add it, add all lines etc.
I would like to see a method, to hide the hologram, and show it at a later state.

Performance Issue in EntityNMSArmorStand.getId()

https://gyazo.com/9799947dc733f746a41e753e510ad2f9

9b539eb#diff-f20cadd857d669eb531ee495e6d3d16bR115

Getting the stack trace at that line causes lag spikes according to my in development lag cause detector plugin MassiveLag.

Solution Suggestions:

HolographicDisplays load after TouchscreenHolograms

[17:16:51] [Server thread/INFO]: [TouchscreenHolograms] Enabling TouchscreenHolograms v1.3.2
[17:16:51] [Server thread/INFO]:


 TouchscreenHolograms requires the plugin
 HolographicDisplays v2+ enabled to run.
 This plugin will be disabled.

[17:16:56] [Server thread/INFO]: [TouchscreenHolograms] Disabling TouchscreenHolograms v1.3.2
[17:16:56] [Server thread/INFO]: [HolographicDisplays] Enabling HolographicDisplays v2.2.4
[17:16:56] [Server thread/INFO]: [HolographicDisplays] Found ProtocolLib, using new version.
[17:16:56] [Server thread/INFO]: [HolographicDisplays] Enabled player relative placeholders with ProtocolLib.

Holographic Displays giving lots of Error's

Here is the error it only occurs when I spawn into a location where there is Holographic displays

Error below

20:18:50 ERROR: [HolographicDisplays] Unhandled exception occured in onPacketSending(PacketEvent) for HolographicDisplays
java.lang.NoClassDefFoundError: Could not initialize class com.comphenix.protocol.wrappers.WrappedDataWatcher$WrappedDataWatcherObject
at com.comphenix.protocol.wrappers.WrappedWatchableObject.getWatcherObject(WrappedWatchableObject.java:73) ~[ProtocolLib.jar:4.0.2-b303]
at com.comphenix.protocol.wrappers.WrappedWatchableObject.getIndex(WrappedWatchableObject.java:81) ~[ProtocolLib.jar:4.0.2-b303]
at com.gmail.filoghost.holographicdisplays.bridge.protocollib.pre1_9.ProtocolLibHookImpl$1.onPacketSending(ProtocolLibHookImpl.java:157) ~[HolographicDisplays.jar:?]
at com.comphenix.protocol.injector.SortedPacketListenerList.invokeSendingListener(SortedPacketListenerList.java:195) [ProtocolLib.jar:4.0.2-b303]
at com.comphenix.protocol.injector.SortedPacketListenerList.invokePacketSending(SortedPacketListenerList.java:149) [ProtocolLib.jar:4.0.2-b303]
at com.comphenix.protocol.injector.PacketFilterManager.handlePacket(PacketFilterManager.java:608) [ProtocolLib.jar:4.0.2-b303]
at com.comphenix.protocol.injector.PacketFilterManager.invokePacketSending(PacketFilterManager.java:584) [ProtocolLib.jar:4.0.2-b303]
at com.comphenix.protocol.injector.netty.ProtocolInjector.packetQueued(ProtocolInjector.java:309) [ProtocolLib.jar:4.0.2-b303]
at com.comphenix.protocol.injector.netty.ProtocolInjector.onPacketSending(ProtocolInjector.java:269) [ProtocolLib.jar:4.0.2-b303]
at com.comphenix.protocol.injector.netty.ChannelInjector.processSending(ChannelInjector.java:396) [ProtocolLib.jar:4.0.2-b303]
at com.comphenix.protocol.injector.netty.ChannelInjector.access$500(ChannelInjector.java:77) [ProtocolLib.jar:4.0.2-b303]
at com.comphenix.protocol.injector.netty.ChannelInjector$5.handleScheduled(ChannelInjector.java:362) [ProtocolLib.jar:4.0.2-b303]
at com.comphenix.protocol.injector.netty.ChannelInjector$5.onMessageScheduled(ChannelInjector.java:330) [ProtocolLib.jar:4.0.2-b303]
at com.comphenix.protocol.injector.netty.ChannelProxy$2.schedulingRunnable(ChannelProxy.java:127) [ProtocolLib.jar:4.0.2-b303]
at com.comphenix.protocol.injector.netty.EventLoopProxy.execute(EventLoopProxy.java:95) [ProtocolLib.jar:4.0.2-b303]
at net.minecraft.server.v1_8_R1.NetworkManager.a(NetworkManager.java:140) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at net.minecraft.server.v1_8_R1.NetworkManager.handle(NetworkManager.java:101) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at net.minecraft.server.v1_8_R1.PlayerConnection.sendPacket(PlayerConnection.java:868) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at net.minecraft.server.v1_8_R1.EntityTrackerEntry.updatePlayer(EntityTrackerEntry.java:330) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at net.minecraft.server.v1_8_R1.EntityTracker.updatePlayers(EntityTracker.java:176) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at net.minecraft.server.v1_8_R1.MinecraftServer.z(MinecraftServer.java:789) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at net.minecraft.server.v1_8_R1.DedicatedServer.z(DedicatedServer.java:316) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at net.minecraft.server.v1_8_R1.MinecraftServer.y(MinecraftServer.java:634) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at net.minecraft.server.v1_8_R1.MinecraftServer.run(MinecraftServer.java:537) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_91]

net.minecraft.server.v1_8_R1.PacketPlayOutEntityMetadata@4f8016[
a=186
b=[net.minecraft.server.v1_8_R1.WatchableObject@e38860, net.minecraft.server.v1_8_R1.WatchableObject@1e95eb, net.minecraft.server.v1_8_R1.WatchableObject@1774dbc, net.minecraft.server.v1_8_R1.WatchableObject@1b9f6c2, net.minecraft.server.v1_8_R1.WatchableObject@125d31d, net.minecraft.server.v1_8_R1.WatchableObject@10aa59f, net.minecraft.server.v1_8_R1.WatchableObject@2b0bef, net.minecraft.server.v1_8_R1.WatchableObject@82fcce, net.minecraft.server.v1_8_R1.WatchableObject@1447038, net.minecraft.server.v1_8_R1.WatchableObject@1fc0e52, net.minecraft.server.v1_8_R1.WatchableObject@1201fb1, net.minecraft.server.v1_8_R1.WatchableObject@5f497, net.minecraft.server.v1_8_R1.WatchableObject@ce8a5f, net.minecraft.server.v1_8_R1.WatchableObject@113900a, net.minecraft.server.v1_8_R1.WatchableObject@d5dace, net.minecraft.server.v1_8_R1.WatchableObject@101348f]

Option to use WitherSkull instead Armor stand.

please, can you give that option? because, i can't see the holograms using 1.7 client.
my server is using Spigot 1.8.3 with ProtocolSupport to allow older version join to the server.

MC 1.12 Support

@filoghost Heads up, HolographicsDisplay seems to need an update to support loading into 1.12.

[23:00:07] [Server thread/INFO]: [HolographicDisplays] Enabling HolographicDisplays v2.2.5
[23:00:07] [Server thread/INFO]: 
 
******************************************************
     This version of HolographicDisplays only
     works on server versions from 1.7 to 1.11.
     The plugin will be disabled.
******************************************************

HolographicDisplays lag Timings

Hi,
I don't understand why HolographicDisplays get :
0.00% 816.11% 0.41 s 408.06 ms 0.0 0.0k Task:StartupLoadHologramsTask(Single)
My timings : http://timings.aikar.co/?url=11501230

Server version : version git-Spigot-870264a-0a645a2 (MC: 1.8.3) (Implementing API version 1.8.3-R0.1-SNAPSHOT)
HolographicDisplays version : 2.1.10

Thank you,

Moves wrongly on Hologram.teleport()

When using 'teleport(Location)', the hologram moves more than that location. (sorry for my bad english)
For example, when moving hologram from (0, 0, 0) to (1, 0, 0), it teleports to (2, 0, 0).
This only happens above v2.2.4. Thanks.

Misconfigured updater system.

[18:50:59] [Server thread/INFO]: [HolographicDisplays] Enabling HolographicDisplays v2.2.3
[18:50:59] [Server thread/INFO]: [HolographicDisplays] Found ProtocolLib, using new version.
[18:50:59] [Server thread/INFO]: [HolographicDisplays] Enabled player relative placeholders with ProtocolLib.
[18:50:59] [Thread-13/WARN]: [HolographicDisplays] The author of this plugin has misconfigured the Updater system.
[18:50:59] [Thread-13/WARN]: [HolographicDisplays] The project ID (75097) provided for updating is invalid.
[18:50:59] [Thread-13/WARN]: [HolographicDisplays] Please notify the author of this error.

How to build

Hi @filoghost
I was just trying to build your repository for checking compatibility with BedwarsRel plugin, since you have not updated the plugin on Bukkit so far. How can this project be built? Are you using Maven, or Ant, or … ? Since I cannot find any build files...

Floating items dont work!

When i do /hd addline shop item:339 it does not work it just adds a line saying item:339 you said you support items but it appears you dont

Individual holograms become armor stands to other players

So I create a hologram:
Hologram hologram = HologramsAPI.createHologram(this, location);
I then show the hologram to player P:
VisibilityManager vm = hologram.getVisibilityManager(); vm.showTo(P); vm.setVisibleByDefault(false);

If then another player joins (who has his own hologram on the same location), he sees a stack of armor stands with a floating stone block on top.
2016-11-26_16 16 07

Register a new Placeholder

Hi,

I need to register a new Placeholder, in your wiki was this under todo.
Can you give me a short tutorial, how to do this?

Error message in v2.1.11

Message: Detected development version of ProtocolLib, support disabled. Related functions (the placeholders {player} {displayname} and the visibility API) will not work. The reason is that this version of ProtocolLib is unstable and partly broken. A new version of Holographic Displays will be out when ProtocolLib gets fixed.

HD: v2.1.11
ProtocolLib: v3.7-SNAPSHOT-b249
Spigot: git-Spigot-bc01c3a-935349e (MC: 1.9), 0 versions behind

Everything seems to be working with ProtocolLib.

1.10 Support

[01:30:42] [Server thread/INFO]: [HolographicDisplays] Enabling HolographicDisplays v2.1.13
[01:30:42] [Server thread/INFO]: 

******************************************************
     This version of HolographicDisplays can
     only work on these server versions:
     from 1.6.4 to 1.9.4.
     The plugin will be disabled.
******************************************************

ChunkLoadEvent error

I reported that bug also on bukkit, here is it:
[11:11:20] [Thread-316470/ERROR]: Could not pass event ChunkLoadEvent to HolographicDisplays v2.2.3 org.bukkit.event.EventException at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot.jar:git-Spigot-b32c8f8-46226d6] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot.jar:git-Spigot-b32c8f8-46226d6] at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot.jar:git-Spigot-b32c8f8-46226d6] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [spigot.jar:git-Spigot-b32c8f8-46226d6] at net.minecraft.server.v1_11_R1.Chunk.loadNearby(Chunk.java:910) [spigot.jar:git-Spigot-b32c8f8-46226d6] at org.bukkit.craftbukkit.v1_11_R1.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:53) [spigot.jar:git-Spigot-b32c8f8-46226d6] at org.bukkit.craftbukkit.v1_11_R1.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:1) [spigot.jar:git-Spigot-b32c8f8-46226d6] at org.bukkit.craftbukkit.v1_11_R1.util.AsynchronousExecutor.skipQueue(AsynchronousExecutor.java:337) [spigot.jar:git-Spigot-b32c8f8-46226d6] at org.bukkit.craftbukkit.v1_11_R1.util.AsynchronousExecutor.getSkipQueue(AsynchronousExecutor.java:295) [spigot.jar:git-Spigot-b32c8f8-46226d6] at org.bukkit.craftbukkit.v1_11_R1.chunkio.ChunkIOExecutor.syncChunkLoad(ChunkIOExecutor.java:16) [spigot.jar:git-Spigot-b32c8f8-46226d6] at net.minecraft.server.v1_11_R1.ChunkProviderServer.getChunkAt(ChunkProviderServer.java:137) [spigot.jar:git-Spigot-b32c8f8-46226d6] at net.minecraft.server.v1_11_R1.ChunkProviderServer.getChunkAt(ChunkProviderServer.java:120) [spigot.jar:git-Spigot-b32c8f8-46226d6] at net.minecraft.server.v1_11_R1.ChunkProviderServer.getChunkAt(ChunkProviderServer.java:116) [spigot.jar:git-Spigot-b32c8f8-46226d6] at org.bukkit.craftbukkit.v1_11_R1.CraftWorld.getChunkAt(CraftWorld.java:131) [spigot.jar:git-Spigot-b32c8f8-46226d6] at org.bukkit.craftbukkit.v1_11_R1.CraftWorld.getBlockAt(CraftWorld.java:95) [spigot.jar:git-Spigot-b32c8f8-46226d6] at org.bukkit.craftbukkit.v1_11_R1.CraftWorld.getBlockAt(CraftWorld.java:561) [spigot.jar:git-Spigot-b32c8f8-46226d6] at org.bukkit.Location.getBlock(Location.java:87) [spigot.jar:git-Spigot-b32c8f8-46226d6] at tw.mics.spigot.plugin.nomoreesp.runnable.CheckXRayRunnable.run(CheckXRayRunnable.java:48) [NoMoreESP.jar:?] at java.lang.Thread.run(Thread.java:745) [?:1.8.0_111] Caused by: java.lang.IllegalArgumentException: Async entity add at com.gmail.filoghost.holographicdisplays.util.Validator.isTrue(Validator.java:13) ~[?:?] at com.gmail.filoghost.holographicdisplays.nms.v1_11_R1.NmsManagerImpl.addEntityToWorld(NmsManagerImpl.java:101) ~[?:?] at com.gmail.filoghost.holographicdisplays.nms.v1_11_R1.NmsManagerImpl.spawnNMSArmorStand(NmsManagerImpl.java:94) ~[?:?] at com.gmail.filoghost.holographicdisplays.object.line.CraftTextLine.spawn(CraftTextLine.java:75) ~[?:?] at com.gmail.filoghost.holographicdisplays.object.CraftHologram.spawnEntities(CraftHologram.java:300) ~[?:?] at com.gmail.filoghost.holographicdisplays.object.NamedHologramManager.onChunkLoad(NamedHologramManager.java:49) ~[?:?] at com.gmail.filoghost.holographicdisplays.listener.MainListener.onChunkLoad(MainListener.java:63) ~[?:?] at sun.reflect.GeneratedMethodAccessor64.invoke(Unknown Source) ~[?:?] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_111] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_111] at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:302) ~[spigot.jar:git-Spigot-b32c8f8-46226d6] ... 18 more

Maven

You should put this on a Maven repository so we can easily add it to our maven project.

Add setLine and getLines for Hologram in API.

First I want to thank you for your work in this plugin, it's terrific. I just hope you can add more methods in Hologram class, in the API.

Currently I think I can't get all lines of a hologram (as a List or something else), that's kind of annoying. And I don't know how to use getLine(int i) to get the text of this line.

And it will be better if there is a setLine(int i, String text) method, currently I can only use removeLine then insertTextLine.

ChestCommands=BungeeCord

Hello,
I'd like you to join Bungee Cord with your plugin ChestCommands. I'd like to go motd witch you should visit a number of players on a particular server. I changed the item will need to play a minigame. When the lobby will have the necessary blue wave and he'll be in the game and that wave will be red. I'd like to tan item varied by color. Like if Lobby will be blue and the necessary wave of change to the blue wave

Holograms Disappearing

Since updating to Minecraf/Spigot 1.9.4 we have encountered an issue where Holograms around our spawn will all disappear randomly. We have found that by going to another world (and/or unloading the chunks around spawn) then back to the spawn causes them to re-appear. Am I the only one with this issue, we are using the Touchscreen Holograms plugin, however have been using that before updating to 1.9.4 and didn't seem to notice this issue.

Placeholders API

Hello,

Could you allow the PlaceholderReplacer's update method to pass the Hologram object? Or somehow get the Hologram that its being used on? This way we can make placeholders that work with the location.

Slime entity no longer working due to override of slimeHolographicDisplays

Hi,

your NMS code breaks the slime spawner or any other plugin relying on EntityTypes.b (RegistryMaterials of MinecraftKey and EntityClass), since you are overwriting the existing entry with the ID 55 (which is Slime).
Could you instead register an ID that was previously null? There are many IDs not yet used, since NMS breaks anyways you should be safe to use a non-existing ID.

See: https://github.com/filoghost/HolographicDisplays/blob/master/HolographicDisplays/Plugin/com/gmail/filoghost/holographicdisplays/nms/v1_11_R1/NmsManagerImpl.java#L43

Thanks,
Tim

HologramsAPI

Holograms with an ItemLine do not disappear if I use the hologram.delete(); method. Holograms with TextLine only do disappear.

Holograms don't hide

Hej
I use this code:
`Hologram hologram = HologramsAPI.createHologram(plugin, plugin.getLocation("HOLOGRAM"));
VisibilityManager visibilityManager = hologram.getVisibilityManager();

            visibilityManager.showTo(p);
            visibilityManager.setVisibleByDefault(false);

            ItemStack is = new ItemStack(Material.SKULL_ITEM, 1, (short)3);
            SkullMeta sm = (SkullMeta) is.getItemMeta();
            sm.setOwner(p.getName());
            is.setItemMeta(sm);

            hologram.appendItemLine(is);
            hologram.appendTextLine("§7» §6§lStats §7«");
            hologram.appendTextLine("§7↠ §9gespielte Spiele: §c" + plugin.getMySQLStats().getPlayed(p.getUniqueId().toString()));
            hologram.appendTextLine("§7↠ §9gewonnene Spiele: §c" + plugin.getMySQLStats().getWins(p.getUniqueId().toString()));
            hologram.appendTextLine("§7↠ §9deaktivierte Energiekerne: §c" + plugin.getMySQLStats().getDisabled(p.getUniqueId().toString()));
            hologram.appendTextLine("§7↠ §9Kills: §c" + plugin.getMySQLStats().getKills(p.getUniqueId().toString()));
            hologram.appendTextLine("§7↠ §9Tode: §c" + plugin.getMySQLStats().getDeaths(p.getUniqueId().toString()));
            hologram.appendTextLine("§7↠ §9Punkte: §c" + plugin.getMySQLStats().getPoints(p.getUniqueId().toString()));
            `

If a new player joins, both players see both holograms. But when I used isVisibleTo it says they can only see one of them!
Version: 1.10

Sorry for my bad English, I am from Germany!

Placeholders

Placeholders are pretty inefficient in a lot of ways.
First of all it isn't possible to register a placeholder after server startup. While trying this, the newly added placeholder does not get replaced.

Second of all, all placeholder result values are getting requested constantly, even if there's no active hologram with that placeholder.

1.11.2

Hello my darling, obviously with a new minecraft/server version this plugin needs to be patched for it. Any update would be fantastic.
Thank you,
Your one and only love

registerPlaceholder method API

Hello filoghost, I have an issue registerPlaceholder allows to create a new placeholder like %playername% ?
so How I can use it to create a placeholder for example %faction% I have method myfaction.getfactioname(Player p) that returns a string. I want to avoid individual holograms

HologramsAPI.registerPlaceholder(plugin, textPlaceholder, refreshRate, replacer)

Thanks in advance.

Fastcraft 1.22 Makes Holograms Not Appear

As the title says, with fastcraft 1.22, holograms decide not to appear. I assume this has to do with both Fastcraft and holographic displays and how the nameplates are made. I know you dont really support 1.7.10 anymore, but it would be appreciated if you could at least give some insight on this and I can hire someone tor resolve this for my network.

Many thanks, Zendrex

Fastcraft Page: http://forum.industrial-craft.net/index.php?page=Thread&threadID=10820

Make PluginHologramManager use HashSet

Is there any reason why PluginHologramManager uses an ArrayList instead of a HashSet to store the PluginHolograms?

When you have 5000+ holograms with new ones constantly being removed and created, the ArrayList becomes quite the bottleneck

Update API Download

Hi there,

I wasn't sure where to ask this but I ended up deciding here would be alright. All I wanted to ask was if it would be possible if you could please update the HolographicDisplays API download? The current download is 2.1.3 which is not the latest version. Thanks in advance.

Regards,
ShadowRanger

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.