Giter Site home page Giter Site logo

SFZ3Mix, Samples in Netplay about fbneo HOT 11 CLOSED

sfz3mix avatar sfz3mix commented on September 25, 2024
SFZ3Mix, Samples in Netplay

from fbneo.

Comments (11)

 avatar commented on September 25, 2024

does it work with regular FBNeo ? win32/win64

from fbneo.

dinkc64 avatar dinkc64 commented on September 25, 2024

its probably an issue of one side using samples and other side not using samples, and when retroblarch syncs the states they don't match size-wise, will look into a possible solution soon.

from fbneo.

sfz3mix avatar sfz3mix commented on September 25, 2024

Yes, that's probably dinkc64. Thanks for your support.

from fbneo.

barbudreadmon avatar barbudreadmon commented on September 25, 2024

@dinkc64 maybe the following would do the trick

   	if (Cps2Turbo && ~nAction & ACB_NET_OPT) {
   		BurnSampleScan(nAction, pnMin);
   	}

?

It should fix the size issue, however i'm not entirely sure if playback will work properly for the player with samples.

I can think of either that or initing "mute" samples when the real ones are missing.

from fbneo.

sfz3mix avatar sfz3mix commented on September 25, 2024

I've solved some problems this way by also playing empty.wav (mute sound) when there's no sound with the correct id.
Remember that in this case there will be nothing for those who don't use the samples folder.

from fbneo.

dinkc64 avatar dinkc64 commented on September 25, 2024

Added a potential fix for this, please give it a try:
66b3d4e

best regards,

  • dink

from fbneo.

sfz3mix avatar sfz3mix commented on September 25, 2024

Hello, FBNeo team,
I opened a room on Retroarch and I couldn't connect when one person was using samples and the other was not. The message appears (Disconnected from NetPlay). It only worked when both were using samples or not.
It would be good if it worked with or without samples for both parties.

from fbneo.

barbudreadmon avatar barbudreadmon commented on September 25, 2024

The libretro fork isn't synced after every single commit, and i haven't synced this particular commit yet (i'll do that asap).
Even after syncing, the new version won't be instantly available, downloaded and installed by everyone.
It's not rare to see people using versions that are several months old, if not worse.

I suggest making tests locally if you can, or to wait a few days/weeks.

from fbneo.

sfz3mix avatar sfz3mix commented on September 25, 2024

My test used the latest build from this site on the sides https://buildbot.libretro.com/nightly/windows/x86_64/latest/
But thanks for the tip, I'll do more tests over time.
πŸ‘

from fbneo.

dinkc64 avatar dinkc64 commented on September 25, 2024

Can you try again after core update?
I saved a state with sample use, then removed samples, reloaded and load state works - this wouldn't have worked before the fix, so, I think it should be OK now.

best regards,

  • dink

from fbneo.

sfz3mix avatar sfz3mix commented on September 25, 2024

I updated and tested it again and it worked.
Thanks again to the entire FBNeo support team.
πŸ‘

from fbneo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.