fintechneo/angular-git-filebrowser

Filebrowser using Angular material and libgit2

angular-git-filebrowser's Issues

quickResolveConflict does not always complete

I expected quickResolveConflict to complete. I had to add the take(1) in order for my for forkJoin to finish. Is this the intended behaviour?

 const olist = this.data.files.map(file => this.data.backend.quickResolveConflict(file, pick).pipe(take(1)));

        forkJoin(olist).subscribe( () => {
               this.data.backend.markConflictsResolved().subscribe( () => this.dialogRef.close())
           }    
        )

simpler readdir

The readdir() seems to do a lot more than simply return a list of files in a folder.

Here is a simple version that does the minimum required.

   /*
     * simple readdir list the files names in the path
     */
    readdirPJL(path?: string): Observable<string[]> {
        if (path === undefined) {
            path = '.';
        }
        return this.callWorker2((params) =>
            FS.readdir(params.path), { path: path });
    }