Giter Site home page Giter Site logo

Comments (3)

utybo avatar utybo commented on August 31, 2024

After looking through the code, the issue might be somewhere around here where the snap resolution might be too naive or something along those lines :/

float factor = Song.FULL_STEP / (float)step * resolution / Song.STANDARD_BEAT_RESOLUTION;

Edit: Might not be there after all. I'm suspecting Moonscraper not taking into account intermediate time signature changes and not taking into account where measures are?

from moonscraper-chart-editor.

utybo avatar utybo commented on August 31, 2024

I have fixed it, the line which I found was indeed the culprit. I will be uploading a PR soon ™️

For the record: time signature changes are supposed to be placed on measures only: even if they're shown properly in Moonscraper, they won't show up in Clone Hero. This fix still works in situations like having a 9/16 measure followed by a 4/4 measure. (thanks XEntombmentX for the example!)

from moonscraper-chart-editor.

FireFox2000000 avatar FireFox2000000 commented on August 31, 2024

Fixed with commit "Step/snap placement now relative to the beat lines instead of internal tick layout". Pull request does not fully correct the issue and lacks the use of optimised lookup functions already provided in the code.

from moonscraper-chart-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.