Comments (3)
After looking through the code, the issue might be somewhere around here where the snap resolution might be too naive or something along those lines :/
Edit: Might not be there after all. I'm suspecting Moonscraper not taking into account intermediate time signature changes and not taking into account where measures are?
from moonscraper-chart-editor.
I have fixed it, the line which I found was indeed the culprit. I will be uploading a PR soon ™️
For the record: time signature changes are supposed to be placed on measures only: even if they're shown properly in Moonscraper, they won't show up in Clone Hero. This fix still works in situations like having a 9/16 measure followed by a 4/4 measure. (thanks XEntombmentX for the example!)
from moonscraper-chart-editor.
Fixed with commit "Step/snap placement now relative to the beat lines instead of internal tick layout". Pull request does not fully correct the issue and lacks the use of optimised lookup functions already provided in the code.
from moonscraper-chart-editor.
Related Issues (20)
- Playback resets when started after any notes HOT 3
- `GetNextNonInclusive` returns incorrect value under boundary conditions HOT 3
- Cant Separate 5 Lane Drums from Pro Drums HOT 1
- .
- I tried booting it up for linux but this happened HOT 1
- Cursor disappears after scrolling with middle mouse button (Linux) HOT 1
- Moonscraper constantly freezing HOT 2
- Playback delay when starting in the further into the chart
- Linux x86-64: Doesn't detect required dependencies even when installed HOT 3
- Moonscraper issue HOT 16
- Mesh cannot have more than 65000 vertices HOT 1
- An event was found but no note was found there HOT 2
- Feature request: Unpitched vocals
- "SDL2 Linux runtime dependency not found" when SDL2 is installed HOT 6
- Fortnite Festival Lift Notes
- Moonscraper crashing on Launch HOT 6
- Pressing space for playback will sometimes bug out and mute audio. Exiting Moonscraper is the only resolution. HOT 1
- Missing "Solo" and "Soloend"?
- Missing "Solo" & "Soloend"? HOT 1
- Cursor vanishes when pressing middle mouse button on Ubuntu
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moonscraper-chart-editor.