firefox2000000/moonscraper-chart-editor

moonscraper-chart-editor's Issues

.mid import does not treat note 106 in Vocals as a lyrics phrase marker

Rock Band games before Rock Band 3 use two different phrase notes to allow for modes where two players could face off against each other, trading off the part or sometimes playing at the same time. This extends to vocals as well, which means note 106 should also be treated as a phrase marker.

Screenshot from Rock Band 2's chart of Avenged Sevenfold - Almost Easy:

While the lyrics in these phrases get converted just fine, they don't have added phrase_start and phrase_end events to encapsulate them in a phrase.

Linux port

Hi. I'm asking for Linux port for this project. It runs terribly under Wine, and Unity gives me compilation errors when I try to build it (I'm n00b in C#, so I don't know what's going on).

Moonscraper Chart Editor v1.4.3.3 Windows 64 Installer blocked by Windows defender as severe threat Trojan virus

Incorrect Unity version number in the README

The README indicates 5.6.6f2 whereas the project is actually for version 2018.3.0f2

Program crashes on attempting to save file that does not exist

Steps to recreate:

1. Create a new chart.
2. Delete the chart file.
3. Attempt to save the file.

This is an incredibly easy fix: create a check to see if the file still exists, and if it doesn't, create one and write to it.

Problem Exporting .MID Files

It says Object reference not set to an instance of an object.

Cannot start Moonscraper.

When starting the application, it goes through the loading text but then freezes on a black screen. I have asked others and nobody else seems to have this issue.

Offset problems on a non-English system (again)

Hello, it's me again from the ussue #11

My Windows is in Russian, and since Mooscraper uses locale settings for separators (apparently), it only allows to input a comma there, yet that leads to a number of problems:

• While it does save the value now (unlike before), CH just doesn't care about the decimal part of the offset if it's separated with a comma, it wants a dot.
• If you try to load any chart with an offset that does use a dot in the .chart file, MS doesn't load it and any parameters after (Resolution, Player2, Difficulty, Genre, MediaType, MusicStream), using default ones instead.
• If you try to open up a .chart with the comma-separated offset value, it ignores the decimal part, but does keep the int part.

Error building package from PKGBUILD

I've tried to install Moonscraper on Artix Linux (OpenRC, basically like Arch Linux, shouldn't matter).

makepkg stopped when it reached package(), as seen on this image:

The faulty cp command is located at line 123. If you need any more info, let me know.

Moonscraper crash on Lyric Editor threshold adjustment

Moonscraper crashes if you enter a period/decimal as the first character into the "Place Threshold Time" box.

Ex: "0.5" doesn't crash it but trying to enter ".5" does.

Log is attached.

output_log.txt

.mid import does not treat note 103 in songs with no 116 notes as Star Power

Older customs made for Guitar Hero 1, 2, or 80's will get their Star Power phrases incorrectly imported as solo events due to this.

Add formatting tags to the lyrics editor

Would it be possible to add formatting tags to the lyrics editor so that I don't have to edit each individual event?
Something like this:

Support for Special Characters (i.e. -, ", Unicode)

(This issue is in response to pull request #43)

The Value of Special Characters

In Moonscraper and the .chart file type, certain characters should not currently be used in global or track events. These most notably include the hyphen (-) and plain quotation marks ("), though I will also mention Unicode characters later. These characters are illegal because of how a lyric event is stored in the .chart file format:

<lyric tick> = E "lyric hello!"

Or more commonly, with syllables separated:

<lyric tick 1> = E "lyric Hel-"
<lyric tick 2> = E "lyric lo!"

The quotation marks are used to encapsulate the content of the events, which in this case are lyric Hel- and lyric lo!; they are always removed by Moonscraper when importing a .chart file. And the hyphens are used to separate syllables in a word, as in lyric Hel-; they are removed by the program playing a .chart (or .mid) file and are always removed by Clone Hero. If you want to use them in your lyrics to add style, currently you need to find a workaround, like using two apostrophes ('') instead of proper quotation marks; or, you can simply avoid using these characters altogether.

Potential Solutions

1. Parse More Intelligently

Take, for example, the following lyric event:

960 = E "lyric "What?""

We want our lyric event do display as "What?", but instead we simply get What?. Where did our quotes go? Well, we need to remember that quotation marks are automatically removed when our chart file is read. So our reading program (such as Clone Hero) only sees this:

960 = E lyric What?

It is not surprising, then, that our quotes have disappeared. Notice, however, that we have enough information to figure out exactly where we should and should not have quotation marks. Let's simply remove the first and last quotation mark in our event:

960 = E "lyric "What?"" becomes 960 = E lyric "What?"

We can break our line down into parts (960, =, E, lyric, and "What?"), and we will have our event back just as we typed it.

A similar process can be used for hyphens, where we only remove the last hyphen in a lyric event:

768 = E "lyric out--"
816 = E "lyric of--"
864 = E "lyric this--"
912 = E "lyric world"

can give us the syllables out-, of-, this-, and world without losing the information that these events are syllables.

Technical Note

Quotation marks are actually legal characters in Clone Hero in the .mid file format, and they are correctly saved to both the .chart and .mid formats from Moonscraper. However, if you reopen a .chart file that has extra quotation marks, they will be removed by Moonscraper and will need to be retyped. Hyphens are also saved correctly to the .chart and .mid formats, but they are currently removed in Clone Hero.

2. Add Escape Characters

Escape characters give us another solution to this problem by letting us explicitly say that we want to use a character as-is. In C#, for example, the backslash () is an escape character. \" gets interpreted as an apostrophe, \n is a newline character, and \\ codes for the backslash itself. We could use a similar system in the .chart specification, where \- would code for a dash, \" for a quotation mark, and \\ for a backslash. This is a more robust solution than character substitution, such as using = to mean -; we can now use hyphens in our lyrics, but we can't use equal signs, so we have just shifted the problem.

3. Use Other Characters Instead

This is not one of my preferred solutions, but it is worth mentioning because it's what many charters are currently doing. Instead of using plain quotation marks, we can instead using opening (“, U+201C) and closing (”U+201D) quotation marks to accomplish a similar style. For hyphens, we can substitute the similar en dash (–, U+2013). These characters are distinct from the hyphen (-, U+002D) and plain quotation marks (", U+0022), so they aren't parsed out when reading the file and should display as-expected.

Not only does this approach still prevent you from using the original characters you wanted to, it also assumes that every program that will read a chart file understands Unicode characters; if a program doesn't accept Unicode characters, the effects can range from unexpected to totally game-breaking. Moonscraper doesn't support Unicode fully, as shown below:

While Unicode could reasonably be implemented into newer applications, it is not likely to make its way into old code. A Unicode implementation would also be incomplete without giving its characters more real use by supporting multiple languages for a song, a feature that is beyond the scope of this issue.

Verdict

I am of the opinion that Moonscraper will eventually need to support special characters better than it currently does. While an implementation of any of the above solutions comes with its challenges, it will be better for the community in the long run if special characters become officially supported in Moonscraper and the .chart file format.

Clap function not working with music

It appears that the song audio is overriding the clap sound. When I remove the song audio, the clap will play. But when I add it back, the clap doesn't play.

(Font issue) Russian characters not supported in certain interfaces

Hi, I'm working on a song that is in Russian and I noticed that a few environments (notably event flags) do not support the characters (they appear as boxes).

An example from my lyrics:

Should appear as: Га-, си-, тся, свет

And another example from the top bar of the application (though this could be text encoding related? I can't be sure)

I know what this one is supposed to be (Я Не Коммунист) but it's so messed up that I can't say it correlates one to one, which is why I think it might be caused by text encoding

Russian text does work with some text displays (I think because of fonts that support it) i.e in the song properties

Adjusted fonts that include Russian text would be a helpful fix for me and anybody else who works with Russian music.

Moonscraper For Android

Can You Create Moonscraper For Android? I want to create chart on android so pls Create for apk/android version

Display global events horizontally rather than vertically

It's really hard to read and edit global events when there are many of them close together (e.g. song lyrics). They all overlap and it's impossible to read them and edit them.

Is there any way they can be displayed in a different way? Like perhaps horizontally rather than vertically? Maybe this can be a configurable option.

Not sure how easy this is to do. If you don't have time, I can try to open a PR myself.

Feature requests

• Saving and reusing note sections. This means you can select some notes with the Select tool, and then with the command Ctrl+C (Copy), it automatically stores it in a "Copied sections" list. You can access this list by going to Tools > Copied sections, and from there load, rename, and delete copied sections. The default name for a copied section is a timestamp and sorted descending by created date. You load a copied section by double-clicking it in the list, and it will put the notes at your current position with the notes selected. The load will behave just like pasting notes, meaning it will overwrite existing notes at the current position.
• Reset the song speed on double-clicking the speed adjuster. When I chart I regularly slow down songs during fast sections to better hear the exact notes being played. I think it would greatly improve the user experience if you could easily reset the speed to 1x by simply double-clicking the speed adjuster, instead of having to "aim" the adjuster to 1x each time you wanna review your charting.

I really love this tool, it's simple and easy to use! Keep it up!

Feature request (XInput support)

It would be awesome if Moonscraper got XInput support so we could chart with guitars.
The charting progress would be a lot faster and more user friendly. There are more benefits like getting the tempo synced with much less sweat and creating more complex and catchy combos with ease.
This would be a huge help too when experimenting with different approaches how a part of the song should be played.

Custom Flags with spaces

I am using custom flags with spaces for making charts for my game that looks like "K 21 78 56 13" but Moonscraper doesn't process them properly. Could you add the following change to the file \Assets\Scripts\Game\Charts\IO\Chart\ChartReader.cs

LINE 684:
string eventName = line.Substring(stringStartIndex, stringLength);

CHANGE TO:
string eventName = line.Substring(stringStartIndex, line.Length - stringStartIndex);

This will not affect the rest of the functionality, but add support for flags with spaces.

Opus song files are read, but not copied when exporting

Upon exporting a chart that uses a *.opus audio file, only notes.chart and song.ini are produced.

In addition to the simple fix of actually copying the song file, a checkbox option could be added to offer converting it to *.ogg format as v23 is not capable of reading opus files.

Can't change offset in 1.3.1

Hello. This version of Moonscraper completely ignores anything about offset property. Open any chart file and the song properties show 0 on the offset, even if it's not actually 0. Changing it there and reopening properties window - still stays 0. Entering offset and hitting save without closing - saves 0 into the file.

My guess it's to do with the culture checking, since our country uses commas as separators, but that brings another problem - you can't put a comma into the field.

Edit: Changed decimal separator in system settings - nop, didn't help. Asked someone else who is on English Windows - apparently there are no problems.
Edit 2: Changing offset to an integer amount works fine, but as soon as you put anything other than integer it drops to 0.

Moonscraper Chart Editor v1.3.3.2 doesn't allow Open Notes.

For some reason, you're unable to set open notes in this version, when pressing 6.
While Moonscraper Chart Editor v1.3.3.1 lets you do it.

.chart format

Hey. Congratulations on the Moonscraper tool. It's awesome.
I was wondering if there is any kind of resource to understand the .chart format. I would like to try and make a chart player just for fun.

Red cursor does not snap to the grid when changing the tempo and/or time signatures

The red cursor does not snap to the grid correctly when changing the tempo/time signature midway

Using this setup at the beginning of the chart

Results in this after the second BPM marker (the BPM 75 one you can see in the screenshot). Using the 1/24 step setting, it puts the red cursor either before or after the bar.

Here is the .chart file (you can ignore the notes)

Interluden.zip

The issue is particularly visible when using the 1/24 and 1/12 step settings.

Edit: note that I am changing the tempo multiple times in the song, that seems to be problematic

T1 GEMS track is ignored

For some .mid files (e.g., All of This in the current GH1 rips), the PART GUITAR track is named T1 GEMS. This is handled by Clone Hero, both v23 and the current v24 PTB. Moonscraper v1.3.5.4 does not handle this.
notes.zip

[Help] Help me understand the [SyncTrack]

Can you translate me this part of the chart file?

This works fine.

[SyncTrack]
{
  0 = TS 4
  0 = B 49000
  240 = B 98000
  90240 = TS 6
  91200 = B 99000
  93120 = TS 4
  93120 = B 98000
}

I have some issues with songs with SyncTracks like this

[SyncTrack]
{
  0 = TS 4
  0 = B 120000
}

What info the SyncTrack of the top have that the second SyncTrack dosen't have?

Thanks, Erasmo.

App crashed

Not sure what else to post about this, but I hope you can find out what caused it :)

Thanks

Unexpected Crashes

Moonscraper keeps crashing in my pc i'm using the 1.3.5.4 version do you know what is happening? im using windows 10

Mixer volume resets after restart

The windows audio mixer volume resets after you restart the program. I use the windows audio mixer a lot and it is very loud every time I start it

Update README to reflect actual download location for MCE

The wikia page for CH links to this repo and gives the impression that Unity/this are needed to chart songs.

HUGE CPU Usage While Idle

Sometimes I have MS in the background, and suddenly my computer is just bogged down. I have a 6-core AMD Phenom II.

I have no charts loaded, just happens on a blank new chart.

Save and export dialog does not open

When pressing export or save there is no explorer window asking where to save. I worked really hard on this chart and I don't want go back to my last backup.

Difficulty dropdown should be tagged with check icon

I went to try and add a checkmark to Easy/Medium/Hard/Expert depending on which was selected, but I saw that some implementation was already in place for this and must just not be working correctly. I don't know enough about Unity, C#, or programming in general to fix this so I thought I'd let you know here.

[Suggestion/Question] Launch in Fullscreen

Is there any way to make the app launch fullscreen every time, other than using a Windows shortcut (ie. double-clicking on a .chart file)?

If not, could a config option be added to the UI to allow this behavior? That would be very convenient :)

VERY high CPU and GPU usage for no reason

I have a 7700k and a 2070 SUPER. I don't think I should be getting these numbers at all let alone in a blank chart.

Unity Project in Mac Error

Hello, I'm having the next issue when I tried to open the project in Unity Editor using a Mac. I'd like to make some port but I don't know how to solve this problem... If you could give me a hint I could probably port this to a Mac Unity Project or at least be usable in the Unity Editor for Mac Developers

Regards

Blue Screen

Hi! So i found this program and immediately tried to download it. But when i run it its just a blue screen with a low opacity text of unity!

Opening Chart With Lyrics Wipes The Lyrics

This is on Moonscraper 1.2. I made my own chart and added lyrics, saved it, came back to change a few things and saw all the lyrics were wiped. I had to write them all in again and I've since been using a copy of the chart to edit and then made a python program to add the lyrics from the backup into the copy that gets wiped. It's not ideal and I'm still having trouble with the python because I'm bad at it.

Settings menu overlapping

When you open the Lyric Editor settings from the button on the Lyric Editor window, it opens to the Lyric Editor settings, but the Editor tab is also displayed on top of it. You have to click the Editor tab then go back to the Lyric Editor tab to fix. This happens every time you open the settings from the Lyric Editor pane.

Unholy CPU/GPU usage

Moonscraper uses all of my CPU and GPU, at the same time running at like 3 fps. I can't use it like this. I don't even know how to fix it because there's not enough options.

Solo sections can get lost in the conversion from .mid to .chart

This Sweating Bullets .mid file has a solo section when played in Clone Hero, but if you open it in Moonscraper and save it as a .chart the solo section is lost.

No Support for Foreign Characters

...at least in the loading_phrase text. For example, in this image the missing character between "D" and "d" is supposed to be ø, the Nordic o with a slash. I would like to see support added for foreign characters in Moonscraper.

Using a negative song offset should pad the end of the charting area

This makes it so stuff like this can happen. The song's audio file ends pretty abruptly, so using a -2.4 seconds song offset makes the end of the song unreachable.

Difficulty is not copied into diff_guitar upon Clone Hero export

Everything else from the song properties are properly copied into the song.ini file, except for the difficulty.

Issue with Moonscraper on Linux

Every time i open Moonscraper on my computer (running Ubuntu 20.04.2) it throws a SDL2 InputManager error for the Start and Update functions.

badsongs.txt says that this song has an unsupported instrument even though I didn't change it in the Instrument category when exporting

When I exported POLYBIUS GB SPEEDRUN (Glitchless 100% WR in 0:03:57) to Clone Hero, it didn't show up, so I looked for the badsongs.txt file, to which it said there was an unsupported instrument in it. Thing was, I never changed the instrument, it was just Guitar by default and I never change it. So what happened? (For context, I'm on MSCE 1.4.3.1, am on PTB v1.0.0.3075 though I doubt that's why it's happening, and even tried resetting my chart and reexporting it, but to no avail.)

[Feature request] More than 5 colors on chart editor.

Hello! I'm a game developer that is creating an a Guitar Hero like drum game for Oculus Quest, i prettend to use Moonscraper-Chart-Editor as official chart editor for the game, but, my planned drum kit have 7 itens instead of 5.

You can check out some details here. Reddit Post.

Can you add this feature? Or, can i fork and add this feature?

[Feature Request] 2 more lanes to support Beat Smith.

Hello! I'm a game developer that is creating an a Guitar Hero like Drum game for Oculus Quest, i prettend to use Moonscraper-Chart-Editor as official chart editor for the game, but, my planned drum kit have 7 itens instead of 5.

The name of the game is Beat Smith, and i plan to release on Oculus Store before Christmas.

I forked the chart editor, but i found a lot of dificulties to add 2 more lanes...

Can you add this feature? Or can you explain me how to do this?

Mac OSX port

It won't run under wine and I don't even want to try a virtual machine.