flaconi / terraform-aws-microservice Goto Github PK
View Code? Open in Web Editor NEWBoilerplate Terraform Module for creating resources for typical micro services.
License: MIT License
Boilerplate Terraform Module for creating resources for typical micro services.
License: MIT License
Finding found by @ronny-panknin-flaconi :
Looking at the dynamodb.tf and dynamodb2.tf configuration, there seems to be an issue with name collision :
dynamodb.tf
locals {
dynamodb_name = length(var.dynamodb_name_override) > 0 ? var.dynamodb_name_override : var.name
}
dynamodb2.tf
locals {
dynamodb2_name = length(var.dynamodb2_name_override) > 0 ? var.dynamodb2_name_override : var.name
}
dynamodb.tf
module "dynamodb" {
...
namespace = ""
stage = ""
name = local.dynamodb_name
...
dynamodb2.tf
module "dynamodb2" {
...
namespace = ""
stage = ""
name = local.dynamodb2_name
If neither var.dynamodb_name_override
nor var.dynamodb2_name_override
are specified, which are optional, the one which gets rolled out later would/could overwrite the first one.
This is tricky and there are multiple solutions to it, the big question is how do we make it consistent and easily understandable? Current consistency is to use var.name
as the single point of truth for resource names.
Only thing I could come up with is to make dynamodb(2)?_name_override
required, which however (will be inconsistent with other services provided.
@maartenvanderhoef any thoughts on this one?
Following RDS parameters are required for some services:
Dependabot couldn't parse the dynamodb.tf found at /dynamodb.tf
.
You can mention @dependabot in the comments below to contact the Dependabot team.
In order to avoid the creation of resources required for setting up the RDS-S3 dumps, we should be able to set rds_enable_s3_dump
to false
and by doing so avoid the need to pass any value for rds_s3_dump_role_arn
.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.