Giter Site home page Giter Site logo

simplybackpacks's People

Contributors

dracnis avatar emirhangg avatar flanks255 avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar

Forkers

kellixon metzen227 emirhangg michaelhillcox dracnis

simplybackpacks's Issues

Curio Specific Hotkey / MultivBackpack Support

Currently the hotkey setup seems to specifically only open your most recent backpack, which is neat, but perhaps the GUI could use a small change where there are tabs for other backpacks? Perhaps you could scroll through them with TAB? I understand this might be harder than it sounds because if a bag is somehow dropped or lost after the GUI opens it could cause a problem, or loading items in ways that might be recursive could be an issue, so a simpler solution may just be:

If the mod detects curios / baubles, the "open backpack" button (or a secondary hotkey) could link specifically to the one you are wearing rather than the last one you opened?

Items not staying in bag when clicked in OR SHIFT-clicked

Describe the bug
When trying to either drop items in or shift-click them in, they appear in the bag, but once the UI is closed, and sometimes a few seconds after and interacting with something like a crafting table or other interactable item, the items I just put in re-appear in my inventory, or pop out around me and i pick them back up.

Screenshots
not screenshotable as it happens randomly and quickly.

If it is a crash, please provide the crash-log through a website like http://pastebin.com or https://gist.github.com/
No crash, but happens to me & my partner on a LAN hosted instance of the modpack.

Please provide the version of forge used, and the mod version.
Forge: 36.2.22 (1.16.5)
Mod Version: 2.6.11.2

Text UI language key error

Describe the bug
When I try to open or recover a deleted backpack from chat area, it will display the translation key simplebackpacks.invaliduuid.

The correct key is simplybackpacks.invaliduuid.

Screenshots
image

How to fix
You should correct line 49 in com.flanks255.simplybackpacks.commands.Open class, and line 50 in com.flanks255.simplybackpacks.commands.Recover class.

ctx.getSource().sendFailure(new TranslatableComponent("simplebackpacks.invaliduuid"));

Please provide the version of forge used, and the mod version.
The mod version is 1.16-2.1.0-build.37

I don't want to send a PR because I am lazy :)
But if you would like to include me in the commit message, I would appreciate it.

Andy Zhang <[email protected]>

server issues

Describe the bug
A clear and concise description of what the bug is.
duping due to auto pick up attempting to pick up items and still leaving them on the floor.

Screenshots
If applicable, add screenshots to help explain your problem.

Please try to give as much info as possible.

  • maybe as a server we can get a option in config to disable this for all players so we can use the mod with no issue

If it is a crash, please provide the crash-log through a website like http://pastebin.com or https://gist.github.com/

Please provide the version of forge used, and the mod version.
for mod version its on ftb ultimate anniversary edition using 1.16.5-2.0-1 - build.27
forge version 36.2.26

Items disappearing when moving all of an item

After moving all of one item into a backpack (by holding shift and double clicking,) the stacks convert to single items when the backpack is reopened. I've attached a gif of the issue occuring, it seems to happen more often when putting your items in the bottom half of the backpack.
ezgif-2-7a49a43941a2

forge-31.1.18, simplybackpacks-1.15.2-1.4.2.jar

Duplication Exploit

Describe the bug
You're able to duplicate items using the backpacks and a Modular router with a player module.

You can set the player module to only pull from main inventory excluding the hotbar. You can then have the bag in your off-hand, open it, and then hit 'F' on one of your inventory slots to put it in your inventory. This removes the bag but you can still access the inventory and pull stuff out. When you close the inventory and grab the bag from the modular router, the backpack inventory is untouched even though you took items out.

Note
I understand that this could be fixed, but would require a rewrite of the mod, as the issue lies in the fact that the storage data is held in nbt on the backpacks.

Versions
Forge: 32.0.108
Simply Backpacks: 1.4.10
Modular Routers: 7.0.1-29

Missing save in `EntityItemPickupEvent` handling

Describe the bug
I was debugging a dupe bug with Building Gadgets and ProjectE alchemical bags with black hole ring (Issue) then I also thought to check SimplyBackpacks and ran into a different error: Getting N + 1 items in the backpack. After fixing the bug with ProjectE the result was that with SimplyBackpacks I only got 1 items returned to the bag.

BuildingGadgets throws multiple EntityItemPickupEvent for each block being picked up, I traced through Simplybackpack and came here where the contents of the backpack gets checked to see where to insert the Items in the backpack.

Now I noticed that everytime this block was hit, the code reported "1 air" in the first slot, even through I had hit the code before and it at that point added "1 cobblestone" to the slot.
So somehow simplybackpacks keeps it's initial state till building gadgets is done and then it saves the last thing that happened: adding "1 cobblestone". The end result is only 1 cobblestone in the backpack while I expected there to be multiple.

I think there is a save call missing in the event loop and it's happening somewhere later thus it can't correctly store the multiple events.

simplybackpacks version: 1.15.2-1.4.11
Forge: 31.2.31

How does the filter work?

How does the filter work? I press shift+right click, switch whitelist to on and put an item in. When i close the menu the whitelist is switching to off automaticly. What i do wrong?

sry for my english.

Config with balcklist/whitelist

It would be amazing if the mod had a config option to allow certain stuff to go into the backpacks, like modded stuff or shulker boxes. Currently the fishing rods from the aquaculture mod cant go into the bags.

Minecraft 1.16.5.

Visual Request- Backpack sprite render

-Backpack sprite shows up on back over armor layers and top clothing layer
-Would be very immersive and look great
-Allows for really interesting retextures to match with armor
[example: armor storage pack that looks like a bandolier for armor]

curios slot does not appear, can't put backpack there

Minecraft version 1.16.1
curious version curios-FORGE-1.16.1-3.0.0.2
simplybackpacs version 1.4.10

mod does not register a slot with the curious api. No slot appears when clicking on the icon in the user image in inventory (curious button is there, slot does not appear)
cannot wear backpack

Screenshots
If applicable, add screenshots to help explain your problem.

Please try to give as much info as possible.

If it is a crash, please provide the crash-log through a website like http://pastebin.com or https://gist.github.com/

Please provide the version of forge used, and the mod version.

Chinese Translation Request

Aha, it's me again. #53 was found when I translate this mod.

I am a contributor to a Chinese Minecraft modpack localization community. We use resourcepack to localize most mods of Minecraft. This is our main GitHub repo: Minecraft-Mod-Language-Package.

Recently, we translated your mod Tips' lang file into Chinese via the commit CFPAOrg/Minecraft-Mod-Language-Package@2038b5f, this is the related PR: CFPAOrg/Minecraft-Mod-Language-Package#1961. Most Chinese modpack players are using our resourcepack, so now many Chinese players can see this translation.

For all Chinese players to be able to see the translated tips, would your please pull this Chinese localization into your repo? This is the translated file.

{
  "simplybackpacks.shift": "按住 <§6§oShift§r> 获取详细信息。",
  "key.simplybackpacks.category": "简易背包",
  "key.simplybackpacks.backpackpickup.desc": "开关自动拾取",
  "key.simplybackpacks.backpackopen.desc": "打开背包",

  "simplybackpacks.autopickup": "自动拾取",
  "simplybackpacks.autopickupenabled": "自动拾取§a已启用§r",
  "simplybackpacks.autopickupdisabled": "自动拾取§c已禁用§r",

  "simplybackpacks.whitelist": "白名单",
  "simplybackpacks.nbtdata": "NBT标签",

  "simplybackpacks.invaliduuid": "未知UUID",
  "simplybackpacks.delete.confirmation": "你是否确定删除这个背包？\n该操作无法撤回。\n使用 /sb delete %s 以确认删除",
  "simplybackpacks.delete.finished": "背包%s已删除",
  "simplybackpacks.notsetup": "在手中打开以初始化。",

  "item.simplybackpacks.commonbackpack": "普通背包",
  "item.simplybackpacks.commonbackpack.info": "最简单的背包。",
  "item.simplybackpacks.commonbackpack.info2": "§f可容纳18组物品§r",

  "item.simplybackpacks.uncommonbackpack": "不凡背包",
  "item.simplybackpacks.uncommonbackpack.info": "稍好些的背包。",
  "item.simplybackpacks.uncommonbackpack.info2": "§e可容纳33组物品§r",

  "item.simplybackpacks.rarebackpack": "珍稀背包",
  "item.simplybackpacks.rarebackpack.info": "非常棒的背包。",
  "item.simplybackpacks.rarebackpack.info2": "§b可容纳66组物品§r",

  "item.simplybackpacks.epicbackpack": "史诗背包",
  "item.simplybackpacks.epicbackpack.info": "史诗般的背包。",
  "item.simplybackpacks.epicbackpack.info2": "§d可容纳99组物品§r",

  "item.simplybackpacks.ultimatebackpack": "终极背包",
  "item.simplybackpacks.ultimatebackpack.info": "最终极的背包。",
  "item.simplybackpacks.ultimatebackpack.info2": "§d可容纳158组物品§r"
}

These are all co-authors of this translation.

Andy Zhang <[email protected]>
奈 <[email protected]>
mamaruo <[email protected]>

Thank you for your assistance.

Can't use 1.16.2

I can't make any of the backpacks or find them in creative mode.

Remove Logging

Simply backpacks is currently logging the NBT of every item that goes into a backpack.

Can we turn that off please? :)

simplybackpacks-1.15.2-1.4.3.jar

Item deletion on upgrade

Items in backpacks are deleted when upgrading.

Latest Forge version of 1.12.2. Simply Backpacks 1.4.9.

I recognize you've expressed disinterest in continuing support for 1.12.2 and I've actually made an attempt at resolving this through a crafttweaker script to copy and edit the nbt for the resultant upgraded backpack: https://pastebin.com/wD2KWyvw

I'm fully out of my depth at this point and thought I'd try here. :) No pressure one way or another.

Number of slots bugged after upgrading to diamond backpack

I upgraded the basic to diamond backpack and I am experiencing a weird bug where it seems like it can hold much fewer items then visible 66 slots. If I try to put more than 17 items it starts spitting them out or putting them back to inventory as soon as I close the backpack... As if it was a common backpack, not a diamond.

Screenshots
Diamond backpack before putting desired items into:
image

Shift+right clicking/transferring items to the backpack:
image

Closing inventory by pressing E or Esc and reopening the backpack:
image

Very weird behaviour.

Forge: 36.2.20
simplybackpacks-1.16.5-2.0.0-build.18
Modpack: Oceanblock version 1.11.0

Picked up items don't go to backpack

As I was playing Minecraft, I had made several backpacks, all whitelisted with Auto-Pickup on, in order to sort out what I pick up into categories like - Mining, Farming, etc. However, I've realised that the bags only auto-pickup items IF the bags are in your hot-bar and NOT in your inventory. This is an extreme nuisance as I have too many backpacks to have them all in my inventory and my tools (sword, pickaxe, axe, etc).

I am currently in 1.16.3, mod version: 1.4.13, Forge: 34.1.14

Possibility to use several bags

It would be nice if you could use several bags at once, pressing your chosen key multiple times to cycle through the bags in your inventory

Minecraft version 1.16.5

Everything in my backpack disappeared?

I was having connection issues so I was logging on and off of a server, I had a full rare backpacks worth of stuff and it is all gone, I haven’t touched it and I didn’t drop the bag at any point. Help?

Unable to put backpack into bauble slot 1.18.1

Describe the bug
Backpack cannot be placed into any Baubles - Reborn 1.18.1 slot. It only works in Curios slots.

Screenshots
If applicable, add screenshots to help explain your problem.

Baubles - Reborn? (1.18.1 port of Azanor13's original Baubles) Ver baubles-1.10.1-1.18.1
Simply Backpacks - aimplybackpacks-1.18-2.0.1-build.28
Forge 39.0.8

Please provide the version of forge used, and the mod version.

[1.15.2] All items dissapeared after enabling auto pickup

My uncommon backpack was full of goodies when I enabled auto-pickup (shift+right click and turned on the slider). After that, I picked up some other items and looked inside the backpack. All the items were gone, there were only a couple of stone blocks etc. which were just picked.

I have other mods as well, there were both vanilla and mod items which disappeared. I have Mouse Tweaks.

Forge version: 31.1.47
Mod version: 1.15.2-1.4.5

Add 1.16.4 tag to CurseForge download of latest version

Most 1.16.3 mods should work without any changes in 1.16.4, but using the Twitch launcher (now CurseForge launcher) won't let you download a mod to a pack if the mod doesn't have matching version tag. I tested the mod by copying in the jar file into a pack, and I didn't notice any changes that would break the general use of the mod.

[MC 1.15.2] Mod Interaction - Quark

Describe the bug
When Quark mod is installed the inventory buttons added by it overlay some slots.

Screenshots
Screenshot_1

I considered to post that on Quarks github, but I think it is much harder to change the button position for all possible interactions than just increasing the space between the inventory and the backpack.

[MC 1.15.2] CraftTweaker doesn't remove recipes from this mod

Describe the bug
CraftTweaker; latest version, doesn't remove recipes from this mod. I've tried the exact same code on other mods.

Screenshots
These are the zenscript lines
image

Here's what the Rare backpack looks like in-game, when it's supposed to remove the original recipe.
image

Here's the common backpack, able to display the information line I gave in the last line of code, but not remove its recipe.
image
image

CraftTweaker version 6.0.0.10
Mod version version 1.4.5
Forge version version 31.1.34

Backpack cannot be pulled out of the AE2 system

Describe the bug
The backpack got stuck in the ME system and cannot be taken out with any mouse and keyboard interactions. It also cannot be pulled out with an interface.

Screenshots
image
Video:
https://streamable.com/rf1j6i

Forge version: 35.1.16
Simply Backpacks version: 1.16.3-1.4.13
Applied Energistics 2 version: 8.2.0-beta2
Part of the Direwolf20 1.16.4 pack version 1.4.1

Cannot put XP block or Heavy plated shield into simply backpacks

Describe the bug
Certain items cannot be put inside the Backpacks:

  • Heavy plated shield from Immersive Engineering
  • XP blocks from Global XP can be put inside only when no experience is stored

Please provide the version of forge used, and the mod version.

  • Forge-1.14.4-28.2.16
  • simplybackpacks-1.14.4-1.4.5

Void Items

I put some items in the backpack then I closed it and then opened it again. All items were gone.
Backpack was empty. I experimented a while and discovered that wearing a Wyvern Chestplate
from Draconic Evolution was probably causing this issue.

simplybackpacks-1.2.2.jar
forge-14.23.5.2846

Opening a backpack passes clicks through to the world

Describe the bug

  • Hold a bag in your main hand and a block in your other hand.
  • Right click.
  • You open the bag and place the block at the same time.

Happens with anything that has a right click behavior (this is pretty disastrous with a CAD from Psi, for example x) )

What I expected would happen
You wouldn't place the block.

Fix
Return SUCCESS instead of calling super here:

simplybackpacks/src/main/kotlin/com/flanks255/simplybackpacks/items/ItemBackpackBase.kt

Line 91 in 818d503

override fun onItemRightClick(worldIn: World, playerIn: EntityPlayer, handIn: EnumHand): ActionResult<ItemStack> {

Versions
Simply Backpacks 1.2.2
Forge 14.23.5.2648
(it's in FTB Academy with a bunch of other mods added but I don't think the exact modlist is important)

Dissapearing Items

Death removes all items in the backpack

All of the contents within my backpack up and disappeared on me when I died, needless to say, not a very enjoyable experience.
If it makes a difference, I was using an uncommon backpack when this occurred.

1.15.2
Forge 31.2.31

Update GUI to be compatible with mods that adds sorting buttons

With mods like Quark and maybe other inventory sorting mods, opening the GUI looks like this https://prnt.sc/tvyu3l .. increasing the space between the players inventory and the backpack inventory might solve these issues..

the buttons in question ( those in my screenshot ) are the ones that sort the players inventory and those on top, next to the inventory name are the ones that sorts the chest/backpack inventory.

Item Duplication/Voiding Bug

Describe the bug
I noticed after sorting the backpack that I had two identical shears in there. I definitely did not have two shears, and if I somehow did, the chance that they'd both have the same damage value is slim. After noticing that I went to grab my exchanging gadget from the bag to charge it and found it wasn't there. I checked the storage system and it wasn't in there either. My guess is that when I sorted the bag it overwrote the exchanging gadget item with a copy of the shears. Not sure if this issue belongs to simply backpacks or inventory sorter, but I haven't seen it happen in any other inventories so I'm starting here.

Forge version: 35.1.13
Simply Backpacks version: 1.16.3-1.4.13
Simple Inventory Sorter version: 18.1.0
Part of the Direwolf20 1.16 pack version 1.1.2

Placing backpack on Bibliocraft shelf wipes all contents

Describe the bug

  • Hold a bag in your main hand.
  • Right click on a Bibliocraft shelf to place the bag on the shelf.
  • Right click on the shelf to retrieve the bag into your inventory.
  • Bag inventory is now empty

What I expected would happen
Bag retains inventory when removed from shelf.

Note: I attempted this same process with a Thermal Expansion satchel, but the satchel retained its inventory.

Versions
Simply Backpacks 1.2.3 (in Dungeons, Dragons & Space Shuttles with many other mods)
Forge 14.23.5.2847

Items popping back into inventory or dropping on ground

I have the rare backpack. But once I put items in that would fill the bag up past 33 item slots, everything past that kicks back into my inventory the next time that I open the backpack. Also, when I click and drag items into the backpack, no matter how many items are in it, they just shoot out onto the ground when I close the backpack. This doesn't happen when I shift click to input items.

Cant place shulker box in the backpack

Describe the bug
X. I cannot craft any of the backpack. I checked the recipe from the CurseForge (because I didn't put JEI) so many times and still doesn't work. I was using vanilla crafting table.
I found the problem. It's not bone meal and lapis, it's white dye and blue dye......
2. The shulker box that I haven't placed down can go in the backpack but after putting it on the ground then picking it up I can no longer place it in the backpack. Is this intentional feature?

Just curious, why don't you have comment section in the curse forge?

Please provide the version of forge used, and the mod version.

  • Forge 31.1.48
  • Mod Version 1.15.2 - 1.4.5

Auto Pickup

Could you explain how this feature works?
I don't understand how I can set up filters.

I imagined that if I set a filter for the backpack, the items I pick up go straight into the backpack.
But that was not the case.

Then I tried if the whitelist only allowed certain items to be stored in the backpack, but that was not the cause either.
So please.. explain these in detail.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.