flarum/flarum-gulp

Gulp wrapper for Flarum extension JavaScript compilation.

About Flarum

Flarum is a delightfully simple discussion platform for your website. It's fast and easy to use, with all the features you need to run a successful community. It is designed to be:

• Fast and simple. No clutter, no bloat, no complex dependencies. Flarum is built with PHP so it’s quick and easy to deploy. The interface is powered by Mithril, a performant JavaScript framework with a tiny footprint.

• Beautiful and responsive. This is forum software for humans. Flarum is carefully designed to be consistent and intuitive across platforms, out-of-the-box.

• Powerful and extensible. Customize, extend, and integrate Flarum to suit your community. Flarum’s architecture is amazingly flexible, with a powerful Extension API.

Installation

Read the Installation guide to get started. For support, refer to the documentation, and ask questions on the community forum or Discord chat.

Contributing

Thank you for considering contributing to Flarum! Please read the Contributing guide to learn how you can help.

This repository only holds the Flarum skeleton application. Most development happens in flarum/core.

Security Vulnerabilities

If you discover a security vulnerability within Flarum, please follow our security policy so we can address it promptly.

License

Flarum is open-source software licensed under the MIT License.

flarum-gulp's Issues

Upgrade to Babel 6

Add UglifyJS2

UglifyJS2 seems pretty good, it rename local variables too
and can helps to prevent reaching google closure limit
related to flarum/framework#887

https://github.com/mishoo/UglifyJS2
https://github.com/terinjokes/gulp-uglify

rename or delete file break watch task

step to reproduce:

1. run gulp watch
2. try to rename or delete a file from src folder
3. you will see something like this:

flarum/vendor/flarum/core/js/admin/node_modules/flarum-gulp/index.js:69
          delete cached.caches['modules' + prefix][event.path];
                                                        ^

TypeError: Cannot convert undefined or null to object
    at EventEmitter.<anonymous> (flarum/vendor/flarum/core/js/admin/node_modules/flarum-gulp/index.js:69:57)
    at emitOne (events.js:96:13)
    at EventEmitter.emit (events.js:188:7)
    at Gaze.<anonymous> (flarum/vendor/flarum/core/js/admin/node_modules/glob-watcher/index.js:17:11)
    at emitTwo (events.js:106:13)
    at Gaze.emit (events.js:191:7)
    at Gaze.emit (flarum/vendor/flarum/core/js/admin/node_modules/gaze/lib/gaze.js:129:32)
    at flarum/vendor/flarum/core/js/admin/node_modules/gaze/lib/gaze.js:389:18
    at Array.forEach (native)
    at flarum/vendor/flarum/core/js/admin/node_modules/gaze/lib/gaze.js:385:12

Build with Node 6 fails

I currently can't build the flarum/core JS with Node 6+.

Because of nodejs/node#5348, Node.JS v6+ throw exceptions when a path is not a string.

Apparently, we somehow incorrectly initialize the gulp-babel plugin, because that's the error I get:

TypeError in plugin 'gulp-babel'
Message:
    Path must be a string. Received undefined

Building with Node 5 works for now. :)

gulp-order and minimatch security issue

When I do npm install in a js/forum or js/admin extension folder, I am getting several warnings that invite me to do a npm audit fix, after which remains one report which requires a manual fix on your end.

                       === npm audit security report ===

┌──────────────────────────────────────────────────────────────────────────────┐
│                                Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ Regular Expression Denial of Service                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ minimatch                                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=3.0.2                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ flarum-gulp [dev]                                            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ flarum-gulp > gulp-order > minimatch                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/118                       │
└───────────────┴──────────────────────────────────────────────────────────────┘
found 1 high severity vulnerability in 6952 scanned packages
  1 vulnerability requires manual review. See the full report for details.

Both minimatch and gulp-order have been fixed, the latter as of version 1.2.0.