Fleet UI run script disabled when host has scripts enabled and on orbit < 1.24.0

[georgekarrv]

Fleet UI run script disabled when host has scripts enabled and on orbit < 1.24.0

[gillespi314]

Here’s at least part of the frontend bug, I think, where the null value would be coerced to false when generating the dropdown options and cause the option to be disabled.

[jacobshandling]

@georgekarrv @rachaelshaw how about in this case we don't disable the option, but add a tooltip to the effect of "This host may not actually be able to run scripts"?

[jacobshandling]

Prototype for now:

[jacobshandling]

@gillespi314 so null should be interpreted as scripts being enabled?

[jacobshandling]

Looks like @getvictor saw this coming a week ago.

[jacobshandling]

scripts_enabled == null means this agent is not an orbit agent, or this agent is version <=1.23.0 which is not collecting the scripts enabled info

@rachaelshaw I don't see anything in the Figma for these edge cases. How should the UI handle them?

[georgekarrv]

^ need to continue to have our old logic as a fallback

[gillespi314]

@jacobshandling:

so null should be interpreted as scripts being enabled?

Based on this commit, I think so.

[rachaelshaw]

@jacobshandling discussed @ design review, and decided to just keep the options enabled as before when scripts_enabled == null, no tooltip.

We noticed that the tooltips for the disabled items are missing "and refetch host vitals" though (it was added later as a response to a concern Victor brought up, and the front-end may have been done already). Figma

[fleet-release]

Fleet's script can run,
Even when host orbits low.
Cloud city shines on.