Comments (6)
Included in the 1.1.7 release. Many thanks.
from fugit.
Duplicate of #10, I should release ASAP.
from fugit.
@godfat Would that suit you if I released fugit 1.1.7 immediately?
from fugit.
@jmettraux Thank you very much for the quick reactions! I didn't have time to look into how this was implemented yet, but my main concern is that next_time
can potentially never stop. This is way more harmful than accepting an invalid cron because it's very easily to shut down a service with that (i.e. a DoS attack). I really hope the implementation can be done in a way that it's impossible to get into this situation.
We're not using fugit yet, so please take your time, and there's no need to release a new version immediately for us, but I think that's indeed a very critical fix which should be available to other users soon.
On the other hand, I will be hesitant to make the switch before I am sure fugit will always stop in a timely manner. I'll verify the implementation later. (e.g. a loop has a hard limit to stop and raise an error)
Thanks again!
from fugit.
We are in sync, I was thinking about such a hard stop as I was waiting for the bus. I will implement it.
Best regards and thanks again.
from fugit.
Awesome, thank you!
from fugit.
Related Issues (20)
- cron #next_time loop breaker issue HOT 2
- cron #next_time loop breaker issue HOT 6
- TZInfo::PeriodNotFound exception when using Time.zone HOT 6
- Incorrect transition into DST for America/New_York HOT 1
- previous_time and next_time produce strange results when combining actual dates with day of week HOT 3
- Support character "W" in the cron expression HOT 1
- Incorrect schedule in certain timezone when using hash cron extention HOT 7
- Fugit::Cron#to_cron_s produces invalid cron string for "wed%2" HOT 7
- Tighten `Fugit.parse` HOT 1
- Fugit.parse_cronish(str) and .do_parse_cronish(str) HOT 5
- strip before parsing? HOT 4
- Fugit::Cron#next_time works incorrectly with "every second day" and "mon-fri" combo HOT 2
- Behaviour change between 1.4.4 and 1.4.5 HOT 8
- be liberal with extra commas
- Implement the & cron modifier HOT 1
- Issue parsing 0/1 compared to * or */1 HOT 4
- Introduce OpenBSD cron ~ notation HOT 1
- Fugit.parse incorrectly parsing am/pm HOT 5
- time computation with monthly duration like "P-2M" is incorrect
- Un-representable inputs should raise an error HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fugit.