Comments (3)
Hello,
I have further refined how et-orbi computes rweek
which is used for the cron modulo. I think it solves your issue.
Please upgrade to et-orbi 1.2.10 and tell me how it goes.
Merci beaucoup !
from fugit.
Hello, @jmettraux !
Thanks again for your fast reply on this issue :)
It looks like the upgrade to et-orbi 1.2.10
fixed all our errors 🎉
I've done a bit of testing to compare our last used versions 1.2.7 & 1.2.10
And it looks like the results are a bit different between the 2 (not for every cron but for some)
I just wanted your opinion on those (it looks like on 1.2.7, we had big jumps in the future on the next_time for example that we don't have anymore - I'm not sure if they were expected in the first place but .. - etc):
Version | 1.2.7 | 1.2.10 |
---|---|---|
cron | --- 0 5 * * 2%6 Europe/Berlin --- | --- 0 5 * * 2%6 Europe/Berlin --- |
previous time | 2024-02-27 04:00:00 +00:00 Tuesday | 2024-02-27 04:00:00 +00:00 Tuesday |
next time | 2024-11-05 04:00:00 +00:00 Tuesday | 2024-04-16 03:00:00 +00:00 Tuesday |
Version | 1.2.7 | 1.2.10 |
---|---|---|
cron | --- 0 10 * * 2%2 America/New_York --- | --- 0 10 * * 2%2 America/New_York --- |
previous time | 2024-03-12 14:00:00 +00:00 Tuesday | 2024-03-19 14:00:00 +00:00 Tuesday |
next time | 2024-11-05 15:00:00 +00:00 Tuesday | 2024-04-02 14:00:00 +00:00 Tuesday |
Version | 1.2.7 | 1.2.10 |
---|---|---|
cron | --- 20 0 * * 2%2 America/Los_Angeles --- | --- 20 0 * * 2%2 America/Los_Angeles --- |
previous time | 2024-02-27 08:20:00 +00:00 Tuesday | 2024-03-19 07:20:00 +00:00 Tuesday |
next time | 2024-04-02 07:20:00 +00:00 Tuesday | 2024-04-02 07:20:00 +00:00 Tuesday |
Version | 1.2.7 | 1.2.10 |
---|---|---|
cron | --- 20 9 * * 2%8 America/New_York --- | --- 20 9 * * 2%8 America/New_York --- |
previous time | 2024-03-12 13:20:00 +00:00 Tuesday | 2024-03-19 13:20:00 +00:00 Tuesday |
next time | 2024-12-17 14:20:00 +00:00 Tuesday | 2024-05-14 13:20:00 +00:00 Tuesday |
Let me know, thank you!
from fugit.
Hello @bdarcet,
thanks for the extra test cases. I much prefer the new 1.2.10 results. I've added some debug output to watch how #next_time
and #previous_time
zero on their target and it seems correct to me, it seems it does not skip now (it skipped too much and triggered the loop breaker previously, hence your reports).
The initial implementation of #rweek
was too loose, sorry about that. I'm glad you spotted the issue.
Closing this one now. Please report if there is anything else.
Have a nice week-end!
from fugit.
Related Issues (20)
- Implement the & cron modifier HOT 1
- Issue parsing 0/1 compared to * or */1 HOT 4
- Introduce OpenBSD cron ~ notation HOT 1
- Fugit.parse incorrectly parsing am/pm HOT 5
- time computation with monthly duration like "P-2M" is incorrect
- Un-representable inputs should raise an error HOT 4
- Incorrect next_time for cron that is supposed to run every 3 hours for America/New_York HOT 3
- If given 6 fields, the first one is interpreted as seconds HOT 2
- Version 1.10.0 not compatible with ruby 2.2.6 HOT 8
- Examples in Readme don't work: undefined method 'next' for Fugit::Cron HOT 1
- cron #previous_time loop breaker issue HOT 6
- #next_time breaks on DST end HOT 4
- Cron inconsistent behaviour with union vs intersection HOT 1
- multi-headed Fugit::Cron instance
- Specify which sidekiq-cron version is available HOT 2
- Specify which sidekiq-cron version is available HOT 5
- Regression with parsing in 1.9+ HOT 5
- Poor time complexity of Cron.parse HOT 3
- Question: `fourty` vs `forty` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fugit.