Giter Site home page Giter Site logo

Comments (2)

lihuelworks avatar lihuelworks commented on June 8, 2024

Same thing here, and Flow Launcher makes it notoriously difficult to stick with a version (even disabling automatic udpates)

from flow.launcher.

Yusyuriv avatar Yusyuriv commented on June 8, 2024

More info on why setting the ArgumentList value by index works with Python plugins, but not Node plugins: PythonPlugin.cs#L57 creates that index in the InitAsync method:

_startInfo.ArgumentList.Add(context.CurrentPluginMetadata.ExecuteFilePath);
_startInfo.ArgumentList.Add(""); // This adds the last element to the collection
                                 // used to communicate with plugins

while NodePlugin.cs#L45 does not do that. Adding the same line in NodePlugin.cs fixes the issue on Flow Launcher's side:

_startInfo.ArgumentList.Add(context.CurrentPluginMetadata.ExecuteFilePath);
_startInfo.ArgumentList.Add(""); // This fixes the issue
_startInfo.WorkingDirectory = context.CurrentPluginMetadata.PluginDirectory;

Node plugins still won't work if they're expecting method and parameters uncapitalized, but that's an easy fix on their side. Flow Launcher still needs to update its official Hello World plugin to use the capitalized properties.

from flow.launcher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.