flowpack/flowpack.fullpagecache

flowpack.fullpagecache's Issues

Add setting option to "bypass" query string parameters

Skipping the fullpage cache for requests that include a query string by default, is probably a good decision.
However, adding this feature would enable cached documents even for query string parameters that typically won't change the cached HTML response.

Example configuration in a Neos project would look like...

Flowpack:
  FullPageCache:
    bypassQueryStringParameters:
      - utm_source
      - utm_medium

I would give it a try and submit a PR, if there are no objections.

Aspect should use `flushByTags` in Neos 8

Flushing the tags would be much faster this way.

Flowpack.FullPageCache/Classes/Aspects/ContentCacheAspect.php

Line 51 in 4d943ed

$this->cacheFrontend->flushByTag($tag);

Make it possible (easier?) to disable full page cache for custom controllers

I don't see any obvious way of disabling the full page cache from a custom controller action that is called via GET without cookies or query parameters.

Unsetting a header on the response seems to be impossible (even with replaceHttpResponse) since it's merged.

The full page cache should consider a cache header from the action response like Cache-Control: no-cache. This would still result in misses for all requests. Better yet would be some kind of exclusion before the middleware e.g. by adding URI path exclusions via settings.

Flowpack_FullPageCache_Entries get removed on changes in User workspace

This means that the cache entries have to be rebuild, although Live has not changed.
I would expect that the affected entries in Flowpack_FullPageCache_Entries only get removed on publishing to Live workspace.

Is this a bug or are there any technical reasons for that?

Tested with Neos 4.3.12

Header for Cache-Control not set properly

The cache header being set is cachecontrol, but it should be cache-control (see https://developer.mozilla.org/de/docs/Web/HTTP/Headers/Cache-Control). This leads to the browser ignoring the cache header, like seen in the attached image. Current cache age exceeds the expected max-age because the cachecontrol header is ignored.

Niklas will open a PR to fix this issue in the near future.

Allow for the exclusion of cookies and by prefix to allow for dynamic ranges

In many cases specifically related to affiliate links there are dynamic cookies and dynamic query parameters generated in order to support this case I would recommend that it is possible to exclude entire ranges of parameters based on prefix, such as the following range of cookies where <wpid> is set from the partner domain _ga_<wpid>

My suggestion would be to configure prefixes as follows:

Flowpack:
  FullPageCache:
    request:
      cookieParams:
        ignorePrefix:
          - _ga_
      queryParams:
        ignorePrefix:
          - utm_

Compatibility with Neos 7